From c9fea99b4f5c6ddfc7ceafff3d6f75a12c2dd226 Mon Sep 17 00:00:00 2001 From: Gautam Verma Date: Thu, 13 Oct 2022 15:30:25 +0530 Subject: [PATCH] Get all certificates from NSX client.get method retrieves only the first page of results from NSX. In large scale environments, we wouldn't return all the Certificates. The patch fixes this behavior to return all the certificates on NSX Issue: #3048262 Change-Id: Ic43c28eb93bf706209980f66c97d217bd4c4d611 --- vmware_nsxlib/tests/unit/v3/test_trust_management.py | 6 +++--- vmware_nsxlib/v3/trust_management.py | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/vmware_nsxlib/tests/unit/v3/test_trust_management.py b/vmware_nsxlib/tests/unit/v3/test_trust_management.py index 0d14deda..1ec39d64 100644 --- a/vmware_nsxlib/tests/unit/v3/test_trust_management.py +++ b/vmware_nsxlib/tests/unit/v3/test_trust_management.py @@ -44,7 +44,7 @@ class TestNsxLibTrustManagement(nsxlib_testcase.NsxClientTestCase): def test_find_cert_with_pem_empty(self): pem = 'abc' - with mock.patch.object(self.nsxlib.client, 'get', + with mock.patch.object(self.nsxlib.client, 'list', return_value={'results': []}): results = self.nsxlib.trust_management.find_cert_with_pem(pem) self.assertEqual(0, len(results)) @@ -52,7 +52,7 @@ class TestNsxLibTrustManagement(nsxlib_testcase.NsxClientTestCase): def test_find_cert_with_pem_found(self): pem = consts.FAKE_CERT_PEM with mock.patch.object( - self.nsxlib.client, 'get', + self.nsxlib.client, 'list', return_value={'results': consts.FAKE_CERT_LIST}): results = self.nsxlib.trust_management.find_cert_with_pem(pem) self.assertEqual(1, len(results)) @@ -60,7 +60,7 @@ class TestNsxLibTrustManagement(nsxlib_testcase.NsxClientTestCase): def test_find_cert_with_pem_rn_found(self): pem = consts.FAKE_CERT_PEM.replace('\n', '\r\n') with mock.patch.object( - self.nsxlib.client, 'get', + self.nsxlib.client, 'list', return_value={'results': consts.FAKE_CERT_LIST}): results = self.nsxlib.trust_management.find_cert_with_pem(pem) self.assertEqual(1, len(results)) diff --git a/vmware_nsxlib/v3/trust_management.py b/vmware_nsxlib/v3/trust_management.py index b6afed68..080689aa 100644 --- a/vmware_nsxlib/v3/trust_management.py +++ b/vmware_nsxlib/v3/trust_management.py @@ -60,7 +60,7 @@ class NsxLibTrustManagement(utils.NsxLibApiBase): return self.client.get(resource) def get_certs(self): - return self.client.get(CERT_SECTION)['results'] + return self.client.list(CERT_SECTION)['results'] def delete_cert(self, cert_id): resource = CERT_SECTION + '/' + cert_id