x/vmware-nsxlib
Code Issues Proposed changes

Set firewall_match in Policy NAT Rule to Bypass by Default

Browse Source 
This is to align with NAT Rule behavior in Manager API

Change-Id: Ic1bfafbf9b1a74cd51e55f1b603ea145dadee01d
This commit is contained in:
Enhao Cui 2020-05-19 16:58:18 -07:00
parent 1e12405dc7
commit 7d29c09d67
2 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
vmware_nsxlib/tests/unit/v3/policy/test_transaction.py
View File

@ -260,11 +260,13 @@ class TestPolicyTransaction(policy_testcase.TestPolicyApi):
nat_rule1 = {"action": constants.NAT_ACTION_SNAT,
"display_name": "snat rule",
"id": nat_rule_id1,
"resource_type": "PolicyNatRule"}
"resource_type": "PolicyNatRule",
"firewall_match": constants.NAT_FIREWALL_MATCH_BYPASS}
nat_rule2 = {"action": constants.NAT_ACTION_DNAT,
"display_name": "dnat rule",
"id": nat_rule_id2,
"resource_type": "PolicyNatRule"}
"resource_type": "PolicyNatRule",
"firewall_match": constants.NAT_FIREWALL_MATCH_BYPASS}
policy_nat = {"id": "USER",
"resource_type": "PolicyNat",

4
vmware_nsxlib/v3/policy/core_resources.py
View File

@ -1610,7 +1610,7 @@ class NsxPolicyTier0NatRuleApi(NsxPolicyResourceBase):
source_network=IGNORE,
destination_network=IGNORE,
translated_network=IGNORE,
firewall_match=IGNORE,
firewall_match=constants.NAT_FIREWALL_MATCH_BYPASS,
action=IGNORE,
sequence_number=IGNORE,
log=IGNORE,
@ -1700,7 +1700,7 @@ class NsxPolicyTier1NatRuleApi(NsxPolicyResourceBase):
source_network=IGNORE,
destination_network=IGNORE,
translated_network=IGNORE,
firewall_match=IGNORE,
firewall_match=constants.NAT_FIREWALL_MATCH_BYPASS,
action=IGNORE,
sequence_number=IGNORE,
log=IGNORE,