b263b592b9
The LB VIP should be advertised by the Tier1 router only if it is on the external network. To do that, the global advertise vp flag will not be set, and instead a rule with a filter to advertise only the VIPs on the external network is added. In addition, an admin utility is added to update already existing routers with loadbalancers. Since VPNaaS also uses the router advertisement rules, its code was also updated so that each application will handle only its own rules. Change-Id: Ibfac0406a8c3009c323828cc42c96012e70cb0a9
283 lines
13 KiB
Python
283 lines
13 KiB
Python
# Copyright 2017 VMware, Inc.
|
|
# All Rights Reserved
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
from neutron_lib import exceptions as n_exc
|
|
from oslo_log import helpers as log_helpers
|
|
from oslo_log import log as logging
|
|
from oslo_utils import excutils
|
|
|
|
from vmware_nsx._i18n import _
|
|
from vmware_nsx.common import exceptions as nsx_exc
|
|
from vmware_nsx.common import locking
|
|
from vmware_nsx.db import db as nsx_db
|
|
from vmware_nsx.services.lbaas import base_mgr
|
|
from vmware_nsx.services.lbaas import lb_const
|
|
from vmware_nsx.services.lbaas.nsx_v3.implementation import lb_utils
|
|
from vmware_nsxlib.v3 import exceptions as nsxlib_exc
|
|
from vmware_nsxlib.v3 import utils
|
|
|
|
LOG = logging.getLogger(__name__)
|
|
|
|
|
|
class EdgeMemberManagerFromDict(base_mgr.Nsxv3LoadbalancerBaseManager):
|
|
@log_helpers.log_method_call
|
|
def __init__(self):
|
|
super(EdgeMemberManagerFromDict, self).__init__()
|
|
|
|
@log_helpers.log_method_call
|
|
def _get_info_from_fip(self, context, fip):
|
|
filters = {'floating_ip_address': [fip]}
|
|
floating_ips = self.core_plugin.get_floatingips(context,
|
|
filters=filters)
|
|
if floating_ips:
|
|
return (floating_ips[0]['fixed_ip_address'],
|
|
floating_ips[0]['router_id'])
|
|
else:
|
|
msg = (_('Member IP %(fip)s is an external IP, and is expected to '
|
|
'be a floating IP') % {'fip': fip})
|
|
raise n_exc.BadRequest(resource='lbaas-vip', msg=msg)
|
|
|
|
@log_helpers.log_method_call
|
|
def _create_lb_service(self, context, service_client, tenant_id,
|
|
router_id, nsx_router_id, lb_id, lb_size):
|
|
router = self.core_plugin.get_router(context, router_id)
|
|
if not router.get('external_gateway_info'):
|
|
msg = (_('Tenant router %(router)s does not connect to '
|
|
'external gateway') % {'router': router['id']})
|
|
raise n_exc.BadRequest(resource='lbaas-lbservice-create',
|
|
msg=msg)
|
|
lb_name = utils.get_name_and_uuid(router['name'] or 'router',
|
|
router_id)
|
|
tags = lb_utils.get_tags(self.core_plugin, router_id,
|
|
lb_const.LR_ROUTER_TYPE,
|
|
tenant_id, context.project_name)
|
|
attachment = {'target_id': nsx_router_id,
|
|
'target_type': 'LogicalRouter'}
|
|
try:
|
|
lb_service = service_client.create(display_name=lb_name,
|
|
tags=tags,
|
|
attachment=attachment,
|
|
size=lb_size)
|
|
except nsxlib_exc.ManagerError as e:
|
|
LOG.error("Failed to create LB service: %s", e)
|
|
return
|
|
|
|
# Add rule to advertise external vips
|
|
lb_utils.update_router_lb_vip_advertisement(
|
|
context, self.core_plugin, router, nsx_router_id)
|
|
|
|
return lb_service
|
|
|
|
def _get_updated_pool_members(self, context, lb_pool, member):
|
|
network = lb_utils.get_network_from_subnet(
|
|
context, self.core_plugin, member['subnet_id'])
|
|
if network.get('router:external'):
|
|
fixed_ip, router_id = self._get_info_from_fip(
|
|
context, member['address'])
|
|
else:
|
|
fixed_ip = member['address']
|
|
for m in lb_pool['members']:
|
|
if m['ip_address'] == fixed_ip:
|
|
m['display_name'] = member['name'][:219] + '_' + member['id']
|
|
m['weight'] = member['weight']
|
|
return lb_pool['members']
|
|
|
|
@log_helpers.log_method_call
|
|
def _add_loadbalancer_binding(self, context, lb_id, lbs_id,
|
|
nsx_router_id, vip_address):
|
|
# First check if there is already binding for the lb.
|
|
# If there is no binding for the lb, add the db binding.
|
|
binding = nsx_db.get_nsx_lbaas_loadbalancer_binding(
|
|
context.session, lb_id)
|
|
if not binding:
|
|
nsx_db.add_nsx_lbaas_loadbalancer_binding(
|
|
context.session, lb_id, lbs_id,
|
|
nsx_router_id, vip_address)
|
|
else:
|
|
LOG.debug("LB binding has already been added, and no need "
|
|
"to add here.")
|
|
|
|
def create(self, context, member, completor):
|
|
with locking.LockManager.get_lock(
|
|
'member-%s' % str(member['pool']['loadbalancer_id'])):
|
|
self._member_create(context, member, completor)
|
|
|
|
def _member_create(self, context, member, completor):
|
|
lb_id = member['pool']['loadbalancer_id']
|
|
pool_id = member['pool']['id']
|
|
loadbalancer = member['pool']['loadbalancer']
|
|
if not lb_utils.validate_lb_member_subnet(context, self.core_plugin,
|
|
member['subnet_id'],
|
|
loadbalancer):
|
|
completor(success=False)
|
|
msg = (_('Cannot add member %(member)s to pool as member subnet '
|
|
'%(subnet)s is neither public nor connected to the LB '
|
|
'router') %
|
|
{'member': member['id'], 'subnet': member['subnet_id']})
|
|
raise n_exc.BadRequest(resource='lbaas-subnet', msg=msg)
|
|
|
|
pool_client = self.core_plugin.nsxlib.load_balancer.pool
|
|
service_client = self.core_plugin.nsxlib.load_balancer.service
|
|
|
|
network = lb_utils.get_network_from_subnet(
|
|
context, self.core_plugin, member['subnet_id'])
|
|
if network.get('router:external'):
|
|
fixed_ip, router_id = self._get_info_from_fip(
|
|
context, member['address'])
|
|
if not router_id:
|
|
completor(success=False)
|
|
msg = (_('Floating ip %(fip)s has no router') % {
|
|
'fip': member['address']})
|
|
raise n_exc.BadRequest(resource='lbaas-vip', msg=msg)
|
|
else:
|
|
router_id = lb_utils.get_router_from_network(
|
|
context, self.core_plugin, member['subnet_id'])
|
|
fixed_ip = member['address']
|
|
|
|
binding = nsx_db.get_nsx_lbaas_pool_binding(context.session,
|
|
lb_id, pool_id)
|
|
if binding:
|
|
vs_id = binding.get('lb_vs_id')
|
|
lb_pool_id = binding.get('lb_pool_id')
|
|
lb_binding = nsx_db.get_nsx_lbaas_loadbalancer_binding(
|
|
context.session, lb_id)
|
|
lb_service = None
|
|
if not lb_binding:
|
|
nsx_router_id = nsx_db.get_nsx_router_id(context.session,
|
|
router_id)
|
|
lb_service = service_client.get_router_lb_service(
|
|
nsx_router_id)
|
|
virtual_server_ids = (lb_service and
|
|
lb_service.get('virtual_server_ids', []))
|
|
if not lb_service:
|
|
lb_size = lb_utils.get_lb_flavor_size(
|
|
self.flavor_plugin, context,
|
|
loadbalancer.get('flavor_id'))
|
|
lb_service = self._create_lb_service(
|
|
context, service_client, member['tenant_id'],
|
|
router_id, nsx_router_id, loadbalancer['id'], lb_size)
|
|
if lb_service:
|
|
lb_service_id = lb_service['id']
|
|
self._add_loadbalancer_binding(
|
|
context, loadbalancer['id'], lb_service_id,
|
|
nsx_router_id, loadbalancer['vip_address'])
|
|
else:
|
|
completor(success=False)
|
|
msg = (_('Failed to get lb service to attach virtual '
|
|
'server %(vs)s for member %(member)s') %
|
|
{'vs': vs_id, 'member': member['id']})
|
|
raise nsx_exc.NsxPluginException(err_msg=msg)
|
|
|
|
with locking.LockManager.get_lock('pool-member-%s' % lb_pool_id):
|
|
lb_pool = pool_client.get(lb_pool_id)
|
|
old_m = lb_pool.get('members', None)
|
|
new_m = [{
|
|
'display_name': member['name'][:219] + '_' + member['id'],
|
|
'ip_address': fixed_ip,
|
|
'port': member['protocol_port'],
|
|
'weight': member['weight']}]
|
|
members = (old_m + new_m) if old_m else new_m
|
|
pool_client.update_pool_with_members(lb_pool_id, members)
|
|
|
|
# Check whether the virtual server should be added to the load
|
|
# balancing server. It is safe to perform this operation after the
|
|
# member has been added to the pool. This allows us to skip this
|
|
# check if there is already a member in the pool
|
|
if vs_id and not old_m:
|
|
# load the LB service is not already loaded
|
|
if not lb_service:
|
|
nsx_router_id = nsx_db.get_nsx_router_id(context.session,
|
|
router_id)
|
|
lb_service = service_client.get_router_lb_service(
|
|
nsx_router_id)
|
|
lb_service_id = lb_service['id']
|
|
virtual_server_ids = lb_service.get('virtual_server_ids',
|
|
[])
|
|
if vs_id not in virtual_server_ids:
|
|
try:
|
|
service_client.add_virtual_server(lb_service_id, vs_id)
|
|
except nsxlib_exc.ManagerError:
|
|
completor(success=False)
|
|
msg = (_('Failed to attach virtual server %(vs)s '
|
|
'to lb service %(service)s') %
|
|
{'vs': vs_id, 'service': lb_service_id})
|
|
raise n_exc.BadRequest(resource='lbaas-member',
|
|
msg=msg)
|
|
else:
|
|
completor(success=False)
|
|
msg = (_('Failed to get pool binding to add member %s') %
|
|
member['id'])
|
|
raise nsx_exc.NsxPluginException(err_msg=msg)
|
|
|
|
completor(success=True)
|
|
|
|
def update(self, context, old_member, new_member, completor):
|
|
lb_id = old_member['pool']['loadbalancer_id']
|
|
pool_id = old_member['pool']['id']
|
|
pool_client = self.core_plugin.nsxlib.load_balancer.pool
|
|
pool_binding = nsx_db.get_nsx_lbaas_pool_binding(
|
|
context.session, lb_id, pool_id)
|
|
if pool_binding:
|
|
lb_pool_id = pool_binding.get('lb_pool_id')
|
|
try:
|
|
with locking.LockManager.get_lock('pool-member-%s' %
|
|
lb_pool_id):
|
|
lb_pool = pool_client.get(lb_pool_id)
|
|
updated_members = self._get_updated_pool_members(
|
|
context, lb_pool, new_member)
|
|
pool_client.update_pool_with_members(lb_pool_id,
|
|
updated_members)
|
|
except Exception as e:
|
|
with excutils.save_and_reraise_exception():
|
|
completor(success=False)
|
|
LOG.error('Failed to update member %(member)s: '
|
|
'%(err)s',
|
|
{'member': old_member['id'], 'err': e})
|
|
completor(success=True)
|
|
|
|
def delete(self, context, member, completor):
|
|
lb_id = member['pool']['loadbalancer_id']
|
|
pool_id = member['pool']['id']
|
|
pool_client = self.core_plugin.nsxlib.load_balancer.pool
|
|
pool_binding = nsx_db.get_nsx_lbaas_pool_binding(
|
|
context.session, lb_id, pool_id)
|
|
if pool_binding:
|
|
lb_pool_id = pool_binding.get('lb_pool_id')
|
|
try:
|
|
with locking.LockManager.get_lock('pool-member-%s' %
|
|
lb_pool_id):
|
|
lb_pool = pool_client.get(lb_pool_id)
|
|
network = lb_utils.get_network_from_subnet(
|
|
context, self.core_plugin, member['subnet_id'])
|
|
if network.get('router:external'):
|
|
fixed_ip, router_id = self._get_info_from_fip(
|
|
context, member['address'])
|
|
else:
|
|
fixed_ip = member['address']
|
|
if 'members' in lb_pool:
|
|
m_list = lb_pool['members']
|
|
members = [m for m in m_list
|
|
if m['ip_address'] != fixed_ip]
|
|
pool_client.update_pool_with_members(lb_pool_id,
|
|
members)
|
|
except nsxlib_exc.ResourceNotFound:
|
|
pass
|
|
except nsxlib_exc.ManagerError:
|
|
completor(success=False)
|
|
msg = _('Failed to remove member from pool on NSX backend')
|
|
raise n_exc.BadRequest(resource='lbaas-member', msg=msg)
|
|
|
|
completor(success=True)
|