x/vmware-nsx
Code Issues Proposed changes

NSX|V3: ensure that a VLAN network cannot be added to a router

Browse Source 
Only overlay networks can be added to logical routers. This patch
validates the type of network. If this is a VLAN network then it will
throw an exception.

Change-Id: I4e206073c9c658d04c51ec78c1e410b07da484ce
This commit is contained in:
Gary Kotton 2016-05-19 06:00:12 -07:00
parent 7cea8d2c40
commit 4747a72abf
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
vmware_nsx/plugins/nsx_v3/plugin.py
View File

@ -1688,6 +1688,13 @@ class NsxV3Plugin(agentschedulers_db.AZDhcpAgentSchedulerDbMixin,
net_id = self.get_subnet(context,
interface_info['subnet_id'])['network_id']
nsx_id = self._get_network_nsx_id(context, net_id)
nsx_network = nsxlib.get_logical_switch(nsx_id)
if nsx_network.get('vlan'):
err_msg = _("Only overlay networks can be attached to a logical "
"router. Network %s is a VLAN based network") % net_id
raise n_exc.InvalidInput(error_message=err_msg)
port_filters = {'device_owner': [l3_db.DEVICE_OWNER_ROUTER_INTF],
'network_id': [net_id]}
intf_ports = self.get_ports(context.elevated(), filters=port_filters)