x/stackalytics
Code Issues Proposed changes

Fix encoding issues for non-ASCII company names

Browse Source 
Change-Id: I466cccb5f24e78c791d7a060a1e0d06b9465e3c8
This commit is contained in:
Ilya Shakhat 2014-06-02 20:05:27 +04:00
parent 6dd3a29d1c
commit 42db4fccdf
2 changed files with 13 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
dashboard/static/js/stackalytics-ui.js
View File

@ -260,6 +260,12 @@ function extendWithGravatar(record, image_size) {
});
}
function encodeURI(s) {
s = encodeURIComponent(s);
s = s.replace("*", "%2A");
return s;
}
function getUrlVars() {
var vars = {};
window.location.href.replace(/[?&]+([^=&]+)=([^&]*)/gi, function (m, key, value) {
@ -270,7 +276,7 @@ function getUrlVars() {
function makeLink(id, title, param_name) {
var options = {};
options[param_name] = encodeURIComponent(id).toLowerCase();
options[param_name] = id.toLowerCase();
var link = makeURI("/", options);
return "<a href=\"" + link + "\">" + title + "</a>"
}
@ -282,7 +288,7 @@ function makeURI(uri, options) {
$.extend(ops, options);
}
var str = $.map(ops,function (val, index) {
return index + "=" + encodeURIComponent(val).toLowerCase();
return index + "=" + encodeURI(val).toLowerCase();
}).join("&");
return (str == "") ? uri : uri + "?" + str;
@ -301,7 +307,7 @@ function getPageState() {
function reload(extra) {
window.location.search = $.map($.extend(getUrlVars(), extra), function (val, index) {
return val? (index + "=" + encodeURIComponent(val)) : null;
return val? (index + "=" + val) : null;
}).join("&")
}
@ -322,7 +328,9 @@ function initSingleSelector(name, api_url, select2_extra_options, change_handler
dataType: "jsonp",
success: function (data) {
var initial_value = getUrlVars()[name];
if (!initial_value && data["default"]) {
if (initial_value) {
initial_value = encodeURI(initial_value);
} else if (data["default"]) {
initial_value = data["default"];
}
$(selectorId).

2
stackalytics/processor/utils.py
View File

@ -189,7 +189,7 @@ def add_index(sequence, start=1, item_filter=lambda x: True):
def safe_encode(s):
return parse.quote_plus(s.encode('utf-8'))
return parse.quote(s.encode('utf-8'))
def make_module_group(module_group_id, name=None, modules=None, tag='module'):