x/packstack
Code Issues Proposed changes

Replace broadcast address with 255.255.255.255 in tests

Browse Source 
The IP address being used would timeout after a minute on most
networks, slowing down tests unnecessarily

Change-Id: Id328462a3d81455725a66df1f050687e1bde3059
This commit is contained in:
Derek Higgins 2013-03-22 08:36:06 -04:00
parent fafbea9b13
commit 4105199519
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tests/installer/test_validators.py
View File

@ -83,12 +83,14 @@ class ValidatorsTestCase(PackstackTestCaseMixin, TestCase):
def test_validate_ping(self): def test_validate_ping(self):
"""Test packstack.installer.validators.validate_ping""" """Test packstack.installer.validators.validate_ping"""
# ping to broadcast fails # ping to broadcast fails
self.assertRaises(ParamValidationError, validate_ping, '192.168.122.0') self.assertRaises(ParamValidationError, validate_ping,
'255.255.255.255')
def test_validate_ssh(self): def test_validate_ssh(self):
"""Test packstack.installer.validators.validate_ssh""" """Test packstack.installer.validators.validate_ssh"""
# ssh to broadcast fails # ssh to broadcast fails
self.assertRaises(ParamValidationError, validate_ssh, '192.168.122.0') self.assertRaises(ParamValidationError, validate_ssh,
'255.255.255.255')
def test_validate_float(self): def test_validate_float(self):
"""Test packstack.installer.validators.validate_float""" """Test packstack.installer.validators.validate_float"""