starlingx/portieris-armada-app
Code Issues Proposed changes

Fix nonetype error in lifecycle override update

Browse Source 
This fixes the nonetype error seen during lifecycle hooks issued during
platform backup. An additional none check was added so that a none type
does not get passed to the rstrip function that caused the issue.

Test Plan:
PASS    With the changes, no lifecycle error is caused by the portieris
        app during platform backup.
PASS    Portieris application sanity test

Closes-bug: 2087987

Change-Id: I4c7204f5aaa72871a5818be834249e7274cbaff7
Signed-off-by: Tae Park <tae.park@windriver.com>
This commit is contained in:
Tae Park 2024-11-12 11:21:08 -05:00
parent 5423d6711b
commit 1087029151
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
python3-k8sapp-portieris/k8sapp_portieris/k8sapp_portieris/lifecycle/lifecycle_portieris.py
View File

@ -311,7 +311,7 @@ class PortierisAppLifecycleOperator(base.AppLifecycleOperator):
return overrides.user_overrides or "" return overrides.user_overrides or ""
def _update_helm_user_overrides(self, dbapi_instance, db_app_id, updated_overrides): def _update_helm_user_overrides(self, dbapi_instance, db_app_id, updated_overrides):
if updated_overrides.rstrip('\n') == '{}': if updated_overrides is not None and updated_overrides.rstrip('\n') == '{}':
updated_overrides = None updated_overrides = None
dbapi_instance.helm_override_update( dbapi_instance.helm_override_update(
app_id=db_app_id, app_id=db_app_id,