b24d4ce792
Unused workdir argument of the run_validations method removed. Host and playbook skipping simplified. Docstrings adjusted, including some of the more important inline code examples. Test sensitivity to API changes was increased. More strict assertions have been put on the calls made in CLI. Logging statements related to the run action in validation_actions.py were expanded. New debug level logging statements introduced. One of the testing constants in the fakes.py was altered as it was not accurate representation of the real data, and as such was breaking the new logging statements during unit test runs. Deprecation notice for 'log_path' and 'groups' arguments, in both docstring and logging. Redundant conditionals for argument types were removed. The checks of the arguments are implemented in the function called in the subsequent statement. As there is no scenario in which one set of these checks passes, while the other fails with the same values, we can consider one of them to be redundant. Helper function 'get_validations_details' without active references was removed from utils submodule. Signed-off-by: Jiri Podivin <jpodivin@redhat.com> Change-Id: I781f6a6f9fc4bd558af56b648f0e0ee9f165dfab
62 lines
2.0 KiB
Python
62 lines
2.0 KiB
Python
# Copyright 2020 Red Hat, Inc.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
#
|
|
|
|
try:
|
|
from unittest import mock
|
|
except ImportError:
|
|
import mock
|
|
from unittest import TestCase
|
|
|
|
from validations_libs.group import Group
|
|
from validations_libs.tests import fakes
|
|
|
|
|
|
class TestGroup(TestCase):
|
|
|
|
def setUp(self):
|
|
super(TestGroup, self).setUp()
|
|
|
|
@mock.patch('yaml.safe_load', return_value=fakes.GROUP)
|
|
@mock.patch('six.moves.builtins.open')
|
|
def test_get_data(self, mock_open, mock_yaml):
|
|
grp = Group('/tmp/foo')
|
|
data = grp.get_data
|
|
self.assertEqual(data, fakes.GROUP)
|
|
|
|
@mock.patch('yaml.safe_load', return_value=fakes.GROUP)
|
|
@mock.patch('six.moves.builtins.open')
|
|
def test_get_formated_group(self, mock_open, mock_yaml):
|
|
grp = Group('/tmp/foo')
|
|
ret = [('no-op', 'noop-foo'), ('post', 'post-foo'), ('pre', 'pre-foo')]
|
|
data = grp.get_formated_groups
|
|
self.assertEqual(data, ret)
|
|
|
|
@mock.patch('yaml.safe_load', return_value=fakes.GROUP)
|
|
@mock.patch('six.moves.builtins.open')
|
|
def test_get_groups_keys_list(self, mock_open, mock_yaml):
|
|
grp = Group('/tmp/foo')
|
|
ret = ['no-op', 'post', 'pre']
|
|
data = grp.get_groups_keys_list
|
|
self.assertEqual(data, ret)
|
|
|
|
@mock.patch('six.moves.builtins.open')
|
|
def test_group_file_not_found(self, mock_open):
|
|
mock_open.side_effect = IOError()
|
|
self.assertRaises(
|
|
IOError,
|
|
Group,
|
|
'non-existing.yaml'
|
|
)
|