openstack/validations-libs
Code Issues Proposed changes

Secondary loop removed. params_only dict now uses update method.

Browse Source 
Performance improvement is purely hypothetical.
However, the altered code is more readable.

Signed-off-by: Jiri Podivin <jpodivin@redhat.com>
Change-Id: Iaa85213a439ee4222c3d7fa6fc513458095b8ac3
This commit is contained in:
Jiri Podivin 2021-01-25 17:52:39 +01:00
parent 528c44b4e7
commit 45b8600a1a
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
validations_libs/validation_actions.py
View File

@ -387,8 +387,7 @@ class ValidationActions(object):
params_only = {}
with open(download_file, 'w') as f:
for val_name in params.keys():
for k, v in params[val_name].get('parameters').items():
params_only[k] = v
params_only.update(params[val_name].get('parameters'))
if output_format == 'json':
f.write(json.dumps(params_only,