From 3a3ea531e609f350c0906f1a305dbb805ea5a5ff Mon Sep 17 00:00:00 2001
From: Jiri Podivin <jpodivin@redhat.com>
Date: Mon, 12 Sep 2022 12:04:15 +0200
Subject: [PATCH] Removing superfluous imports and variable

Several of our modules have accumulated unused statements, mostly imports,
unused in the rest of the code and without any apparent purpose.

While not compromising functionality of our code directly,
they needlessly increase our cognitive load, and can potentially,
in absence of proper mitigation, introduce issues down the line.

Signed-off-by: Jiri Podivin <jpodivin@redhat.com>
Change-Id: I03da08a195a8468e4056522878ba3b391a368e14
---
 validations_libs/cli/common.py               | 1 -
 validations_libs/cli/history.py              | 1 -
 validations_libs/tests/cli/fakes.py          | 8 --------
 validations_libs/tests/cli/test_base.py      | 1 -
 validations_libs/tests/cli/test_colors.py    | 5 +----
 validations_libs/tests/cli/test_community.py | 3 ---
 validations_libs/tests/cli/test_show.py      | 2 --
 validations_libs/utils.py                    | 1 -
 8 files changed, 1 insertion(+), 21 deletions(-)

diff --git a/validations_libs/cli/common.py b/validations_libs/cli/common.py
index 038732c8..148a0f1b 100644
--- a/validations_libs/cli/common.py
+++ b/validations_libs/cli/common.py
@@ -32,7 +32,6 @@ except ImportError:
     JUNIT_XML_FOUND = False
 
 from validations_libs.cli import colors
-from validations_libs import utils
 
 # Handle backward compatibility for Cliff 2.16.0 in stable/train:
 if hasattr(_argparse, 'SmartHelpFormatter'):
diff --git a/validations_libs/cli/history.py b/validations_libs/cli/history.py
index c4eb0b33..3427cc01 100644
--- a/validations_libs/cli/history.py
+++ b/validations_libs/cli/history.py
@@ -51,7 +51,6 @@ class ListHistory(BaseLister):
         # Merge config and CLI args:
         self.base.set_argument_parser(self, parsed_args)
 
-        validation_log_dir = parsed_args.validation_log_dir
         history_limit = parsed_args.history_limit
 
         if history_limit < 1:
diff --git a/validations_libs/tests/cli/fakes.py b/validations_libs/tests/cli/fakes.py
index 8de80455..54d3395d 100644
--- a/validations_libs/tests/cli/fakes.py
+++ b/validations_libs/tests/cli/fakes.py
@@ -17,14 +17,6 @@ import sys
 from unittest import TestCase
 
 from validations_libs.cli import app
-from validations_libs.cli import base
-from validations_libs import utils
-
-
-try:
-    from unittest import mock
-except ImportError:
-    import mock
 
 
 class BaseCommand(TestCase):
diff --git a/validations_libs/tests/cli/test_base.py b/validations_libs/tests/cli/test_base.py
index f4bdeb37..ab822ca7 100644
--- a/validations_libs/tests/cli/test_base.py
+++ b/validations_libs/tests/cli/test_base.py
@@ -17,7 +17,6 @@ try:
     from unittest import mock
 except ImportError:
     import mock
-from unittest import TestCase
 
 from validations_libs.cli import lister
 from validations_libs.cli import base
diff --git a/validations_libs/tests/cli/test_colors.py b/validations_libs/tests/cli/test_colors.py
index a1bce47f..0de94ec3 100644
--- a/validations_libs/tests/cli/test_colors.py
+++ b/validations_libs/tests/cli/test_colors.py
@@ -12,10 +12,7 @@
 #   License for the specific language governing permissions and limitations
 #   under the License.
 #
-try:
-    from unittest import mock
-except ImportError:
-    import mock
+
 from unittest import TestCase
 
 from validations_libs.cli import colors
diff --git a/validations_libs/tests/cli/test_community.py b/validations_libs/tests/cli/test_community.py
index 781002d5..8251f178 100644
--- a/validations_libs/tests/cli/test_community.py
+++ b/validations_libs/tests/cli/test_community.py
@@ -19,9 +19,6 @@ except ImportError:
 
 from validations_libs.cli import community
 from validations_libs.cli import base
-from validations_libs.community.init_validation import \
-    CommunityValidation as cv
-from validations_libs.tests import fakes
 from validations_libs.tests.cli.fakes import BaseCommand
 
 
diff --git a/validations_libs/tests/cli/test_show.py b/validations_libs/tests/cli/test_show.py
index 1c909269..4f62ead1 100644
--- a/validations_libs/tests/cli/test_show.py
+++ b/validations_libs/tests/cli/test_show.py
@@ -17,8 +17,6 @@ try:
 except ImportError:
     import mock
 
-from validations_libs import group
-from validations_libs.validation_actions import ValidationActions
 from validations_libs.cli import show
 from validations_libs.tests import fakes
 from validations_libs.tests.cli.fakes import BaseCommand
diff --git a/validations_libs/utils.py b/validations_libs/utils.py
index 7cbaf894..1a4b122d 100644
--- a/validations_libs/utils.py
+++ b/validations_libs/utils.py
@@ -22,7 +22,6 @@ import site
 import subprocess
 import uuid
 
-from os.path import join
 # @matbu backward compatibility for stable/train
 try:
     from pathlib import Path