openstack/validations-common
Code Issues Proposed changes

fix var name in logging statement

Browse Source 
The variable referenced	in the logging statement
of the job was not the one on which the assertion was made.

As a result the	message	was confusing.

Signed-off-by: Jiri Podivin <jpodivin@redhat.com>
Change-Id: I56bfd351ab3be0d9f3c87694692f878d00d45c4f
This commit is contained in:
Jiri Podivin 2021-07-07 07:53:43 +02:00
parent 23cf1533a4
commit 205f96af65
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
playbooks/coverchange.yaml
View File

@ -94,7 +94,7 @@
assert:
that: "{{ (coverage_after_total.stdout | float) }} >= {{ (coverage_before_total.stdout | float) }}"
fail_msg: |
Before the change {{ (coverage_before.stdout | float)*100 }}% of the lines were covered.
Before the change {{ (coverage_before_total.stdout | float)*100 }}% of the lines were covered.
Now it's {{ (coverage_after_total.stdout | float )*100 }}%. Did you write your unit tests?
success_msg: |
Code coverage check successful, {{ (coverage_before_total.stdout | float) * 100 }}% of code is now covered.