openstack/ui-cookiecutter
Code Issues Proposed changes

Use detailRoute constant for path of details view

Browse Source 
This patch replaces hard coded "project/ngdetails/" for path of
details view to constant using "horizon.app.core.detailRoute".

Change-Id: I57232feb09b38adc436b2da2de9bce445ba35906
Closes-Bug: #1641250
This commit is contained in:
Shu Muto 2017-03-21 15:49:40 +09:00
parent e882e115f3
commit 6e9c342e91
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
{{cookiecutter.repo_name}}/{{cookiecutter.module_folder}}/static/dashboard/{{cookiecutter.panel_group}}/{{cookiecutter.panel}}s/{{cookiecutter.panel}}s.service.js
View File

@ -21,6 +21,7 @@
service.$inject = [
'$filter',
'horizon.app.core.detailRoute',
'horizon.app.core.openstack-service-api.{{cookiecutter.api_module}}'
];
@ -34,7 +35,7 @@
* but do not need to be restricted to such use. Each exposed function
* is documented below.
*/
function service($filter, api) {
function service($filter, detailRoute, api) {
return {
getPromise: getPromise,
urlFunction: urlFunction
@ -55,7 +56,7 @@
}
function urlFunction(item) {
return 'project/ngdetails/OS::{{cookiecutter.api_name}}::{{cookiecutter.panel_func}}/' + item.id;
return detailRoute + 'OS::{{cookiecutter.api_name}}::{{cookiecutter.panel_func}}/' + item.id;
}
}
})();

3
{{cookiecutter.repo_name}}/{{cookiecutter.module_folder}}/static/dashboard/{{cookiecutter.panel_group}}/{{cookiecutter.panel}}s/{{cookiecutter.panel}}s.service.spec.js
View File

@ -40,8 +40,9 @@
describe('urlFunction', function() {
it("get url", inject(function() {
var detailRoute = $injector.get('horizon.app.core.detailRoute');
var result = service.urlFunction({id:"123abc"});
expect(result).toBe("project/ngdetails/OS::{{cookiecutter.api_name}}::{{cookiecutter.panel_func}}/123abc");
expect(result).toBe(detailRoute + "OS::{{cookiecutter.api_name}}::{{cookiecutter.panel_func}}/123abc");
}));
});