openstack/nova
Code Issues Proposed changes

Merge "Use hard coded values in schema than reference"

Browse Source
This commit is contained in:
Zuul 2018-07-18 04:47:10 +00:00 committed by Gerrit Code Review
commit fd6ba0f5c5
3 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
nova/api/openstack/compute/schemas/flavor_manage.py
View File

@ -15,7 +15,6 @@
import copy import copy
from nova.api.validation import parameter_types from nova.api.validation import parameter_types
from nova.db import api as db
create = { create = {
'type': 'object', 'type': 'object',
@ -42,7 +41,9 @@ create = {
'type': ['number', 'string'], 'type': ['number', 'string'],
'pattern': '^[0-9]+(\.[0-9]+)?$', 'pattern': '^[0-9]+(\.[0-9]+)?$',
'minimum': 0, 'exclusiveMinimum': True, 'minimum': 0, 'exclusiveMinimum': True,
'maximum': db.SQL_SP_FLOAT_MAX # maximum's value is limited to db constant's
# SQL_SP_FLOAT_MAX (in nova/db/constants.py)
'maximum': 3.40282e+38
}, },
'os-flavor-access:is_public': parameter_types.boolean, 'os-flavor-access:is_public': parameter_types.boolean,
}, },

5
nova/api/openstack/compute/schemas/quota_sets.py
View File

@ -15,14 +15,15 @@
import copy import copy
from nova.api.validation import parameter_types from nova.api.validation import parameter_types
from nova.db import api as db
common_quota = { common_quota = {
'type': ['integer', 'string'], 'type': ['integer', 'string'],
'pattern': '^-?[0-9]+$', 'pattern': '^-?[0-9]+$',
# -1 is a flag value for unlimited # -1 is a flag value for unlimited
'minimum': -1, 'minimum': -1,
'maximum': db.MAX_INT # maximum's value is limited to db constant's MAX_INT
# (in nova/db/constants.py)
'maximum': 0x7FFFFFFF
} }
quota_resources = { quota_resources = {

5
nova/api/validation/parameter_types.py
View File

@ -21,7 +21,6 @@ import unicodedata
import six import six
from nova.db import api as db
from nova.i18n import _ from nova.i18n import _
from nova.objects import tag from nova.objects import tag
@ -427,7 +426,9 @@ volume_size = {
'type': ['integer', 'string'], 'type': ['integer', 'string'],
'pattern': '^[0-9]+$', 'pattern': '^[0-9]+$',
'minimum': 1, 'minimum': 1,
'maximum': db.MAX_INT # maximum's value is limited to db constant's MAX_INT
# (in nova/db/constants.py)
'maximum': 0x7FFFFFFF
} }
disk_config = { disk_config = {