openstack/nova
Code Issues Proposed changes

libvirt: fix alternative_device_name for detaching interfaces

Browse Source 
There are two changes here:

1. Get the actual vif device name for logging, e.g. tap3e81295f-c1
2. Log that in detach_device_with_retry so we're not logging an
   LibvirtConfigGuestInterface object.

Change-Id: I7588c17a9936eb765269c662cad4cbedc5f58fbf
Related-Bug: #1696125
This commit is contained in:
Matt Riedemann 2017-06-08 14:28:50 -04:00
parent 7681d3dcc0
commit fabfb347f5
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
nova/virt/libvirt/driver.py
View File

@ -1467,7 +1467,7 @@ class LibvirtDriver(driver.ComputeDriver):
# timeout.
wait_for_detach = guest.detach_device_with_retry(
guest.get_interface_by_cfg, cfg, live=live,
alternative_device_name=vif.get('address'))
alternative_device_name=self.vif_driver.get_vif_devname(vif))
wait_for_detach()
except exception.DeviceNotFound:
# The interface is gone so just log it as a warning.

6
nova/virt/libvirt/guest.py
View File

@ -429,9 +429,11 @@ class Guest(object):
persistent = self.has_persistent_configuration()
LOG.debug('Attempting initial detach for device %s', device)
LOG.debug('Attempting initial detach for device %s',
alternative_device_name)
_try_detach_device(conf, persistent, live)
LOG.debug('Start retrying detach until device %s is gone.', device)
LOG.debug('Start retrying detach until device %s is gone.',
alternative_device_name)
@loopingcall.RetryDecorator(max_retry_count=max_retry_count,
inc_sleep_time=inc_sleep_time,