openstack/nova
Code Issues Proposed changes

Fix mock arg list order in test_driver.py

Browse Source 
When we use nest patch decorators the mocks, they are passed in to the
decorated function in the same order they applied, this means should be
from the bottom up. Though We have never use these arguments in this
function and the order may not very important, it's a little misleading.
So I think we should fix it.

Change-Id: I459780a17998382b61f56377bfa17651a5f99f51
This commit is contained in:
int32bit 2016-11-13 17:37:14 +08:00
parent 72d0c3a484
commit f80163dde7
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
nova/tests/unit/virt/libvirt/test_driver.py
View File

@ -3883,8 +3883,8 @@ class LibvirtConnTestCase(test.NoDBTestCase):
@mock.patch('os.path.getsize', return_value=0) # size doesn't matter
@mock.patch('nova.virt.libvirt.storage.lvm.get_volume_size',
return_value='fake-size')
def test_detach_encrypted_volumes(self, mock_getsize,
mock_get_volume_size):
def test_detach_encrypted_volumes(self, mock_get_volume_size,
mock_getsize):
"""Test that unencrypted volumes are not disconnected with dmcrypt."""
instance = objects.Instance(**self.test_instance)
xml = """