openstack/nova
Code Issues Proposed changes

Merge "Fix os-console-output policy to be admin_or_owner"

Browse Source
This commit is contained in:
Zuul 2020-03-05 21:32:59 +00:00 committed by Gerrit Code Review
commit f176ffe6e5
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
nova/api/openstack/compute/console_output.py
View File

@ -38,9 +38,10 @@ class ConsoleOutputController(wsgi.Controller):
def get_console_output(self, req, id, body):
"""Get text console output."""
context = req.environ['nova.context']
context.can(co_policies.BASE_POLICY_NAME)
instance = common.get_instance(self.compute_api, context, id)
context.can(co_policies.BASE_POLICY_NAME,
target={'project_id': instance.project_id})
length = body['os-getConsoleOutput'].get('length')
# TODO(cyeoh): In a future API update accept a length of -1
# as meaning unlimited length (convert to None)

1
nova/tests/unit/api/openstack/compute/test_console_output.py
View File

@ -156,6 +156,7 @@ class ConsoleOutputPolicyEnforcementV21(test.NoDBTestCase):
def setUp(self):
super(ConsoleOutputPolicyEnforcementV21, self).setUp()
self.controller = console_output_v21.ConsoleOutputController()
self.stub_out('nova.compute.api.API.get', fake_get)
def test_get_console_output_policy_failed(self):
rule_name = "os_compute_api:os-console-output"