From bcd78caaf574cfbf121584e1d7a335daf0675b15 Mon Sep 17 00:00:00 2001 From: jichenjc Date: Tue, 24 Nov 2015 14:47:16 +0800 Subject: [PATCH] Add review guideline to microversion API Python-novaclient need to be updated to address new microversion API change , so add some suggestions in the doc. Change-Id: Ibb2d137a6a16badea7c2619d210317b7a098ec4e --- doc/source/api_microversion_dev.rst | 3 +++ doc/source/code-review.rst | 8 ++++++++ 2 files changed, 11 insertions(+) diff --git a/doc/source/api_microversion_dev.rst b/doc/source/api_microversion_dev.rst index 54ad7791ba42..6b309260c381 100644 --- a/doc/source/api_microversion_dev.rst +++ b/doc/source/api_microversion_dev.rst @@ -310,6 +310,9 @@ necessary to add changes to other places which describe your change: ``doc/api_samples/versions/versions-get-resp.json`` and ``nova/tests/functional/api_samples/versions/versions-get-resp.json.tpl``. +* Make a new commit to python-novaclient and update corresponding + files to enable the newly added microversion API. + Allocating a microversion ------------------------- diff --git a/doc/source/code-review.rst b/doc/source/code-review.rst index 444f1bd42a25..7f367e18eb2f 100644 --- a/doc/source/code-review.rst +++ b/doc/source/code-review.rst @@ -152,6 +152,14 @@ Please note: * We are only talking about the testing of in-tree code. Please note the only public API is our REST API, see: :doc:`policies` +Microversion API +================ + +* If an new microversion API is added, the following needs to happen: + + * A new patch for the microversion API change in python-novaclient side + should be submitted. + Release Notes =============