From 2cea9b04139a0b64f1bda5b777c062e207d739f9 Mon Sep 17 00:00:00 2001
From: Mandar Vaze <mandar.vaze@vertex.co.in>
Date: Mon, 2 Apr 2012 03:02:22 -0700
Subject: [PATCH] Disallow network creation when label > 255. Fixes bug 965008

Added length check for label. Without length check,
label is truncated. Warning is shown by sqlalchemy layer.

Raise an InvalidInput exception when validation fails (like
rest of the surroudning code)

Change-Id: Iae517e03099e36f1c00f4742049834a9231a2fff
---
 Authors         | 1 -
 bin/nova-manage | 4 ++++
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/Authors b/Authors
index 3a451dd2f240..5f4da06400b6 100644
--- a/Authors
+++ b/Authors
@@ -126,7 +126,6 @@ Lorin Hochstein <lorin@nimbisservices.com>
 Lvov Maxim <usrleon@gmail.com>
 Mandar Vaze <mandar.vaze@vertex.co.in>
 Mandell Degerness <mdegerne@gmail.com>
-Mandar Vaze <mandar.vaze@vertex.co.in>
 Mark McClain <mark.mcclain@dreamhost.com>
 Mark McLoughlin <markmc@redhat.com>
 Mark Washenberger <mark.washenberger@rackspace.com>
diff --git a/bin/nova-manage b/bin/nova-manage
index 53c4fd6f30a3..bd68578188f7 100755
--- a/bin/nova-manage
+++ b/bin/nova-manage
@@ -740,6 +740,10 @@ class NetworkCommands(object):
         # check for certain required inputs
         if not label:
             raise exception.NetworkNotCreated(req='--label')
+        # Size of "label" column in nova.networks is 255, hence the restriction
+        if len(label) > 255:
+            reason = _("Maximum allowed length for 'label' is 255.")
+            raise exception.InvalidInput(reason=reason)
         if not (fixed_range_v4 or fixed_range_v6):
             req = '--fixed_range_v4 or --fixed_range_v6'
             raise exception.NetworkNotCreated(req=req)