openstack/nova
Code Issues Proposed changes

policy: Deprecate field from 'os-extended-server-attributes' policy

Browse Source 
Indicate that the 'os_compute_api:os-extended-server-attributes' will no
longer control visibility of the 'OS-EXT-SRV-ATTR:hostname' attribute in
a future release, following a deprecation period.

Change-Id: I981a3bdb6c2f11f294cbb01689cf927d216b2439
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
This commit is contained in:
Stephen Finucane 2021-08-26 10:54:25 +01:00
parent 5e2c31ab78
commit cfa33d3b06
3 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
nova/api/openstack/compute/views/servers.py
View File

@ -408,6 +408,8 @@ class ViewBuilder(common.ViewBuilder):
trusted_certs = instance.trusted_certs.ids
server["server"]["trusted_image_certificates"] = trusted_certs
# TODO(stephenfin): Remove this check once we remove the
# OS-EXT-SRV-ATTR:hostname policy checks from the policy is Y or later
if api_version_request.is_supported(request, min_version='2.90'):
# API 2.90 made this field visible to non-admins, but we only show
# it if it's not already added

3
nova/policies/extended_server_attributes.py
View File

@ -45,7 +45,8 @@ also controlled by this policy rule, like the ``GET /servers*`` APIs.
Microversion 2.90 made the ``OS-EXT-SRV-ATTR:hostname`` attribute available to
all users, so this policy has no effect on that field for microversions 2.90
and greater.
and greater. Controlling the visibility of this attribute for all microversions
is therefore deprecated and will be removed in a future release.
""",
operations=[
{

8
releasenotes/notes/microversion-2-90-59fb6d4ec420b9f4.yaml
View File

@ -14,3 +14,11 @@ features:
In addition, starting with the 2.90 microversion, the
``OS-EXT-SRV-ATTR:hostname`` field is now returned for all users.
Previously this was restricted to admin users.
deprecations:
- |
The ``os_compute_api:os-extended-server-attributes`` policy controls
which users a number of server extended attributes are shown to.
Configuring visiblity of the ``OS-EXT-SRV-ATTR:hostname`` attribute via
this policy has now been deprecated and will be removed in a future
release. Upon removal, this attribute will be shown for all users
regardless of policy configuration.