doc: link to nova code review guide from dev policies
The development policies section on code review was linking to the generic openstack review guidelines but we have nova-specific guidelines as well so this changes the policies page to link to the nova code review guidelines, links the general guidelines into the nova page, and also fixes a formatting issue in the nova code review guidelines page. Change-Id: I725570d0d737f18fe8b105dc8382c4abcfdef295
This commit is contained in:
parent
46a02d5eb5
commit
c5557f03da
@ -4,7 +4,10 @@
|
||||
Code Review Guide for Nova
|
||||
==========================
|
||||
|
||||
This is a very terse set of points for reviewers to consider when
|
||||
OpenStack has a general set of code review guidelines:
|
||||
https://docs.openstack.org/infra/manual/developers.html#peer-review
|
||||
|
||||
What follows is a very terse set of points for reviewers to consider when
|
||||
looking at nova code. These are things that are important for the
|
||||
continued smooth operation of Nova, but that tend to be carried as
|
||||
"tribal knowledge" instead of being written down. It is an attempt to
|
||||
@ -22,7 +25,7 @@ RPC API Versions
|
||||
|
||||
* The manager-side (example: compute/manager) needs a version bump
|
||||
* The manager-side method needs to tolerate older calls as well as
|
||||
newer calls
|
||||
newer calls
|
||||
* Arguments can be added as long as they are optional. Arguments
|
||||
cannot be removed or changed in an incompatible way.
|
||||
* The RPC client code (example: compute/rpcapi.py) needs to be able
|
||||
|
@ -59,7 +59,7 @@ As a patch author, you should try to offset the reviewer resources
|
||||
spent on your patch by reviewing other patches. If no one does this, the review
|
||||
team (cores and otherwise) become spread too thin.
|
||||
|
||||
For review guidelines see: https://docs.openstack.org/infra/manual/developers.html#peer-review
|
||||
For review guidelines see: :doc:`code-review`
|
||||
|
||||
Reverts for Retrospective Vetos
|
||||
===============================
|
||||
|
Loading…
x
Reference in New Issue
Block a user