From a85d052a220190fe630847fcd21c2a20abd7502f Mon Sep 17 00:00:00 2001 From: Takashi Natsume Date: Sat, 13 Aug 2022 23:34:25 +0900 Subject: [PATCH] Add missing descriptions in HACKING.rst This patch is a follow-up patch for the following changes. Ia7bcb40a21a804c7bc6b74f501d95ce2a88b09b5 Ie107a95bc06390ab519d3b3af9b07103a9a14316 I71439580e80d33cff62aba807df2b35164a47cbe Change-Id: I244396fb96b01ebab875234f25097637ff1b1dbb Signed-off-by: Takashi Natsume --- HACKING.rst | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/HACKING.rst b/HACKING.rst index 0f98901864d6..a2f67d993b62 100644 --- a/HACKING.rst +++ b/HACKING.rst @@ -71,6 +71,11 @@ Nova Specific Commandments - [N367] Disallow aliasing the mock.Mock and similar classes in tests. - [N368] Reject if the mock.Mock class is used as a replacement value instead of and instance of a mock.Mock during patching in tests. +- [N369] oslo_concurrency.lockutils.ReaderWriterLock() or + fasteners.ReaderWriterLock() does not function correctly + with eventlet patched code. Use nova.utils.ReaderWriterLock() instead. +- [N370] Don't use or import six +- [N371] You must explicitly import python's mock: ``from unittest import mock`` Creating Unit Tests -------------------