openstack/nova
Code Issues Proposed changes

db: Drop support for experimental concurrency

Browse Source 
The 'oslo_db.concurrency.TpoolDbapiWrapper' wrapper provides a way to
enable the experimental use of thread pooling for all DB API calls. This
has been part of 'oslo.db' since that project was first split out on
nova back in change I0649539e071b2318ec85ed5d70259c949408e64b and has
been part of nova for even longer, having been first introduced in
change Id7de85dce11f5ea61dfccddf80de7800a2bc4e37. However, this has not
graduated to non-experimental status in the 7 years since and is
unlikely to so now. It also isn't used for any of the API DB calls.
Hasta la vista, 'TpoolDbapiWrapper'. You've had a good ride.

Change-Id: I1ce8f180d6bef465f9faa0a10c837841ed7ab528
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
This commit is contained in:
Stephen Finucane 2021-02-15 16:59:44 +00:00
parent 014480d52f
commit 9799468d6f
3 changed files with 12 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
etc/nova/nova-config-generator.conf
View File

@ -10,7 +10,6 @@ namespace = oslo.privsep
namespace = oslo.service.periodic_task
namespace = oslo.service.service
namespace = oslo.db
namespace = oslo.db.concurrency
namespace = oslo.middleware
namespace = oslo.concurrency
namespace = keystonemiddleware.auth_token

8
nova/db/api.py
View File

@ -27,17 +27,17 @@ these objects be simple dictionaries.
"""
from oslo_db import concurrency
from oslo_db import api
from oslo_log import log as logging
import nova.conf
CONF = nova.conf.CONF
LOG = logging.getLogger(__name__)
_BACKEND_MAPPING = {'sqlalchemy': 'nova.db.sqlalchemy.api'}
IMPL = concurrency.TpoolDbapiWrapper(CONF, backend_mapping=_BACKEND_MAPPING)
IMPL = api.DBAPI.from_config(
conf=CONF, backend_mapping={'sqlalchemy': 'nova.db.sqlalchemy.api'},
)
###################

8
releasenotes/notes/drop-oslo_db-use_tpool-48542a28d10e1bae.yaml Normal file
View File

@ -0,0 +1,8 @@
---
upgrade:
- |
Experimental support for thread pooling of DB API calls has been removed.
This feature was first introduced in the 2014.2 (Juno) release but has not
graduated to fully-supported status since nor was it being used for any
API DB calls. The ``[oslo_db] use_tpool`` config option used to enable
this feature will now be ignored by nova.