openstack/nova
Code Issues Proposed changes

Port test_matchers.TestDictMatches.test__str__ to Python 3

Browse Source 
Method pprint.pformat(OrderedDict)'s output is different on Python 2
and Python 3. Its outputs equals "DictMatches({0})".format(OrderedDict)
only on Python 2. Let's just use pprint.pformat.

Partially-Implements: blueprint goal-python35

Change-Id: I220a7edf4f8f35ecb3763e4e3817c6c6c024efd9
This commit is contained in:
ChangBo Guo(gcb) 2016-12-03 15:10:02 +08:00
parent 4c05cb0913
commit 8f4dfdb55d
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
nova/tests/unit/test_matchers.py
View File

@ -12,6 +12,7 @@
# License for the specific language governing permissions and limitations
# under the License.
from collections import OrderedDict
import pprint
import testtools
from testtools.tests.matchers import helpers
@ -43,7 +44,7 @@ class TestDictMatches(testtools.TestCase, helpers.TestMatchersInterface):
]
str_examples = [
("DictMatches({0})".format(matches_dict),
('DictMatches(%s)' % (pprint.pformat(matches_dict)),
matches_matcher),
]

1
tests-py3.txt
View File

@ -10,7 +10,6 @@ nova.tests.unit.compute.test_compute.ComputeAPITestCase.test_create_with_base64_
nova.tests.unit.compute.test_compute_cells.CellsComputeAPITestCase.test_create_with_base64_user_data
nova.tests.unit.compute.test_compute_mgr.ComputeManagerUnitTestCase.test_run_pending_deletes
nova.tests.unit.compute.test_host_api.ComputeHostAPICellsTestCase
nova.tests.unit.test_matchers.TestDictMatches.test__str__
nova.tests.unit.test_wsgi.TestWSGIServerWithSSL
nova.tests.unit.virt.libvirt.storage.test_rbd.RbdTestCase
nova.tests.unit.virt.libvirt.test_firewall.IptablesFirewallTestCase