From 838706ded9feaf36028acdce33f54702ac29a77f Mon Sep 17 00:00:00 2001 From: Takashi Kajinami Date: Mon, 15 Nov 2021 19:34:50 +0900 Subject: [PATCH] Deprecate [wsgi] secure_proxy_ssl_header The functionality of this parameter is same as the http_proxy_to_wsgi middleware in oslo.middleware. The http_proxy_to_wsgi middleware is widely used in multiple OpenStack services and has been enabled in default pipelines for several cycles. So the own implementation can be completely replaced by the common one provided by the oslo library. Change-Id: I5db80ca504e444346afcc264d3260861e54f266d --- nova/conf/wsgi.py | 6 ++++++ .../deprecate-secure_proxy_ssl_header-cc0bf562efaa5eba.yaml | 5 +++++ 2 files changed, 11 insertions(+) create mode 100644 releasenotes/notes/deprecate-secure_proxy_ssl_header-cc0bf562efaa5eba.yaml diff --git a/nova/conf/wsgi.py b/nova/conf/wsgi.py index 6883b28f51ad..50e653d083bc 100644 --- a/nova/conf/wsgi.py +++ b/nova/conf/wsgi.py @@ -71,6 +71,12 @@ Possible values: cfg.StrOpt( 'secure_proxy_ssl_header', deprecated_group='DEFAULT', + deprecated_for_removal=True, + deprecated_since='31.0.0', + deprecated_reason=""" +The functionality of this parameter is duplicate of the http_proxy_to_wsgi +middleware of oslo.middleware and will be completely replaced. +""", help=""" This option specifies the HTTP header used to determine the protocol scheme for the original request, even if it was removed by a SSL terminating proxy. diff --git a/releasenotes/notes/deprecate-secure_proxy_ssl_header-cc0bf562efaa5eba.yaml b/releasenotes/notes/deprecate-secure_proxy_ssl_header-cc0bf562efaa5eba.yaml new file mode 100644 index 000000000000..8e3fc02287e3 --- /dev/null +++ b/releasenotes/notes/deprecate-secure_proxy_ssl_header-cc0bf562efaa5eba.yaml @@ -0,0 +1,5 @@ +--- +deprecations: + - | + The ``[wsgi] secure_proxy_ssl_header`` parameter has been deprecated. Use + the ``http_proxy_to_wsgi`` middleware from ``oslo.middleware`` instead.