From 6919b25ce0b9ae780074c6e2efe5c4b9fdead8c9 Mon Sep 17 00:00:00 2001 From: Markus Zoeller Date: Wed, 18 May 2016 14:06:56 +0200 Subject: [PATCH] deprecate config option "fatal_exception_format_errors" The config option "fatal_exception_format_errors" got introduced purely for testing purposes with commit 2e80b297. This isn't an option the ops would change from it's default value. This change deprecates the option. When this option gets removed in the future, we can hardcode that wrong formats should be fatal by default, as it is already set today in "nova/conf_fixture.py". Change-Id: I184b1b1cbd85f136cee120965e38e2ef87bb66ff --- nova/conf/exceptions.py | 4 +++- ...cate-fatal-exception-format-errors-a5d2bf64e3404c39.yaml | 6 ++++++ 2 files changed, 9 insertions(+), 1 deletion(-) create mode 100644 releasenotes/notes/deprecate-fatal-exception-format-errors-a5d2bf64e3404c39.yaml diff --git a/nova/conf/exceptions.py b/nova/conf/exceptions.py index cfdb176e6f09..68254e2baf5a 100644 --- a/nova/conf/exceptions.py +++ b/nova/conf/exceptions.py @@ -18,7 +18,9 @@ from oslo_config import cfg exc_log_opts = [ cfg.BoolOpt('fatal_exception_format_errors', default=False, - help='Make exception message format errors fatal'), + deprecated_for_removal=True, + deprecated_reason='This is only used for internal testing.', + help='DEPRECATED: Make exception message format errors fatal'), ] diff --git a/releasenotes/notes/deprecate-fatal-exception-format-errors-a5d2bf64e3404c39.yaml b/releasenotes/notes/deprecate-fatal-exception-format-errors-a5d2bf64e3404c39.yaml new file mode 100644 index 000000000000..19b2dc320503 --- /dev/null +++ b/releasenotes/notes/deprecate-fatal-exception-format-errors-a5d2bf64e3404c39.yaml @@ -0,0 +1,6 @@ +--- +deprecations: + - The ``fatal_exception_format_errors`` config option is now deprecated and + may be removed as early as the 15.0.0 release. It is an option which was + only relevant for Nova internal testing purposes to ensure that errors in + formatted exception messages got detected. \ No newline at end of file