openstack/nova
Code Issues Proposed changes

trivial: Remove unused 'cache_utils' APIs

Browse Source 
These are not used by anything outside of tests. Remove them.

Change-Id: Ie58a961ecc42025d88cb17b5cc0b543cacbe1b07
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
This commit is contained in:
Stephen Finucane 2020-02-04 12:13:31 +00:00
parent 097c31d4b4
commit 5cea9ed9ad
3 changed files with 3 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
nova/cache_utils.py
View File

@ -109,22 +109,8 @@ class CacheClient(object):
return None return None
return value return value
def get_or_create(self, key, creator):
return self.region.get_or_create(key, creator)
def set(self, key, value): def set(self, key, value):
return self.region.set(key, value) return self.region.set(key, value)
def add(self, key, value):
return self.region.get_or_create(key, lambda: value)
def delete(self, key): def delete(self, key):
return self.region.delete(key) return self.region.delete(key)
def get_multi(self, keys):
values = self.region.get_multi(keys)
return [None if value is cache.NO_VALUE else value for value in
values]
def delete_multi(self, keys):
return self.region.delete_multi(keys)

3
nova/tests/unit/compute/test_compute.py
View File

@ -11644,7 +11644,8 @@ class ComputeAPIAggrTestCase(BaseTestCase):
'foo_key2': 'foo_value2', 'foo_key2': 'foo_value2',
'availability_zone': 'fake_zone'} 'availability_zone': 'fake_zone'}
fake_notifier.NOTIFICATIONS = [] fake_notifier.NOTIFICATIONS = []
availability_zones._get_cache().add('fake_key', 'fake_value') availability_zones._get_cache().region.get_or_create(
'fake_ky', lambda: 'fake_value')
aggr = self.api.update_aggregate_metadata(self.context, aggr.id, aggr = self.api.update_aggregate_metadata(self.context, aggr.id,
metadata) metadata)
self.assertIsNone(availability_zones._get_cache().get('fake_key')) self.assertIsNone(availability_zones._get_cache().get('fake_key'))

2
nova/tests/unit/test_availability_zones.py
View File

@ -78,7 +78,7 @@ class AvailabilityZoneTestCases(test.TestCase):
aggregate.delete_host(service['host']) aggregate.delete_host(service['host'])
def test_rest_availability_zone_reset_cache(self): def test_rest_availability_zone_reset_cache(self):
az._get_cache().add('cache', 'fake_value') az._get_cache().region.get_or_create('cache', lambda: 'fake_value')
az.reset_cache() az.reset_cache()
self.assertIsNone(az._get_cache().get('cache')) self.assertIsNone(az._get_cache().get('cache'))