openstack/nova
Code Issues Proposed changes

[placement] Fix getting placement request ID

Browse Source 
In response headers, there is no 'openstack-request-id' header.
So it is not necessary to check the 'openstack-request-id' header.

And 'x-openstack-request-id' is defined in oslo.middleware.
So use the constant value in oslo.middleware.

Change-Id: Id14fb86ea9786bb22eb6b206cb10f115f9b56ea2
This commit is contained in:
Takashi NATSUME 2017-11-28 20:11:23 +09:00
parent 609ddc2244
commit 560ebe4a56
2 changed files with 12 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
nova/scheduler/client/report.py
View File

@ -20,6 +20,7 @@ import time
from keystoneauth1 import exceptions as ks_exc
from oslo_log import log as logging
from oslo_middleware import request_id
from six.moves.urllib import parse
from nova.compute import provider_tree
@ -249,9 +250,7 @@ def _extract_inventory_in_use(body):
def get_placement_request_id(response):
if response is not None:
return response.headers.get(
'openstack-request-id',
response.headers.get('x-openstack-request-id'))
return response.headers.get(request_id.HTTP_RESP_HEADER_REQUEST_ID)
class SchedulerReportClient(object):

20
nova/tests/unit/scheduler/client/test_report.py
View File

@ -1358,7 +1358,7 @@ class TestProviderOperations(SchedulerReportClientTestCase):
resp_mock = mock.Mock(status_code=503)
self.ks_adap_mock.get.return_value = resp_mock
self.ks_adap_mock.get.return_value.headers = {
'openstack-request-id': uuids.request_id}
'x-openstack-request-id': uuids.request_id}
uuid = uuids.compute_node
self.assertRaises(
@ -1556,7 +1556,7 @@ class TestProviderOperations(SchedulerReportClientTestCase):
name = 'computehost'
self.ks_adap_mock.post.return_value = mock.Mock(
status_code=409,
headers={'openstack-request-id': uuids.request_id},
headers={'x-openstack-request-id': uuids.request_id},
text='not a name conflict')
get_rp_mock.return_value = mock.sentinel.get_rp
@ -1897,7 +1897,7 @@ class TestInventory(SchedulerReportClientTestCase):
}
}
mock_delete.return_value.status_code = 204
mock_delete.return_value.headers = {'openstack-request-id':
mock_delete.return_value.headers = {'x-openstack-request-id':
uuids.request_id}
result = self.client._delete_inventory(cn.uuid)
self.assertIsNone(result)
@ -1954,7 +1954,7 @@ class TestInventory(SchedulerReportClientTestCase):
'inventories': {
}
}
mock_put.return_value.headers = {'openstack-request-id':
mock_put.return_value.headers = {'x-openstack-request-id':
uuids.request_id}
result = self.client._delete_inventory(cn.uuid)
self.assertIsNone(result)
@ -2026,7 +2026,7 @@ class TestInventory(SchedulerReportClientTestCase):
'inventories': {
}
}
mock_put.return_value.headers = {'openstack-request-id':
mock_put.return_value.headers = {'x-openstack-request-id':
uuids.request_id}
self.client._delete_inventory(cn.uuid)
self.assertTrue(mock_debug.called)
@ -2060,7 +2060,7 @@ class TestInventory(SchedulerReportClientTestCase):
}
}
mock_delete.return_value.status_code = 409
mock_delete.return_value.headers = {'openstack-request-id':
mock_delete.return_value.headers = {'x-openstack-request-id':
uuids.request_id}
rc_str = "VCPU, MEMORY_MB"
in_use_exc = exception.InventoryInUse(
@ -2112,7 +2112,7 @@ There was a conflict when trying to complete your request.
}
}
mock_delete.return_value.status_code = 404
mock_delete.return_value.headers = {'openstack-request-id':
mock_delete.return_value.headers = {'x-openstack-request-id':
uuids.request_id}
result = self.client._delete_inventory(cn.uuid)
self.assertIsNone(result)
@ -2151,7 +2151,7 @@ There was a conflict when trying to complete your request.
'inventories': {
}
}
mock_delete.return_value.headers = {'openstack-request-id':
mock_delete.return_value.headers = {'x-openstack-request-id':
uuids.request_id}
result = self.client._delete_inventory(cn.uuid)
self.assertIsNone(result)
@ -2467,7 +2467,7 @@ There was a conflict when trying to complete your request.
'inventories': {},
}
mock_put.return_value.status_code = 234
mock_put.return_value.headers = {'openstack-request-id':
mock_put.return_value.headers = {'x-openstack-request-id':
uuids.request_id}
inv_data = report._compute_node_to_inventory_dict(compute_node)
@ -2507,7 +2507,7 @@ There was a conflict when trying to complete your request.
except AttributeError:
# Thanks py3
mock_put.return_value.__bool__.return_value = False
mock_put.return_value.headers = {'openstack-request-id':
mock_put.return_value.headers = {'x-openstack-request-id':
uuids.request_id}
inv_data = report._compute_node_to_inventory_dict(compute_node)