openstack/nova
Code Issues Proposed changes

Remove duplicate unit test resource tracker

Browse Source 
Removes the test class that tested the "periodic update resource"
functionality in test_resource_tracker.py. This wasn't testing any code
paths that were not already being tested by test_tracker.py's
TestUpdateComputeNode and TestUpdateAvailableResource test case classes.

Change-Id: Ie7c565ebb39c4644a304f53a73853d6ca51b1334
This commit is contained in:
Jay Pipes 2016-06-10 12:26:29 -04:00 committed by Sean Dague
parent 41616f9d55
commit 4f342946a7
1 changed files with 0 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
nova/tests/unit/compute/test_resource_tracker.py
View File

@ -693,37 +693,6 @@ class ComputeMonitorTestCase(BaseTestCase):
self.assertEqual(metrics, expected_metrics)
class TrackerPeriodicTestCase(BaseTrackerTestCase):
def test_periodic_status_update(self):
# verify update called on instantiation
self.assertEqual(1, self.update_call_count)
# verify update not called if no change to resources
self.tracker.update_available_resource(self.context)
self.assertEqual(1, self.update_call_count)
# verify update is called when resources change
driver = self.tracker.driver
driver.memory_mb += 1
self.tracker.update_available_resource(self.context)
self.assertEqual(2, self.update_call_count)
def test_update_available_resource_calls_locked_inner(self):
@mock.patch.object(self.tracker, 'driver')
@mock.patch.object(self.tracker,
'_update_available_resource')
@mock.patch.object(self.tracker, '_verify_resources')
@mock.patch.object(self.tracker, '_report_hypervisor_resource_view')
def _test(mock_rhrv, mock_vr, mock_uar, mock_driver):
resources = self._create_compute_node()
mock_driver.get_available_resource.return_value = resources
self.tracker.update_available_resource(self.context)
mock_uar.assert_called_once_with(self.context, resources)
_test()
class UpdateUsageFromMigrationsTestCase(BaseTrackerTestCase):
@mock.patch.object(resource_tracker.ResourceTracker,