openstack/nova
Code Issues Proposed changes

Remove the useless require_admin_context decorator

Browse Source 
There isn't any db call need hard-code permission checks anymore.
For the hard-code permission checks decorator require_admin_context.

Partially implements bp nova-api-policy-final-part

Change-Id: Ie5ff44b8b86298cfc1d1f24430279a7b266f49bd
This commit is contained in:
He Jie Xu 2015-07-10 13:46:32 +08:00 committed by John Garbutt
parent ac39fa1569
commit 3e6c9fa9d6
2 changed files with 0 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
nova/db/sqlalchemy/api.py
View File

@ -199,20 +199,6 @@ def get_backend():
return sys.modules[__name__]
def require_admin_context(f):
"""Decorator to require admin request context.
The first argument to the wrapped function must be the context.
"""
@functools.wraps(f)
def wrapper(*args, **kwargs):
nova.context.require_admin_context(args[0])
return f(*args, **kwargs)
return wrapper
def require_context(f):
"""Decorator to require *any* user or admin context.

3
nova/tests/unit/db/test_db_api.py
View File

@ -176,9 +176,6 @@ class DecoratorTestCase(test.TestCase):
def test_require_context_decorator_wraps_functions_properly(self):
self._test_decorator_wraps_helper(sqlalchemy_api.require_context)
def test_require_admin_context_decorator_wraps_functions_properly(self):
self._test_decorator_wraps_helper(sqlalchemy_api.require_admin_context)
def test_require_deadlock_retry_wraps_functions_properly(self):
self._test_decorator_wraps_helper(
oslo_db_api.wrap_db_retry(max_retries=5, retry_on_deadlock=True))