From 26db00344f0322cc335e7ef459791e564f7182f7 Mon Sep 17 00:00:00 2001 From: Chris Dent Date: Tue, 17 Jan 2017 21:10:45 +0000 Subject: [PATCH] Remove invalid URL in gabbi tests The use of a literal snowman in a URL is an invalid URL. In Python 3 the url parsing code used by gabbi will not accept this URL and correctly rejects it. Python 2 is less strict and passes it on (presumably encoding it somewhere in the stack). Python 3's behavior is correct and the fact that the test ever worked was an artifact of Python 2's bad behavior. The test immediately following the removed test is testing the correct and legitimate HTTP behavior, so it is best to just remove the bad one. By doing so all functional tests pass under python3 so the test-functional-py3.txt has been made empty, with a comment. This was done, instead of removing it, to signal the state of affairs. Change-Id: If40f5093c65491dcfc225dffd95c6dc1318a0f99 --- .../functional/api/openstack/placement/gabbits/unicode.yaml | 5 ----- tests-functional-py3.txt | 5 +---- 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/nova/tests/functional/api/openstack/placement/gabbits/unicode.yaml b/nova/tests/functional/api/openstack/placement/gabbits/unicode.yaml index 367f79a4dd65..1851694e12dc 100644 --- a/nova/tests/functional/api/openstack/placement/gabbits/unicode.yaml +++ b/nova/tests/functional/api/openstack/placement/gabbits/unicode.yaml @@ -9,11 +9,6 @@ defaults: tests: -- name: get a raw snowman unicode - desc: this should fall through to a NotFound on the resource provider object - GET: /resource_providers/☃ - status: 404 - - name: get an encoded snowman desc: this should fall through to a NotFound on the resource provider object GET: /resources_providers/%e2%98%83 diff --git a/tests-functional-py3.txt b/tests-functional-py3.txt index f7854cd90768..1a22c8d56fb9 100644 --- a/tests-functional-py3.txt +++ b/tests-functional-py3.txt @@ -1,4 +1 @@ -############################################################################## -# NOTE(dims): The following test looks like a gabbi failure under python 3.5 -############################################################################## -nova.tests.functional.api.openstack.placement.test_placement_api.unicode_get_a_raw_snowman_unicode.test_request +# All functional tests currently work with python 3.5.