Merge "Hyper-V: Adds HyperVDriver unit tests"

nova/tests/unit/virt/hyperv/test_driver.py

@@ -0,0 +1,374 @@
+# Copyright 2015 Cloudbase Solutions SRL
+# All Rights Reserved.
+#
+#    Licensed under the Apache License, Version 2.0 (the "License"); you may
+#    not use this file except in compliance with the License. You may obtain
+#    a copy of the License at
+#
+#         http://www.apache.org/licenses/LICENSE-2.0
+#
+#    Unless required by applicable law or agreed to in writing, software
+#    distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+#    License for the specific language governing permissions and limitations
+#    under the License.
+
+"""
+Unit tests for the Hyper-V Driver.
+"""
+
+import platform
+
+import mock
+
+from nova.tests.unit import fake_instance
+from nova.tests.unit.virt.hyperv import test_base
+from nova.virt import driver as base_driver
+from nova.virt.hyperv import driver
+
+
+class HyperVDriverTestCase(test_base.HyperVBaseTestCase):
+
+    def setUp(self):
+        super(HyperVDriverTestCase, self).setUp()
+
+        self.context = 'context'
+        self.driver = driver.HyperVDriver(mock.sentinel.virtapi)
+        self.driver._hostops = mock.MagicMock()
+        self.driver._volumeops = mock.MagicMock()
+        self.driver._vmops = mock.MagicMock()
+        self.driver._snapshotops = mock.MagicMock()
+        self.driver._livemigrationops = mock.MagicMock()
+        self.driver._migrationops = mock.MagicMock()
+        self.driver._rdpconsoleops = mock.MagicMock()
+
+    def test_public_api_signatures(self):
+        self.assertPublicAPISignatures(base_driver.ComputeDriver(None),
+                                       self.driver)
+
+    @mock.patch.object(driver.eventhandler, 'InstanceEventHandler')
+    def test_init_host(self, mock_InstanceEventHandler):
+        self.driver.init_host(mock.sentinel.host)
+
+        self.driver._vmops.restart_vm_log_writers.assert_called_once_with()
+        mock_InstanceEventHandler.assert_called_once_with(
+            state_change_callback=self.driver.emit_event,
+            running_state_callback=self.driver._vmops.log_vm_serial_output)
+        fake_event_handler = mock_InstanceEventHandler.return_value
+        fake_event_handler.start_listener.assert_called_once_with()
+
+    def test_list_instance_uuids(self):
+        self.driver.list_instance_uuids()
+        self.driver._vmops.list_instance_uuids.assert_called_once_with()
+
+    def test_list_instances(self):
+        self.driver.list_instances()
+        self.driver._vmops.list_instances.assert_called_once_with()
+
+    @mock.patch.object(driver.objects.ImageMeta, 'from_dict')
+    def test_spawn(self, mock_meta_from_dict):
+        self.driver.spawn(
+            mock.sentinel.context, mock.sentinel.instance,
+            mock.sentinel.image_meta, mock.sentinel.injected_files,
+            mock.sentinel.admin_password, mock.sentinel.network_info,
+            mock.sentinel.block_device_info)
+
+        self.driver._vmops.spawn.assert_called_once_with(
+            mock.sentinel.context, mock.sentinel.instance,
+            mock_meta_from_dict.return_value, mock.sentinel.injected_files,
+            mock.sentinel.admin_password, mock.sentinel.network_info,
+            mock.sentinel.block_device_info)
+
+    def test_reboot(self):
+        self.driver.reboot(
+            mock.sentinel.context, mock.sentinel.instance,
+            mock.sentinel.network_info, mock.sentinel.reboot_type,
+            mock.sentinel.block_device_info, mock.sentinel.bad_vol_callback)
+
+        self.driver._vmops.reboot.assert_called_once_with(
+            mock.sentinel.instance, mock.sentinel.network_info,
+            mock.sentinel.reboot_type)
+
+    def test_destroy(self):
+        self.driver.destroy(
+            mock.sentinel.context, mock.sentinel.instance,
+            mock.sentinel.network_info, mock.sentinel.block_device_info,
+            mock.sentinel.destroy_disks, mock.sentinel.migrate_data)
+
+        self.driver._vmops.destroy.assert_called_once_with(
+            mock.sentinel.instance, mock.sentinel.network_info,
+            mock.sentinel.block_device_info, mock.sentinel.destroy_disks)
+
+    def test_get_info(self):
+        self.driver.get_info(mock.sentinel.instance)
+        self.driver._vmops.get_info.assert_called_once_with(
+            mock.sentinel.instance)
+
+    def test_attach_volume(self):
+        mock_instance = fake_instance.fake_instance_obj(self.context)
+        self.driver.attach_volume(
+            mock.sentinel.context, mock.sentinel.connection_info,
+            mock_instance, mock.sentinel.mountpoint, mock.sentinel.disk_bus,
+            mock.sentinel.device_type, mock.sentinel.encryption)
+
+        self.driver._volumeops.attach_volume.assert_called_once_with(
+            mock.sentinel.connection_info,
+            mock_instance.name)
+
+    def test_detach_volume(self):
+        mock_instance = fake_instance.fake_instance_obj(self.context)
+        self.driver.detach_volume(
+            mock.sentinel.connection_info, mock_instance,
+            mock.sentinel.mountpoint, mock.sentinel.encryption)
+
+        self.driver._volumeops.detach_volume.assert_called_once_with(
+            mock.sentinel.connection_info,
+            mock_instance.name)
+
+    def test_get_volume_connector(self):
+        self.driver.get_volume_connector(mock.sentinel.instance)
+        self.driver._volumeops.get_volume_connector.assert_called_once_with(
+            mock.sentinel.instance)
+
+    def test_get_available_resource(self):
+        self.driver.get_available_resource(mock.sentinel.nodename)
+        self.driver._hostops.get_available_resource.assert_called_once_with()
+
+    def test_get_available_nodes(self):
+        response = self.driver.get_available_nodes(mock.sentinel.refresh)
+        self.assertEqual([platform.node()], response)
+
+    def test_host_power_action(self):
+        self.driver.host_power_action(mock.sentinel.action)
+        self.driver._hostops.host_power_action.assert_called_once_with(
+            mock.sentinel.action)
+
+    def test_snapshot(self):
+        self.driver.snapshot(
+            mock.sentinel.context, mock.sentinel.instance,
+            mock.sentinel.image_id, mock.sentinel.update_task_state)
+
+        self.driver._snapshotops.snapshot.assert_called_once_with(
+            mock.sentinel.context, mock.sentinel.instance,
+            mock.sentinel.image_id, mock.sentinel.update_task_state)
+
+    def test_pause(self):
+        self.driver.pause(mock.sentinel.instance)
+        self.driver._vmops.pause.assert_called_once_with(
+            mock.sentinel.instance)
+
+    def test_unpause(self):
+        self.driver.unpause(mock.sentinel.instance)
+        self.driver._vmops.unpause.assert_called_once_with(
+            mock.sentinel.instance)
+
+    def test_suspend(self):
+        self.driver.suspend(mock.sentinel.context, mock.sentinel.instance)
+        self.driver._vmops.suspend.assert_called_once_with(
+            mock.sentinel.instance)
+
+    def test_resume(self):
+        self.driver.resume(
+            mock.sentinel.context, mock.sentinel.instance,
+            mock.sentinel.network_info, mock.sentinel.block_device_info)
+
+        self.driver._vmops.resume.assert_called_once_with(
+            mock.sentinel.instance)
+
+    def test_power_off(self):
+        self.driver.power_off(
+            mock.sentinel.instance, mock.sentinel.timeout,
+            mock.sentinel.retry_interval)
+
+        self.driver._vmops.power_off.assert_called_once_with(
+            mock.sentinel.instance, mock.sentinel.timeout,
+            mock.sentinel.retry_interval)
+
+    def test_power_on(self):
+        self.driver.power_on(
+            mock.sentinel.context, mock.sentinel.instance,
+            mock.sentinel.network_info, mock.sentinel.block_device_info)
+
+        self.driver._vmops.power_on.assert_called_once_with(
+            mock.sentinel.instance, mock.sentinel.block_device_info)
+
+    def test_resume_state_on_host_boot(self):
+        self.driver.resume_state_on_host_boot(
+            mock.sentinel.context, mock.sentinel.instance,
+            mock.sentinel.network_info, mock.sentinel.block_device_info)
+
+        self.driver._vmops.resume_state_on_host_boot.assert_called_once_with(
+            mock.sentinel.context, mock.sentinel.instance,
+            mock.sentinel.network_info, mock.sentinel.block_device_info)
+
+    def test_live_migration(self):
+        self.driver.live_migration(
+            mock.sentinel.context, mock.sentinel.instance,
+            mock.sentinel.dest, mock.sentinel.post_method,
+            mock.sentinel.recover_method, mock.sentinel.block_migration,
+            mock.sentinel.migrate_data)
+
+        self.driver._livemigrationops.live_migration.assert_called_once_with(
+            mock.sentinel.context, mock.sentinel.instance,
+            mock.sentinel.dest, mock.sentinel.post_method,
+            mock.sentinel.recover_method, mock.sentinel.block_migration,
+            mock.sentinel.migrate_data)
+
+    @mock.patch.object(driver.HyperVDriver, 'destroy')
+    def test_rollback_live_migration_at_destination(self, mock_destroy):
+        self.driver.rollback_live_migration_at_destination(
+            mock.sentinel.context, mock.sentinel.instance,
+            mock.sentinel.network_info, mock.sentinel.block_device_info,
+            mock.sentinel.destroy_disks, mock.sentinel.migrate_data)
+
+        mock_destroy.assert_called_once_with(
+            mock.sentinel.context, mock.sentinel.instance,
+            mock.sentinel.network_info, mock.sentinel.block_device_info)
+
+    def test_pre_live_migration(self):
+        self.driver.pre_live_migration(
+            mock.sentinel.context, mock.sentinel.instance,
+            mock.sentinel.block_device_info, mock.sentinel.network_info,
+            mock.sentinel.disk_info, mock.sentinel.migrate_data)
+
+        pre_live_migration = self.driver._livemigrationops.pre_live_migration
+        pre_live_migration.assert_called_once_with(
+            mock.sentinel.context, mock.sentinel.instance,
+            mock.sentinel.block_device_info, mock.sentinel.network_info)
+
+    def test_post_live_migration(self):
+        self.driver.post_live_migration(
+            mock.sentinel.context, mock.sentinel.instance,
+            mock.sentinel.block_device_info, mock.sentinel.migrate_data)
+
+        post_live_migration = self.driver._livemigrationops.post_live_migration
+        post_live_migration.assert_called_once_with(
+            mock.sentinel.context, mock.sentinel.instance,
+            mock.sentinel.block_device_info)
+
+    def test_post_live_migration_at_destination(self):
+        self.driver.post_live_migration_at_destination(
+            mock.sentinel.context, mock.sentinel.instance,
+            mock.sentinel.network_info, mock.sentinel.block_migration,
+            mock.sentinel.block_device_info)
+
+        mtd = self.driver._livemigrationops.post_live_migration_at_destination
+        mtd.assert_called_once_with(
+            mock.sentinel.context, mock.sentinel.instance,
+            mock.sentinel.network_info, mock.sentinel.block_migration)
+
+    def test_check_can_live_migrate_destination(self):
+        self.driver.check_can_live_migrate_destination(
+            mock.sentinel.context, mock.sentinel.instance,
+            mock.sentinel.src_compute_info, mock.sentinel.dst_compute_info,
+            mock.sentinel.block_migration, mock.sentinel.disk_over_commit)
+
+        mtd = self.driver._livemigrationops.check_can_live_migrate_destination
+        mtd.assert_called_once_with(
+            mock.sentinel.context, mock.sentinel.instance,
+            mock.sentinel.src_compute_info, mock.sentinel.dst_compute_info,
+            mock.sentinel.block_migration, mock.sentinel.disk_over_commit)
+
+    def test_check_can_live_migrate_destination_cleanup(self):
+        self.driver.check_can_live_migrate_destination_cleanup(
+            mock.sentinel.context, mock.sentinel.dest_check_data)
+
+        _livemigrops = self.driver._livemigrationops
+        method = _livemigrops.check_can_live_migrate_destination_cleanup
+        method.assert_called_once_with(
+            mock.sentinel.context, mock.sentinel.dest_check_data)
+
+    def test_check_can_live_migrate_source(self):
+        self.driver.check_can_live_migrate_source(
+            mock.sentinel.context, mock.sentinel.instance,
+            mock.sentinel.dest_check_data, mock.sentinel.block_device_info)
+
+        method = self.driver._livemigrationops.check_can_live_migrate_source
+        method.assert_called_once_with(
+            mock.sentinel.context, mock.sentinel.instance,
+            mock.sentinel.dest_check_data)
+
+    def test_plug_vifs(self):
+        self.assertRaises(NotImplementedError, self.driver.plug_vifs,
+                          mock.sentinel.instance, mock.sentinel.network_info)
+
+    def test_unplug_vifs(self):
+        self.assertRaises(NotImplementedError, self.driver.unplug_vifs,
+                          mock.sentinel.instance, mock.sentinel.network_info)
+
+    def test_refresh_instance_security_rules(self):
+        self.assertRaises(NotImplementedError,
+                          self.driver.refresh_instance_security_rules,
+                          instance=mock.sentinel.instance)
+
+    def test_migrate_disk_and_power_off(self):
+        self.driver.migrate_disk_and_power_off(
+            mock.sentinel.context, mock.sentinel.instance, mock.sentinel.dest,
+            mock.sentinel.flavor, mock.sentinel.network_info,
+            mock.sentinel.block_device_info, mock.sentinel.timeout,
+            mock.sentinel.retry_interval)
+
+        migr_power_off = self.driver._migrationops.migrate_disk_and_power_off
+        migr_power_off.assert_called_once_with(
+            mock.sentinel.context, mock.sentinel.instance, mock.sentinel.dest,
+            mock.sentinel.flavor, mock.sentinel.network_info,
+            mock.sentinel.block_device_info, mock.sentinel.timeout,
+            mock.sentinel.retry_interval)
+
+    def test_confirm_migration(self):
+        self.driver.confirm_migration(
+            mock.sentinel.migration, mock.sentinel.instance,
+            mock.sentinel.network_info)
+
+        self.driver._migrationops.confirm_migration.assert_called_once_with(
+            mock.sentinel.migration, mock.sentinel.instance,
+            mock.sentinel.network_info)
+
+    def test_finish_revert_migration(self):
+        self.driver.finish_revert_migration(
+            mock.sentinel.context, mock.sentinel.instance,
+            mock.sentinel.network_info, mock.sentinel.block_device_info,
+            mock.sentinel.power_on)
+
+        finish_revert_migr = self.driver._migrationops.finish_revert_migration
+        finish_revert_migr.assert_called_once_with(
+            mock.sentinel.context, mock.sentinel.instance,
+            mock.sentinel.network_info, mock.sentinel.block_device_info,
+            mock.sentinel.power_on)
+
+    @mock.patch.object(driver.objects.ImageMeta, 'from_dict')
+    def test_finish_migration(self, mock_meta_from_dict):
+        self.driver.finish_migration(
+            mock.sentinel.context, mock.sentinel.migration,
+            mock.sentinel.instance, mock.sentinel.disk_info,
+            mock.sentinel.network_info, mock.sentinel.image_meta,
+            mock.sentinel.resize_instance, mock.sentinel.block_device_info,
+            mock.sentinel.power_on)
+
+        self.driver._migrationops.finish_migration.assert_called_once_with(
+            mock.sentinel.context, mock.sentinel.migration,
+            mock.sentinel.instance, mock.sentinel.disk_info,
+            mock.sentinel.network_info, mock_meta_from_dict.return_value,
+            mock.sentinel.resize_instance, mock.sentinel.block_device_info,
+            mock.sentinel.power_on)
+
+    def test_get_host_ip_addr(self):
+        self.driver.get_host_ip_addr()
+
+        self.driver._hostops.get_host_ip_addr.assert_called_once_with()
+
+    def test_get_host_uptime(self):
+        self.driver.get_host_uptime()
+        self.driver._hostops.get_host_uptime.assert_called_once_with()
+
+    def test_get_rdp_console(self):
+        self.driver.get_rdp_console(
+            mock.sentinel.context, mock.sentinel.instance)
+        self.driver._rdpconsoleops.get_rdp_console.assert_called_once_with(
+            mock.sentinel.instance)
+
+    def test_get_console_output(self):
+        self.driver.get_console_output(
+            mock.sentinel.context, mock.sentinel.instance)
+        self.driver._vmops.get_console_output.assert_called_once_with(
+            mock.sentinel.instance)

nova/tests/unit/virt/hyperv/test_hypervapi.py

@@ -19,7 +19,6 @@ Test suite for the Hyper-V driver and related APIs.
 import time
 import uuid
 
-import mock
 from mox3 import mox
 from oslo_config import cfg
 from oslo_utils import fileutils
@@ -36,7 +35,6 @@ from nova.tests.unit.virt.hyperv import db_fakes
 from nova.tests.unit.virt.hyperv import fake
 from nova import utils
 from nova.virt import configdrive
-from nova.virt import driver
 from nova.virt.hyperv import driver as driver_hyperv
 from nova.virt.hyperv import hostutils
 from nova.virt.hyperv import ioutils
@@ -151,9 +149,6 @@ class HyperVAPIBaseTestCase(test.NoDBTestCase):
 class HyperVAPITestCase(HyperVAPIBaseTestCase):
     """Unit tests for Hyper-V driver calls."""
 
-    def test_public_api_signatures(self):
-        self.assertPublicAPISignatures(driver.ComputeDriver(None), self._conn)
-
     def _get_instance_data(self):
         instance_name = 'openstack_unit_test_vm_' + str(uuid.uuid4())
         return db_fakes.get_fake_instance_data(instance_name,
@@ -168,25 +163,6 @@ class HyperVAPITestCase(HyperVAPIBaseTestCase):
             fake_instance.fake_db_instance(**updates),
             expected_attrs=expected_attrs)
 
-    def test_plug_vifs(self):
-        # Check to make sure the method raises NotImplementedError.
-        self.assertRaises(NotImplementedError,
-                          self._conn.plug_vifs,
-                          instance=mock.sentinel.instance,
-                          network_info=None)
-
-    def test_unplug_vifs(self):
-        # Check to make sure the method raises NotImplementedError.
-        self.assertRaises(NotImplementedError,
-                          self._conn.unplug_vifs,
-                          instance=mock.sentinel.instance,
-                          network_info=None)
-
-    def test_refresh_instance_security_rules(self):
-        self.assertRaises(NotImplementedError,
-                          self._conn.refresh_instance_security_rules,
-                          instance=None)
-
     def test_get_rdp_console(self):
         self.flags(my_ip="192.168.1.1")