openstack/neutron-tempest-plugin
Code Issues Proposed changes

Add tempest API tests for address groups RBAC

Browse Source 
Add tempest API tests for address groups RBAC

Change-Id: I2e3f6502f658e96594422abf82d44d8132da993b
Depends-On: https://review.opendev.org/c/openstack/neutron/+/772460
This commit is contained in:
Miguel Lavalle 2021-01-31 19:05:22 -06:00
parent 935a50ed86
commit b1c7a3d731
3 changed files with 202 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
neutron_tempest_plugin/api/base.py
View File

@ -125,6 +125,8 @@ class BaseNetworkTest(test.BaseTestCase):
cls.qos_rules = []
cls.qos_policies = []
cls.ethertype = "IPv" + str(cls._ip_version)
cls.address_groups = []
cls.admin_address_groups = []
cls.address_scopes = []
cls.admin_address_scopes = []
cls.subnetpools = []
@ -820,6 +822,16 @@ class BaseNetworkTest(test.BaseTestCase):
cls.subnetpools.append(body['subnetpool'])
return body['subnetpool']
@classmethod
def create_address_group(cls, name, is_admin=False, **kwargs):
if is_admin:
body = cls.admin_client.create_address_group(name=name, **kwargs)
cls.admin_address_groups.append(body['address_group'])
else:
body = cls.client.create_address_group(name=name, **kwargs)
cls.address_groups.append(body['address_group'])
return body['address_group']
@classmethod
def create_project(cls, name=None, description=None):
test_project = name or data_utils.rand_name('test_project_')
@ -886,6 +898,9 @@ class BaseNetworkTest(test.BaseTestCase):
ip_version = ip_version or cls._ip_version
default_params = (
constants.DEFAULT_SECURITY_GROUP_RULE_PARAMS[ip_version])
if ('remote_address_group_id' in kwargs and 'remote_ip_prefix' in
default_params):
default_params.pop('remote_ip_prefix')
for key, value in default_params.items():
kwargs.setdefault(key, value)

185
neutron_tempest_plugin/api/test_address_groups.py Normal file
View File

@ -0,0 +1,185 @@
# Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain
# a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
import random
from neutron_lib import constants
from oslo_log import log
from tempest.lib.common.utils import data_utils
from tempest.lib import decorators
from tempest.lib import exceptions
import testtools
from neutron_tempest_plugin.api import base
from neutron_tempest_plugin.api import base_security_groups
LOG = log.getLogger(__name__)
ADDRESS_GROUP_NAME = 'test-address-group'
class RbacSharedAddressGroupTest(base.BaseAdminNetworkTest):
force_tenant_isolation = True
credentials = ['primary', 'alt', 'admin']
required_extensions = ['security-group', 'address-group',
'rbac-address-group']
@classmethod
def resource_setup(cls):
super(RbacSharedAddressGroupTest, cls).resource_setup()
cls.client2 = cls.os_alt.network_client
def _create_address_group(self, is_admin=False, **kwargs):
name = data_utils.rand_name(ADDRESS_GROUP_NAME)
return self.create_address_group(name=name, is_admin=is_admin,
**kwargs)
def _make_admin_ag_shared_to_project_id(self, project_id):
ag = self._create_address_group(is_admin=True)
rbac_policy = self.admin_client.create_rbac_policy(
object_type='address_group',
object_id=ag['id'],
action='access_as_shared',
target_tenant=project_id,
)['rbac_policy']
return {'address_group': ag, 'rbac_policy': rbac_policy}
@decorators.idempotent_id('95f59a88-c47e-4dd9-a231-85f1782753a7')
def test_policy_target_update(self):
res = self._make_admin_ag_shared_to_project_id(
self.client.tenant_id)
# change to client2
update_res = self.admin_client.update_rbac_policy(
res['rbac_policy']['id'], target_tenant=self.client2.tenant_id)
self.assertEqual(self.client2.tenant_id,
update_res['rbac_policy']['target_tenant'])
# make sure everything else stayed the same
res['rbac_policy'].pop('target_tenant')
update_res['rbac_policy'].pop('target_tenant')
self.assertEqual(res['rbac_policy'], update_res['rbac_policy'])
@decorators.idempotent_id('35a214c9-5c99-468f-9242-34d0529cabfa')
def test_secgrprule_presence_prevents_policy_rbac_policy_deletion(self):
res = self._make_admin_ag_shared_to_project_id(
self.client2.tenant_id)
ag_id = res['address_group']['id']
security_group = self.create_security_group(client=self.client2)
protocol = random.choice(list(base_security_groups.V4_PROTOCOL_NAMES))
sec_grp_rule = self.create_security_group_rule(
security_group=security_group,
client=self.client2, protocol=protocol,
direction=constants.INGRESS_DIRECTION,
remote_address_group_id=ag_id)
# a port with shared sg should prevent the deletion of an
# rbac-policy required for it to be shared
with testtools.ExpectedException(exceptions.Conflict):
self.admin_client.delete_rbac_policy(res['rbac_policy']['id'])
# cleanup
self.client2.delete_security_group_rule(sec_grp_rule['id'])
self.admin_client.delete_rbac_policy(res['rbac_policy']['id'])
@decorators.idempotent_id('c89db8d4-0b52-4072-ac7e-672860491843')
def test_regular_client_shares_to_another_regular_client(self):
# owned by self.admin_client
ag = self._create_address_group(is_admin=True)
with testtools.ExpectedException(exceptions.NotFound):
self.client.show_address_group(ag['id'])
rbac_policy = self.admin_client.create_rbac_policy(
object_type='address_group', object_id=ag['id'],
action='access_as_shared',
target_tenant=self.client.tenant_id)['rbac_policy']
self.client.show_address_group(ag['id'])
self.assertIn(rbac_policy,
self.admin_client.list_rbac_policies()['rbac_policies'])
# ensure that 'client2' can't see the rbac-policy sharing the
# ag to it because the rbac-policy belongs to 'client'
self.assertNotIn(rbac_policy['id'], [p['id'] for p in
self.client2.list_rbac_policies()['rbac_policies']])
@decorators.idempotent_id('55a9fbb6-3333-48e8-90e4-11ab2a49567b')
def test_filter_fields(self):
ag = self._create_address_group()
self.admin_client.create_rbac_policy(
object_type='address_group', object_id=ag['id'],
action='access_as_shared', target_tenant=self.client2.tenant_id)
field_args = (('id',), ('id', 'action'), ('object_type', 'object_id'),
('project_id', 'target_tenant'))
for fields in field_args:
res = self.admin_client.list_rbac_policies(fields=fields)
self.assertEqual(set(fields), set(res['rbac_policies'][0].keys()))
@decorators.idempotent_id('20b2706b-1cea-4724-ab72-d7452ecb1fc4')
def test_rbac_policy_show(self):
res = self._make_admin_ag_shared_to_project_id(
self.client.tenant_id)
p1 = res['rbac_policy']
p2 = self.admin_client.create_rbac_policy(
object_type='address_group',
object_id=res['address_group']['id'],
action='access_as_shared',
target_tenant='*')['rbac_policy']
self.assertEqual(
p1, self.admin_client.show_rbac_policy(p1['id'])['rbac_policy'])
self.assertEqual(
p2, self.admin_client.show_rbac_policy(p2['id'])['rbac_policy'])
@decorators.idempotent_id('774fc038-486c-4507-ab04-c5aac0fca5ab')
def test_filter_rbac_policies(self):
ag = self._create_address_group()
rbac_pol1 = self.admin_client.create_rbac_policy(
object_type='address_group', object_id=ag['id'],
action='access_as_shared',
target_tenant=self.client2.tenant_id)['rbac_policy']
rbac_pol2 = self.admin_client.create_rbac_policy(
object_type='address_group', object_id=ag['id'],
action='access_as_shared',
target_tenant=self.admin_client.tenant_id)['rbac_policy']
res1 = self.admin_client.list_rbac_policies(id=rbac_pol1['id'])[
'rbac_policies']
res2 = self.admin_client.list_rbac_policies(id=rbac_pol2['id'])[
'rbac_policies']
self.assertEqual(1, len(res1))
self.assertEqual(1, len(res2))
self.assertEqual(rbac_pol1['id'], res1[0]['id'])
self.assertEqual(rbac_pol2['id'], res2[0]['id'])
@decorators.idempotent_id('a0f3a01a-e2c7-47d6-9385-0cd7a7f0c996')
def test_regular_client_blocked_from_sharing_anothers_policy(self):
ag = self._make_admin_ag_shared_to_project_id(
self.client.tenant_id)['address_group']
with testtools.ExpectedException(exceptions.BadRequest):
self.client.create_rbac_policy(
object_type='address_group', object_id=ag['id'],
action='access_as_shared',
target_tenant=self.client2.tenant_id)
# make sure the rbac-policy is invisible to the tenant for which it's
# being shared
self.assertFalse(self.client.list_rbac_policies()['rbac_policies'])
@decorators.idempotent_id('f39e32d9-4733-48ec-b550-07f0ec4998a9')
def test_regular_client_blocked_from_updating_shared_address_group(self):
# owned by self.admin_client
ag = self._create_address_group(is_admin=True)
self.admin_client.create_rbac_policy(
object_type='address_group', object_id=ag['id'],
action='access_as_shared',
target_tenant=self.client.tenant_id)['rbac_policy']
self.client.show_address_group(ag['id'])
with testtools.ExpectedException(exceptions.NotFound):
self.client.update_address_group(ag['id'], name='new_name')

2
zuul.d/master_jobs.yaml
View File

@ -6,6 +6,7 @@
# neutron repository and keep it different per branch,
# then it could be removed from here
network_api_extensions_common: &api_extensions
- address-group
- address-scope
- agent
- allowed-address-pairs
@ -54,6 +55,7 @@
- qos-fip
- quotas
- quota_details
- rbac-address-group
- rbac-address-scope
- rbac-policies
- rbac-security-groups