openstack/kayobe
Code Issues Proposed changes

Add loop control to custom DNF repos

Browse Source 
This avoids leaking repository credentials by suppressing the dict
output to only print the key.

Change-Id: Ic7aa0e4c4f625908aeb30de65edac8bce96af761
Related-Bug: #2087938
This commit is contained in:
Jake Hutchinson 2024-10-30 16:34:29 +00:00 committed by Pierre Riteau
parent de90df424c
commit a36bb614c0
2 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ansible/roles/dnf/tasks/custom-repo.yml
View File

@ -26,6 +26,8 @@
username: "{{ item.value.username | default(omit) }}" username: "{{ item.value.username | default(omit) }}"
state: "{{ item.value.state | default(omit)}}" state: "{{ item.value.state | default(omit)}}"
with_dict: "{{ dnf_custom_repos }}" with_dict: "{{ dnf_custom_repos }}"
loop_control:
label: "{{ item.key }}"
register: register_dnf_command register: register_dnf_command
retries: 3 retries: 3
delay: 10 delay: 10

11
releasenotes/notes/dnf-loop-control-6e2c8ba1915d2631.yaml Normal file
View File

@ -0,0 +1,11 @@
---
security:
- |
Avoid leaking DNF repository username/password credentials in the Kayobe
output by adding loop control to print only the repository key.
`LP#2087938 <https://launchpad.net/bugs/2087938>`__
fixes:
- |
Avoid leaking DNF repository username/password credentials in the Kayobe
output by adding loop control to print only the repository key.
`LP#2087938 <https://launchpad.net/bugs/2087938>`__