f545272f12
Recent pep8 upgrade and corresponding pycodestyle update break horizon pep8 job due to the new rules. This commit fixes the following new errors: - E226 missing whitespace around arithmetic operator - E241 multiple spaces after ',' - E731 do not assign a lambda expression, use a def The following errors are added to the ignore list as there are many errors: - E402 module level import not at top of file - W503 line break before binary operator Change-Id: I3478b0684175d2604bbcc1d89cbfca298b97f1e1
471 lines
21 KiB
Python
471 lines
21 KiB
Python
# Copyright 2012 Nebula, Inc.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
from collections import OrderedDict
|
|
import uuid
|
|
|
|
import mock
|
|
|
|
from django.urls import reverse
|
|
|
|
from openstack_dashboard import api
|
|
from openstack_dashboard.test import helpers as test
|
|
|
|
|
|
INDEX_URL = reverse('horizon:admin:instances:index')
|
|
INDEX_TEMPLATE = 'horizon/common/_data_table_view.html'
|
|
|
|
|
|
class InstanceViewTest(test.BaseAdminViewTests):
|
|
@test.create_mocks({
|
|
api.nova: ['flavor_list', 'server_list', 'extension_supported'],
|
|
api.keystone: ['tenant_list'],
|
|
api.glance: ['image_list_detailed'],
|
|
})
|
|
def test_index(self):
|
|
servers = self.servers.list()
|
|
self.mock_extension_supported.return_value = True
|
|
self.mock_tenant_list.return_value = [self.tenants.list(), False]
|
|
self.mock_image_list_detailed.return_value = (self.images.list(),
|
|
False, False)
|
|
self.mock_flavor_list.return_value = self.flavors.list()
|
|
self.mock_server_list.return_value = [servers, False]
|
|
|
|
res = self.client.get(INDEX_URL)
|
|
self.assertTemplateUsed(res, INDEX_TEMPLATE)
|
|
instances = res.context['table'].data
|
|
self.assertItemsEqual(instances, servers)
|
|
|
|
self.mock_extension_supported.assert_has_calls([
|
|
mock.call('AdminActions', test.IsHttpRequest()),
|
|
mock.call('AdminActions', test.IsHttpRequest()),
|
|
mock.call('Shelve', test.IsHttpRequest())] * 4)
|
|
self.assertEqual(12, self.mock_extension_supported.call_count)
|
|
self.mock_tenant_list.assert_called_once_with(test.IsHttpRequest())
|
|
self.mock_image_list_detailed.assert_called_once_with(
|
|
test.IsHttpRequest())
|
|
self.mock_flavor_list.assert_called_once_with(test.IsHttpRequest())
|
|
search_opts = {'marker': None, 'paginate': True, 'all_tenants': True}
|
|
self.mock_server_list.assert_called_once_with(
|
|
test.IsHttpRequest(), search_opts=search_opts)
|
|
|
|
@test.create_mocks({
|
|
api.nova: ['flavor_list', 'flavor_get', 'server_list',
|
|
'extension_supported'],
|
|
api.keystone: ['tenant_list'],
|
|
api.glance: ['image_list_detailed'],
|
|
})
|
|
def test_index_flavor_list_exception(self):
|
|
servers = self.servers.list()
|
|
flavors = self.flavors.list()
|
|
full_flavors = OrderedDict([(f.id, f) for f in flavors])
|
|
self.mock_server_list.return_value = [servers, False]
|
|
self.mock_extension_supported.return_value = True
|
|
self.mock_flavor_list.side_effect = self.exceptions.nova
|
|
self.mock_tenant_list.return_value = [self.tenants.list(), False]
|
|
|
|
def _get_full_flavor(request, id):
|
|
return full_flavors[id]
|
|
self.mock_flavor_get.side_effect = _get_full_flavor
|
|
|
|
self.mock_image_list_detailed.return_value = (self.images.list(),
|
|
False, False)
|
|
|
|
res = self.client.get(INDEX_URL)
|
|
|
|
self.assertTemplateUsed(res, INDEX_TEMPLATE)
|
|
instances = res.context['table'].data
|
|
self.assertItemsEqual(instances, servers)
|
|
|
|
search_opts = {'marker': None, 'paginate': True, 'all_tenants': True}
|
|
self.mock_server_list.assert_called_once_with(
|
|
test.IsHttpRequest(), search_opts=search_opts)
|
|
self.mock_extension_supported.assert_has_calls([
|
|
mock.call('AdminActions', test.IsHttpRequest()),
|
|
mock.call('AdminActions', test.IsHttpRequest()),
|
|
mock.call('Shelve', test.IsHttpRequest())] * 4)
|
|
self.assertEqual(12, self.mock_extension_supported.call_count)
|
|
self.mock_flavor_list.assert_called_once_with(test.IsHttpRequest())
|
|
self.mock_tenant_list.assert_called_once_with(test.IsHttpRequest())
|
|
self.mock_flavor_get.assert_has_calls(
|
|
[mock.call(test.IsHttpRequest(), s.flavor['id']) for s in servers])
|
|
self.assertEqual(len(servers), self.mock_flavor_get.call_count)
|
|
self.mock_image_list_detailed.assert_called_once_with(
|
|
test.IsHttpRequest())
|
|
|
|
@test.create_mocks({
|
|
api.nova: ['flavor_list', 'flavor_get', 'server_list',
|
|
'extension_supported'],
|
|
api.keystone: ['tenant_list'],
|
|
api.glance: ['image_list_detailed'],
|
|
})
|
|
def test_index_flavor_get_exception(self):
|
|
servers = self.servers.list()
|
|
# UUIDs generated using indexes are unlikely to match
|
|
# any of existing flavor ids and are guaranteed to be deterministic.
|
|
for i, server in enumerate(servers):
|
|
server.flavor['id'] = str(uuid.UUID(int=i))
|
|
|
|
self.mock_image_list_detailed.return_value = \
|
|
(self.images.list(), False, False)
|
|
self.mock_flavor_list.return_value = self.flavors.list()
|
|
self.mock_server_list.return_value = [servers, False]
|
|
self.mock_extension_supported.return_value = True
|
|
self.mock_tenant_list.return_value = [self.tenants.list(), False]
|
|
self.mock_flavor_get.side_effect = self.exceptions.nova
|
|
|
|
res = self.client.get(INDEX_URL)
|
|
instances = res.context['table'].data
|
|
self.assertTemplateUsed(res, INDEX_TEMPLATE)
|
|
# Since error messages produced for each instance are identical,
|
|
# there will be only one error message for all instances
|
|
# (messages de-duplication).
|
|
self.assertMessageCount(res, error=1)
|
|
self.assertItemsEqual(instances, servers)
|
|
|
|
self.mock_image_list_detailed.assert_called_once_with(
|
|
test.IsHttpRequest())
|
|
self.mock_flavor_list.assert_called_once_with(test.IsHttpRequest())
|
|
search_opts = {'marker': None, 'paginate': True, 'all_tenants': True}
|
|
self.mock_server_list.assert_called_once_with(
|
|
test.IsHttpRequest(), search_opts=search_opts)
|
|
self.mock_extension_supported.assert_has_calls([
|
|
mock.call('AdminActions', test.IsHttpRequest()),
|
|
mock.call('AdminActions', test.IsHttpRequest()),
|
|
mock.call('Shelve', test.IsHttpRequest())] * 4)
|
|
self.assertEqual(12, self.mock_extension_supported.call_count)
|
|
self.mock_tenant_list.assert_called_once_with(test.IsHttpRequest())
|
|
self.mock_flavor_get.assert_has_calls(
|
|
[mock.call(test.IsHttpRequest(), s.flavor['id']) for s in servers])
|
|
self.assertEqual(len(servers), self.mock_flavor_get.call_count)
|
|
|
|
@test.create_mocks({
|
|
api.nova: ['server_list', 'flavor_list'],
|
|
api.keystone: ['tenant_list'],
|
|
api.glance: ['image_list_detailed'],
|
|
})
|
|
def test_index_server_list_exception(self):
|
|
self.mock_server_list.side_effect = self.exceptions.nova
|
|
self.mock_flavor_list.return_value = self.flavors.list()
|
|
self.mock_tenant_list.return_value = [self.tenants.list(), False]
|
|
self.mock_image_list_detailed.return_value = (self.images.list(),
|
|
False, False)
|
|
|
|
res = self.client.get(INDEX_URL)
|
|
self.assertTemplateUsed(res, INDEX_TEMPLATE)
|
|
self.assertEqual(len(res.context['instances_table'].data), 0)
|
|
|
|
search_opts = {'marker': None, 'paginate': True, 'all_tenants': True}
|
|
self.mock_server_list.assert_called_once_with(
|
|
test.IsHttpRequest(),
|
|
search_opts=search_opts)
|
|
self.mock_tenant_list.assert_called_once_with(test.IsHttpRequest())
|
|
self.mock_image_list_detailed.assert_called_once_with(
|
|
test.IsHttpRequest())
|
|
self.mock_flavor_list.assert_called_once_with(test.IsHttpRequest())
|
|
|
|
@test.create_mocks({api.nova: ['server_get', 'flavor_get',
|
|
'extension_supported'],
|
|
api.network: ['servers_update_addresses'],
|
|
api.keystone: ['tenant_get']})
|
|
def test_ajax_loading_instances(self):
|
|
server = self.servers.first()
|
|
self.mock_server_get.return_value = server
|
|
self.mock_extension_supported.return_value = True
|
|
self.mock_flavor_get.return_value = self.flavors.first()
|
|
self.mock_tenant_get.return_value = self.tenants.first()
|
|
self.mock_servers_update_addresses.return_value = None
|
|
|
|
url = (INDEX_URL +
|
|
"?action=row_update&table=instances&obj_id=" + server.id)
|
|
|
|
res = self.client.get(url, {},
|
|
HTTP_X_REQUESTED_WITH='XMLHttpRequest')
|
|
|
|
self.assertTemplateUsed(res, "horizon/common/_data_table_row.html")
|
|
self.assertContains(res, "test_tenant", 1, 200)
|
|
self.assertContains(res, "instance-host", 1, 200)
|
|
# two instances of name, other name comes from row data-display
|
|
self.assertContains(res, "server_1", 2, 200)
|
|
self.assertContains(res, "10.0.0.1", 1, 200)
|
|
self.assertContains(res, "RAM</th><td>512MB", 1, 200)
|
|
self.assertContains(res, "VCPUs</th><td>1", 1, 200)
|
|
self.assertContains(res, "Size</th><td>0 GB", 1, 200)
|
|
self.assertContains(res, "Active", 1, 200)
|
|
self.assertContains(res, "Running", 1, 200)
|
|
|
|
self.mock_server_get.assert_called_once_with(
|
|
test.IsHttpRequest(), server.id)
|
|
self.mock_extension_supported.assert_has_calls([
|
|
mock.call('AdminActions', test.IsHttpRequest()),
|
|
mock.call('AdminActions', test.IsHttpRequest()),
|
|
mock.call('Shelve', test.IsHttpRequest())])
|
|
self.assertEqual(3, self.mock_extension_supported.call_count)
|
|
self.mock_flavor_get.assert_called_once_with(
|
|
test.IsHttpRequest(), server.flavor['id'])
|
|
self.mock_tenant_get.assert_called_once_with(
|
|
test.IsHttpRequest(), server.tenant_id, admin=True)
|
|
self.mock_servers_update_addresses.assert_called_once_with(
|
|
test.IsHttpRequest(), [server])
|
|
|
|
@test.create_mocks({
|
|
api.nova: ['flavor_list', 'server_list', 'extension_supported'],
|
|
api.keystone: ['tenant_list'],
|
|
api.glance: ['image_list_detailed'],
|
|
})
|
|
def test_index_options_before_migrate(self):
|
|
self.mock_tenant_list.return_value = [self.tenants.list(), False]
|
|
self.mock_image_list_detailed.return_value = (self.images.list(),
|
|
False, False)
|
|
self.mock_flavor_list.return_value = self.flavors.list()
|
|
self.mock_server_list.return_value = [self.servers.list(), False]
|
|
self.mock_extension_supported.return_value = True
|
|
|
|
res = self.client.get(INDEX_URL)
|
|
self.assertContains(res, "instances__migrate")
|
|
self.assertNotContains(res, "instances__confirm")
|
|
self.assertNotContains(res, "instances__revert")
|
|
|
|
self.mock_tenant_list.assert_called_once_with(test.IsHttpRequest())
|
|
self.mock_image_list_detailed.assert_called_once_with(
|
|
test.IsHttpRequest())
|
|
self.mock_flavor_list.assert_called_once_with(test.IsHttpRequest())
|
|
search_opts = {'marker': None, 'paginate': True, 'all_tenants': True}
|
|
self.mock_server_list.assert_called_once_with(
|
|
test.IsHttpRequest(), search_opts=search_opts)
|
|
self.mock_extension_supported.assert_has_calls([
|
|
mock.call('AdminActions', test.IsHttpRequest()),
|
|
mock.call('AdminActions', test.IsHttpRequest()),
|
|
mock.call('Shelve', test.IsHttpRequest())] * 4)
|
|
self.assertEqual(12, self.mock_extension_supported.call_count)
|
|
|
|
@test.create_mocks({
|
|
api.nova: ['flavor_list', 'server_list', 'extension_supported'],
|
|
api.keystone: ['tenant_list'],
|
|
api.glance: ['image_list_detailed'],
|
|
})
|
|
def test_index_options_after_migrate(self):
|
|
servers = self.servers.list()
|
|
server1 = servers[0]
|
|
server1.status = "VERIFY_RESIZE"
|
|
server2 = servers[2]
|
|
server2.status = "VERIFY_RESIZE"
|
|
self.mock_tenant_list.return_value = [self.tenants.list(), False]
|
|
self.mock_image_list_detailed.return_value = (self.images.list(),
|
|
False, False)
|
|
self.mock_flavor_list.return_value = self.flavors.list()
|
|
self.mock_extension_supported.return_value = True
|
|
self.mock_server_list.return_value = [servers, False]
|
|
|
|
res = self.client.get(INDEX_URL)
|
|
self.assertContains(res, "instances__confirm")
|
|
self.assertContains(res, "instances__revert")
|
|
self.assertNotContains(res, "instances__migrate")
|
|
|
|
self.mock_tenant_list.assert_called_once_with(test.IsHttpRequest())
|
|
self.mock_image_list_detailed.assert_called_once_with(
|
|
test.IsHttpRequest())
|
|
self.mock_flavor_list.assert_called_once_with(test.IsHttpRequest())
|
|
self.mock_extension_supported.assert_has_calls([
|
|
mock.call('AdminActions', test.IsHttpRequest()),
|
|
mock.call('AdminActions', test.IsHttpRequest()),
|
|
mock.call('Shelve', test.IsHttpRequest())] * 4)
|
|
self.assertEqual(12, self.mock_extension_supported.call_count)
|
|
search_opts = {'marker': None, 'paginate': True, 'all_tenants': True}
|
|
self.mock_server_list.assert_called_once_with(
|
|
test.IsHttpRequest(), search_opts=search_opts)
|
|
|
|
@test.create_mocks({api.nova: ['service_list',
|
|
'server_get']})
|
|
def test_instance_live_migrate_get(self):
|
|
server = self.servers.first()
|
|
compute_services = [s for s in self.services.list()
|
|
if s.binary == 'nova-compute']
|
|
self.mock_server_get.return_value = server
|
|
self.mock_service_list.return_value = compute_services
|
|
|
|
url = reverse('horizon:admin:instances:live_migrate',
|
|
args=[server.id])
|
|
res = self.client.get(url)
|
|
|
|
self.assertTemplateUsed(res, 'admin/instances/live_migrate.html')
|
|
|
|
self.mock_server_get.assert_called_once_with(
|
|
test.IsHttpRequest(), server.id)
|
|
self.mock_service_list.assert_called_once_with(
|
|
test.IsHttpRequest(), binary='nova-compute')
|
|
|
|
@test.create_mocks({api.nova: ['server_get']})
|
|
def test_instance_live_migrate_get_server_get_exception(self):
|
|
server = self.servers.first()
|
|
self.mock_server_get.side_effect = self.exceptions.nova
|
|
|
|
url = reverse('horizon:admin:instances:live_migrate',
|
|
args=[server.id])
|
|
res = self.client.get(url)
|
|
|
|
self.assertRedirectsNoFollow(res, INDEX_URL)
|
|
|
|
self.mock_server_get.assert_called_once_with(
|
|
test.IsHttpRequest(), server.id)
|
|
|
|
@test.create_mocks({api.nova: ['service_list',
|
|
'server_get']})
|
|
def test_instance_live_migrate_list_host_get_exception(self):
|
|
server = self.servers.first()
|
|
self.mock_server_get.return_value = server
|
|
self.mock_service_list.side_effect = self.exceptions.nova
|
|
|
|
url = reverse('horizon:admin:instances:live_migrate',
|
|
args=[server.id])
|
|
res = self.client.get(url)
|
|
|
|
self.assertRedirectsNoFollow(res, INDEX_URL)
|
|
|
|
self.mock_server_get.assert_called_once_with(
|
|
test.IsHttpRequest(), server.id)
|
|
self.mock_service_list.assert_called_once_with(
|
|
test.IsHttpRequest(), binary='nova-compute')
|
|
|
|
@test.create_mocks({api.nova: ['service_list',
|
|
'server_get']})
|
|
def test_instance_live_migrate_list_host_without_current(self):
|
|
server = self.servers.first()
|
|
compute_services = [s for s in self.services.list()
|
|
if s.binary == 'nova-compute']
|
|
self.mock_server_get.return_value = server
|
|
self.mock_service_list.return_value = compute_services
|
|
|
|
url = reverse('horizon:admin:instances:live_migrate',
|
|
args=[server.id])
|
|
res = self.client.get(url)
|
|
|
|
self.assertContains(
|
|
res, "<option value=\"devstack001\">devstack001</option>")
|
|
self.assertContains(
|
|
res, "<option value=\"devstack002\">devstack002</option>")
|
|
self.assertNotContains(
|
|
res, "<option value=\"instance-host\">instance-host</option>")
|
|
|
|
self.mock_server_get.assert_called_once_with(
|
|
test.IsHttpRequest(), server.id)
|
|
self.mock_service_list.assert_called_once_with(
|
|
test.IsHttpRequest(), binary='nova-compute')
|
|
|
|
@test.create_mocks({api.nova: ['service_list',
|
|
'server_get',
|
|
'server_live_migrate']})
|
|
def test_instance_live_migrate_post(self):
|
|
server = self.servers.first()
|
|
compute_services = [s for s in self.services.list()
|
|
if s.binary == 'nova-compute']
|
|
host = compute_services[0].host
|
|
|
|
self.mock_server_get.return_value = server
|
|
self.mock_service_list.return_value = compute_services
|
|
self.mock_server_live_migrate.return_value = []
|
|
|
|
url = reverse('horizon:admin:instances:live_migrate',
|
|
args=[server.id])
|
|
res = self.client.post(url, {'host': host, 'instance_id': server.id})
|
|
|
|
self.assertNoFormErrors(res)
|
|
self.assertRedirectsNoFollow(res, INDEX_URL)
|
|
|
|
self.mock_server_get.assert_called_once_with(
|
|
test.IsHttpRequest(), server.id)
|
|
self.mock_service_list.assert_called_once_with(
|
|
test.IsHttpRequest(), binary='nova-compute')
|
|
self.mock_server_live_migrate.assert_called_once_with(
|
|
test.IsHttpRequest(), server.id, host,
|
|
block_migration=False,
|
|
disk_over_commit=False)
|
|
|
|
@test.create_mocks({api.nova: ['service_list',
|
|
'server_get',
|
|
'server_live_migrate']})
|
|
def test_instance_live_migrate_auto_sched(self):
|
|
server = self.servers.first()
|
|
host = "AUTO_SCHEDULE"
|
|
self.mock_server_get.return_value = server
|
|
compute_services = [s for s in self.services.list()
|
|
if s.binary == 'nova-compute']
|
|
self.mock_service_list.return_value = compute_services
|
|
self.mock_server_live_migrate.return_value = []
|
|
|
|
url = reverse('horizon:admin:instances:live_migrate',
|
|
args=[server.id])
|
|
res = self.client.post(url, {'host': host, 'instance_id': server.id})
|
|
|
|
self.assertNoFormErrors(res)
|
|
self.assertRedirectsNoFollow(res, INDEX_URL)
|
|
|
|
self.mock_server_get.assert_called_once_with(
|
|
test.IsHttpRequest(), server.id)
|
|
self.mock_service_list.assert_called_once_with(
|
|
test.IsHttpRequest(), binary='nova-compute')
|
|
self.mock_server_live_migrate(
|
|
test.IsHttpRequest(), server.id, None,
|
|
block_migration=False,
|
|
disk_over_commit=False)
|
|
|
|
@test.create_mocks({api.nova: ['service_list',
|
|
'server_get',
|
|
'server_live_migrate']})
|
|
def test_instance_live_migrate_post_api_exception(self):
|
|
server = self.servers.first()
|
|
compute_services = [s for s in self.services.list()
|
|
if s.binary == 'nova-compute']
|
|
host = compute_services[0].host
|
|
|
|
self.mock_server_get.return_value = server
|
|
self.mock_service_list.return_value = compute_services
|
|
self.mock_server_live_migrate.side_effect = self.exceptions.nova
|
|
|
|
url = reverse('horizon:admin:instances:live_migrate',
|
|
args=[server.id])
|
|
res = self.client.post(url, {'host': host, 'instance_id': server.id})
|
|
|
|
self.assertRedirectsNoFollow(res, INDEX_URL)
|
|
|
|
self.mock_server_get.assert_called_once_with(
|
|
test.IsHttpRequest(), server.id)
|
|
self.mock_service_list.assert_called_once_with(
|
|
test.IsHttpRequest(), binary='nova-compute')
|
|
self.mock_server_live_migrate.assert_called_once_with(
|
|
test.IsHttpRequest(), server.id, host,
|
|
block_migration=False,
|
|
disk_over_commit=False)
|
|
|
|
@test.create_mocks({api.nova: ['server_get']})
|
|
def test_instance_details_exception(self):
|
|
server = self.servers.first()
|
|
self.mock_server_get.side_effect = self.exceptions.nova
|
|
|
|
url = reverse('horizon:admin:instances:detail',
|
|
args=[server.id])
|
|
res = self.client.get(url)
|
|
|
|
self.assertRedirectsNoFollow(res, INDEX_URL)
|
|
|
|
self.mock_server_get.assert_called_once_with(
|
|
test.IsHttpRequest(), server.id)
|
|
|
|
@test.update_settings(FILTER_DATA_FIRST={'admin.instances': True})
|
|
def test_index_with_admin_filter_first(self):
|
|
res = self.client.get(INDEX_URL)
|
|
self.assertTemplateUsed(res, INDEX_TEMPLATE)
|
|
instances = res.context['table'].data
|
|
self.assertItemsEqual(instances, [])
|