
In python3, super() does not always require a class and self reference. In other words, super() is enough for most cases. This is much simpler and it is time to switch it to the newer style. pylint provides a check for this. Let's enable 'super-with-arguments' check. NOTE: _prepare_mappings() method of FormRegion in openstack_dashboard/test/integration_tests/regions/forms.py is refactored. super() (without explicit class and self referece) does not work when a subclass method calls a same method in a parent class multiple times. It looks better to prepare a separate method to provide a common logic. Change-Id: Id9512a14be9f20dbd5ebd63d446570c7b7c825ff
87 lines
3.7 KiB
Python
87 lines
3.7 KiB
Python
# Copyright 2013 Kylin OS, Inc
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
|
|
from django.urls import reverse
|
|
from django.utils.translation import ugettext_lazy as _
|
|
|
|
from horizon import exceptions
|
|
from horizon import forms
|
|
from horizon import messages
|
|
|
|
from openstack_dashboard import api
|
|
from openstack_dashboard.dashboards.project.instances \
|
|
import forms as project_forms
|
|
|
|
|
|
class LiveMigrateForm(forms.SelfHandlingForm):
|
|
current_host = forms.CharField(label=_("Current Host"),
|
|
required=False,
|
|
widget=forms.TextInput(
|
|
attrs={'readonly': 'readonly'}))
|
|
host = forms.ThemableChoiceField(
|
|
label=_("New Host"),
|
|
help_text=_("Choose a Host to migrate to."))
|
|
disk_over_commit = forms.BooleanField(label=_("Disk Over Commit"),
|
|
initial=False, required=False)
|
|
block_migration = forms.BooleanField(label=_("Block Migration"),
|
|
initial=False, required=False)
|
|
|
|
def __init__(self, request, *args, **kwargs):
|
|
super().__init__(request, *args, **kwargs)
|
|
initial = kwargs.get('initial', {})
|
|
instance_id = initial.get('instance_id')
|
|
self.fields['instance_id'] = forms.CharField(widget=forms.HiddenInput,
|
|
initial=instance_id)
|
|
self.fields['host'].choices = self.populate_host_choices(request,
|
|
initial)
|
|
|
|
def populate_host_choices(self, request, initial):
|
|
hosts = initial.get('hosts')
|
|
current_host = initial.get('current_host')
|
|
host_list = [(host, host) for host in hosts if host != current_host]
|
|
if host_list:
|
|
host_list.insert(0, ("AUTO_SCHEDULE",
|
|
_("Automatically schedule new host.")))
|
|
else:
|
|
host_list.insert(0, ("", _("No other hosts available")))
|
|
return sorted(host_list)
|
|
|
|
def handle(self, request, data):
|
|
try:
|
|
block_migration = data['block_migration']
|
|
disk_over_commit = data['disk_over_commit']
|
|
host = None if data['host'] == 'AUTO_SCHEDULE' else data['host']
|
|
api.nova.server_live_migrate(request,
|
|
data['instance_id'],
|
|
host,
|
|
block_migration=block_migration,
|
|
disk_over_commit=disk_over_commit)
|
|
msg = _('The instance is preparing the live migration '
|
|
'to a new host.')
|
|
messages.info(request, msg)
|
|
return True
|
|
except Exception:
|
|
if data['host']:
|
|
msg = _('Failed to live migrate instance to '
|
|
'host "%s".') % data['host']
|
|
else:
|
|
msg = _('Failed to live migrate instance to a new host.')
|
|
redirect = reverse('horizon:admin:instances:index')
|
|
exceptions.handle(request, msg, redirect=redirect)
|
|
|
|
|
|
class RescueInstanceForm(project_forms.RescueInstanceForm):
|
|
failure_url = 'horizon:admin:instances:index'
|