Akihiro Motoki e5d09edc20 Use python3-style super()
In python3, super() does not always require a class and self reference.
In other words, super() is enough for most cases.
This is much simpler and it is time to switch it to the newer style.

pylint provides a check for this.
Let's enable 'super-with-arguments' check.

NOTE: _prepare_mappings() method of FormRegion in
openstack_dashboard/test/integration_tests/regions/forms.py is refactored.
super() (without explicit class and self referece) does not work when
a subclass method calls a same method in a parent class multiple times.
It looks better to prepare a separate method to provide a common logic.

Change-Id: Id9512a14be9f20dbd5ebd63d446570c7b7c825ff
2020-10-15 14:37:20 +09:00

104 lines
3.5 KiB
Python

# Copyright 2012 Nebula, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain
# a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
from django.utils.translation import ugettext_lazy as _
from horizon import exceptions
from horizon import tables
from openstack_dashboard import api
from openstack_dashboard.dashboards.project.images.images \
import tables as project_tables
class AdminCreateImage(project_tables.CreateImage):
url = "horizon:admin:images:create"
class AdminDeleteImage(project_tables.DeleteImage):
def allowed(self, request, image=None):
if image and image.protected:
return False
return True
class AdminEditImage(project_tables.EditImage):
url = "horizon:admin:images:update"
def allowed(self, request, image=None):
return True
class UpdateMetadata(tables.LinkAction):
name = "update_metadata"
verbose_name = _("Update Metadata")
ajax = False
icon = "pencil"
attrs = {"ng-controller": "MetadataModalHelperController as modal"}
def __init__(self, attrs=None, **kwargs):
kwargs['preempt'] = True
super().__init__(attrs, **kwargs)
def get_link_url(self, datum):
image_id = self.table.get_object_id(datum)
self.attrs['ng-click'] = (
"modal.openMetadataModal('image', '%s', true)" % image_id)
return "javascript:void(0);"
class UpdateRow(tables.Row):
ajax = True
def get_data(self, request, image_id):
image = api.glance.image_get(request, image_id)
try:
tenant_id = getattr(image, "owner")
tenant = api.keystone.tenant_get(request, tenant_id)
image.tenant_name = getattr(tenant, "name")
except Exception:
msg = _('Unable to retrieve the project '
'information of the image.')
exceptions.handle(request, msg)
return image
class AdminImageFilterAction(tables.FilterAction):
filter_type = "server"
filter_choices = (('name', _("Image Name ="), True),
('status', _('Status ='), True),
('disk_format', _('Format ='), True),
('size_min', _('Min. Size (MB) ='), True),
('size_max', _('Max. Size (MB) ='), True))
class AdminImagesTable(project_tables.ImagesTable):
name = tables.WrappingColumn(project_tables.get_image_name,
link="horizon:admin:images:detail",
verbose_name=_("Image Name"))
tenant = tables.Column(lambda obj: getattr(obj, 'tenant_name', obj.owner),
verbose_name=_("Project"))
class Meta(object):
name = "images"
row_class = UpdateRow
status_columns = ["status"]
verbose_name = _("Images")
table_actions = (AdminCreateImage, AdminDeleteImage,
AdminImageFilterAction)
row_actions = (AdminEditImage, UpdateMetadata, AdminDeleteImage)
columns = ('tenant', 'name', 'image_type', 'status', 'public',
'protected', 'disk_format', 'size')