
In python3, super() does not always require a class and self reference. In other words, super() is enough for most cases. This is much simpler and it is time to switch it to the newer style. pylint provides a check for this. Let's enable 'super-with-arguments' check. NOTE: _prepare_mappings() method of FormRegion in openstack_dashboard/test/integration_tests/regions/forms.py is refactored. super() (without explicit class and self referece) does not work when a subclass method calls a same method in a parent class multiple times. It looks better to prepare a separate method to provide a common logic. Change-Id: Id9512a14be9f20dbd5ebd63d446570c7b7c825ff
44 lines
1.6 KiB
Python
44 lines
1.6 KiB
Python
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
import logging
|
|
|
|
from django.utils.translation import ugettext_lazy as _
|
|
|
|
import horizon
|
|
|
|
from openstack_dashboard import api
|
|
|
|
LOG = logging.getLogger(__name__)
|
|
|
|
|
|
class Aggregates(horizon.Panel):
|
|
name = _("Host Aggregates")
|
|
slug = 'aggregates'
|
|
policy_rules = (("compute", "compute_extension:aggregates"),)
|
|
permissions = ('openstack.services.compute',)
|
|
|
|
def allowed(self, context):
|
|
# extend basic permission-based check with a check to see whether
|
|
# the Aggregates extension is even enabled in nova
|
|
try:
|
|
request = context['request']
|
|
if not (api.base.is_service_enabled(request, 'compute') and
|
|
api.nova.extension_supported('Aggregates', request)):
|
|
return False
|
|
except Exception:
|
|
LOG.error("Call to list supported extensions failed. This is "
|
|
"likely due to a problem communicating with the Nova "
|
|
"endpoint. Host Aggregates panel will not be displayed.")
|
|
return False
|
|
return super().allowed(context)
|