e5d09edc20
In python3, super() does not always require a class and self reference. In other words, super() is enough for most cases. This is much simpler and it is time to switch it to the newer style. pylint provides a check for this. Let's enable 'super-with-arguments' check. NOTE: _prepare_mappings() method of FormRegion in openstack_dashboard/test/integration_tests/regions/forms.py is refactored. super() (without explicit class and self referece) does not work when a subclass method calls a same method in a parent class multiple times. It looks better to prepare a separate method to provide a common logic. Change-Id: Id9512a14be9f20dbd5ebd63d446570c7b7c825ff
64 lines
2.3 KiB
Python
64 lines
2.3 KiB
Python
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
from django.utils.translation import ugettext_lazy as _
|
|
|
|
from horizon import exceptions
|
|
from horizon import forms
|
|
from horizon import messages
|
|
|
|
from openstack_dashboard import api
|
|
from openstack_dashboard.dashboards.admin.aggregates import constants
|
|
|
|
INDEX_URL = constants.AGGREGATES_INDEX_URL
|
|
|
|
|
|
class UpdateAggregateForm(forms.SelfHandlingForm):
|
|
use_required_attribute = False
|
|
|
|
name = forms.CharField(label=_("Name"),
|
|
max_length=255)
|
|
availability_zone = forms.CharField(
|
|
label=_("Availability Zone"),
|
|
max_length=255,
|
|
# This message is used when the initial value is non-empty.
|
|
# Once AZ is set, nova API does not allow us to clear it.
|
|
error_messages={
|
|
'required': _("The new availability zone can't be empty"),
|
|
},
|
|
)
|
|
|
|
def __init__(self, request, *args, **kwargs):
|
|
super().__init__(request, *args, **kwargs)
|
|
old_availability_zone = self.initial['availability_zone']
|
|
if not old_availability_zone:
|
|
self.fields['availability_zone'].required = False
|
|
|
|
def handle(self, request, data):
|
|
id = self.initial['id']
|
|
name = data['name']
|
|
availability_zone = data['availability_zone']
|
|
|
|
aggregate = {'name': name}
|
|
if availability_zone:
|
|
aggregate['availability_zone'] = availability_zone
|
|
|
|
try:
|
|
api.nova.aggregate_update(request, id, aggregate)
|
|
message = (_('Successfully updated aggregate: "%s."')
|
|
% data['name'])
|
|
messages.success(request, message)
|
|
except Exception:
|
|
exceptions.handle(request,
|
|
_('Unable to update the aggregate.'))
|
|
return True
|