028332da4a
We have a lot of import with #noqa that is there to ignore h302, because it's traditional to import and use a name directly, instead of a whole module. This hides other errors and gives people the impression that it's actually fine to import non-modules, you just have to slap #noqa on those lines. I went through the code and identified about a dozen names that are most commonly imported this way. I remove the #noqa tag from them, and added them to the list in import_exceptions. I also removed a few unused imports that were revealed in the process. Change-Id: I27afb8e2b1d4759ec974ded9464d8f010312ee78
192 lines
6.6 KiB
Python
192 lines
6.6 KiB
Python
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
from django.core.exceptions import ValidationError # noqa
|
|
from django.core.urlresolvers import reverse
|
|
from django.utils.http import urlencode
|
|
from django.utils.translation import ugettext_lazy as _
|
|
|
|
from horizon import exceptions
|
|
from horizon import forms
|
|
from horizon import tables
|
|
from keystoneclient.exceptions import Conflict # noqa
|
|
|
|
from openstack_dashboard import api
|
|
from openstack_dashboard.api import keystone
|
|
|
|
|
|
class ViewMembersLink(tables.LinkAction):
|
|
name = "users"
|
|
verbose_name = _("Modify Users")
|
|
url = "horizon:admin:projects:update"
|
|
classes = ("ajax-modal", "btn-edit")
|
|
policy_rules = (("identity", "identity:list_users"),
|
|
("identity", "identity:list_roles"))
|
|
|
|
def get_link_url(self, project):
|
|
step = 'update_members'
|
|
base_url = reverse(self.url, args=[project.id])
|
|
param = urlencode({"step": step})
|
|
return "?".join([base_url, param])
|
|
|
|
|
|
class ViewGroupsLink(tables.LinkAction):
|
|
name = "groups"
|
|
verbose_name = _("Modify Groups")
|
|
url = "horizon:admin:projects:update"
|
|
classes = ("ajax-modal", "btn-edit")
|
|
|
|
def allowed(self, request, project):
|
|
return keystone.VERSIONS.active >= 3
|
|
|
|
def get_link_url(self, project):
|
|
step = 'update_group_members'
|
|
base_url = reverse(self.url, args=[project.id])
|
|
param = urlencode({"step": step})
|
|
return "?".join([base_url, param])
|
|
|
|
|
|
class UsageLink(tables.LinkAction):
|
|
name = "usage"
|
|
verbose_name = _("View Usage")
|
|
url = "horizon:admin:projects:usage"
|
|
classes = ("btn-stats",)
|
|
policy_rules = (("compute", "compute_extension:simple_tenant_usage:show"),)
|
|
|
|
|
|
class CreateProject(tables.LinkAction):
|
|
name = "create"
|
|
verbose_name = _("Create Project")
|
|
url = "horizon:admin:projects:create"
|
|
classes = ("btn-launch", "ajax-modal",)
|
|
policy_rules = (('identity', 'identity:create_project'),)
|
|
|
|
def allowed(self, request, project):
|
|
return api.keystone.keystone_can_edit_project()
|
|
|
|
|
|
class UpdateProject(tables.LinkAction):
|
|
name = "update"
|
|
verbose_name = _("Edit Project")
|
|
url = "horizon:admin:projects:update"
|
|
classes = ("ajax-modal", "btn-edit")
|
|
policy_rules = (('identity', 'identity:update_project'),)
|
|
|
|
def allowed(self, request, project):
|
|
return api.keystone.keystone_can_edit_project()
|
|
|
|
|
|
class ModifyQuotas(tables.LinkAction):
|
|
name = "quotas"
|
|
verbose_name = _("Modify Quotas")
|
|
url = "horizon:admin:projects:update"
|
|
classes = ("ajax-modal", "btn-edit")
|
|
policy_rules = (('compute', "compute_extension:quotas:update"),)
|
|
|
|
def get_link_url(self, project):
|
|
step = 'update_quotas'
|
|
base_url = reverse(self.url, args=[project.id])
|
|
param = urlencode({"step": step})
|
|
return "?".join([base_url, param])
|
|
|
|
|
|
class DeleteTenantsAction(tables.DeleteAction):
|
|
data_type_singular = _("Project")
|
|
data_type_plural = _("Projects")
|
|
policy_rules = (("identity", "identity:delete_project"),)
|
|
|
|
def allowed(self, request, project):
|
|
return api.keystone.keystone_can_edit_project()
|
|
|
|
def delete(self, request, obj_id):
|
|
api.keystone.tenant_delete(request, obj_id)
|
|
|
|
|
|
class TenantFilterAction(tables.FilterAction):
|
|
def filter(self, table, tenants, filter_string):
|
|
"""Really naive case-insensitive search."""
|
|
# FIXME(gabriel): This should be smarter. Written for demo purposes.
|
|
q = filter_string.lower()
|
|
|
|
def comp(tenant):
|
|
if q in tenant.name.lower():
|
|
return True
|
|
return False
|
|
|
|
return filter(comp, tenants)
|
|
|
|
|
|
class UpdateRow(tables.Row):
|
|
ajax = True
|
|
|
|
def get_data(self, request, project_id):
|
|
project_info = api.keystone.tenant_get(request, project_id,
|
|
admin=True)
|
|
return project_info
|
|
|
|
|
|
class UpdateCell(tables.UpdateAction):
|
|
def allowed(self, request, project, cell):
|
|
return api.keystone.keystone_can_edit_project()
|
|
|
|
def update_cell(self, request, datum, project_id,
|
|
cell_name, new_cell_value):
|
|
# inline update project info
|
|
try:
|
|
project_obj = datum
|
|
# updating changed value by new value
|
|
setattr(project_obj, cell_name, new_cell_value)
|
|
api.keystone.tenant_update(
|
|
request,
|
|
project_id,
|
|
name=project_obj.name,
|
|
description=project_obj.description,
|
|
enabled=project_obj.enabled)
|
|
|
|
except Conflict:
|
|
# Returning a nice error message about name conflict. The message
|
|
# from exception is not that clear for the users.
|
|
message = _("This name is already taken.")
|
|
raise ValidationError(message)
|
|
except Exception:
|
|
exceptions.handle(request, ignore=True)
|
|
return False
|
|
return True
|
|
|
|
|
|
class TenantsTable(tables.DataTable):
|
|
name = tables.Column('name', verbose_name=_('Name'),
|
|
form_field=forms.CharField(required=True),
|
|
update_action=UpdateCell)
|
|
description = tables.Column(lambda obj: getattr(obj, 'description', None),
|
|
verbose_name=_('Description'),
|
|
form_field=forms.CharField(
|
|
widget=forms.Textarea(),
|
|
required=False),
|
|
update_action=UpdateCell)
|
|
id = tables.Column('id', verbose_name=_('Project ID'))
|
|
enabled = tables.Column('enabled', verbose_name=_('Enabled'), status=True,
|
|
form_field=forms.BooleanField(
|
|
label=_('Enabled'),
|
|
required=False),
|
|
update_action=UpdateCell)
|
|
|
|
class Meta:
|
|
name = "tenants"
|
|
verbose_name = _("Projects")
|
|
row_class = UpdateRow
|
|
row_actions = (ViewMembersLink, ViewGroupsLink, UpdateProject,
|
|
UsageLink, ModifyQuotas, DeleteTenantsAction)
|
|
table_actions = (TenantFilterAction, CreateProject,
|
|
DeleteTenantsAction)
|
|
pagination_param = "tenant_marker"
|