028332da4a
We have a lot of import with #noqa that is there to ignore h302, because it's traditional to import and use a name directly, instead of a whole module. This hides other errors and gives people the impression that it's actually fine to import non-modules, you just have to slap #noqa on those lines. I went through the code and identified about a dozen names that are most commonly imported this way. I remove the #noqa tag from them, and added them to the list in import_exceptions. I also removed a few unused imports that were revealed in the process. Change-Id: I27afb8e2b1d4759ec974ded9464d8f010312ee78
209 lines
8.4 KiB
Python
209 lines
8.4 KiB
Python
# vim: tabstop=4 shiftwidth=4 softtabstop=4
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
import json
|
|
import uuid
|
|
|
|
from django.core.urlresolvers import reverse
|
|
from django import http
|
|
from mox import IsA # noqa
|
|
|
|
from openstack_dashboard import api
|
|
from openstack_dashboard.dashboards.admin.metering import tabs
|
|
from openstack_dashboard.test import helpers as test
|
|
|
|
INDEX_URL = reverse("horizon:admin:metering:index")
|
|
|
|
|
|
class MeteringViewTests(test.APITestCase, test.BaseAdminViewTests):
|
|
def test_stats_page(self):
|
|
meters = self.meters.list()
|
|
|
|
ceilometerclient = self.stub_ceilometerclient()
|
|
ceilometerclient.meters = self.mox.CreateMockAnything()
|
|
ceilometerclient.meters.list(None).AndReturn(meters)
|
|
|
|
self.mox.ReplayAll()
|
|
|
|
# getting all resources and with statistics
|
|
res = self.client.get(reverse('horizon:admin:metering:index') +
|
|
"?tab=ceilometer_overview__stats")
|
|
self.assertTemplateUsed(res, 'admin/metering/index.html')
|
|
self.assertTemplateUsed(res, 'admin/metering/stats.html')
|
|
|
|
def _verify_series(self, series, value, date, expected_names):
|
|
expected_names.reverse()
|
|
data = json.loads(series)
|
|
self.assertTrue('series' in data)
|
|
self.assertEqual(len(data['series']), len(expected_names))
|
|
for d in data['series']:
|
|
self.assertTrue('data' in d)
|
|
self.assertEqual(len(d['data']), 1)
|
|
self.assertAlmostEqual(d['data'][0].get('y'), value)
|
|
self.assertEqual(d['data'][0].get('x'), date)
|
|
self.assertEqual(d.get('name'), expected_names.pop())
|
|
self.assertEqual(d.get('unit'), '')
|
|
|
|
self.assertEqual(data.get('settings'), {})
|
|
|
|
@test.create_stubs({api.keystone: ('tenant_list',)})
|
|
def test_stats_for_line_chart(self):
|
|
statistics = self.statistics.list()
|
|
|
|
api.keystone.tenant_list(IsA(http.HttpRequest),
|
|
domain=None,
|
|
marker='tenant_marker',
|
|
paginate=True) \
|
|
.AndReturn([self.tenants.list(), False])
|
|
|
|
ceilometerclient = self.stub_ceilometerclient()
|
|
ceilometerclient.statistics = self.mox.CreateMockAnything()
|
|
# check that list is called twice for one resource and 2 meters
|
|
ceilometerclient.statistics.list(meter_name="memory",
|
|
period=IsA(int), q=IsA(list)).\
|
|
MultipleTimes().\
|
|
AndReturn(statistics)
|
|
|
|
self.mox.ReplayAll()
|
|
|
|
# get all statistics of project aggregates
|
|
res = self.client.get(reverse('horizon:admin:metering:samples') +
|
|
"?meter=memory&group_by=project&stats_attr=avg&date_options=7")
|
|
|
|
self.assertEqual(res._headers['content-type'],
|
|
('Content-Type', 'application/json'))
|
|
expected_names = ['test_tenant',
|
|
'disabled_tenant',
|
|
u'\u4e91\u89c4\u5219']
|
|
self._verify_series(res._container[0], 4.55, '2012-12-21T11:00:55',
|
|
expected_names)
|
|
|
|
@test.create_stubs({api.keystone: ('tenant_list',)})
|
|
def test_stats_for_line_chart_attr_max(self):
|
|
statistics = self.statistics.list()
|
|
|
|
api.keystone.tenant_list(IsA(http.HttpRequest),
|
|
domain=None,
|
|
marker='tenant_marker',
|
|
paginate=True) \
|
|
.AndReturn([self.tenants.list(), False])
|
|
|
|
ceilometerclient = self.stub_ceilometerclient()
|
|
ceilometerclient.statistics = self.mox.CreateMockAnything()
|
|
# check that list is called twice for one resource and 2 meters
|
|
ceilometerclient.statistics.list(meter_name="memory",
|
|
period=IsA(int), q=IsA(list)).\
|
|
MultipleTimes().\
|
|
AndReturn(statistics)
|
|
|
|
self.mox.ReplayAll()
|
|
|
|
# get all statistics of project aggregates
|
|
res = self.client.get(reverse('horizon:admin:metering:samples') +
|
|
"?meter=memory&group_by=project&stats_attr=max&date_options=7")
|
|
|
|
self.assertEqual(res._headers['content-type'],
|
|
('Content-Type', 'application/json'))
|
|
expected_names = ['test_tenant',
|
|
'disabled_tenant',
|
|
u'\u4e91\u89c4\u5219']
|
|
self._verify_series(res._container[0], 9.0, '2012-12-21T11:00:55',
|
|
expected_names)
|
|
|
|
def test_stats_for_line_chart_no_group_by(self):
|
|
resources = self.resources.list()
|
|
statistics = self.statistics.list()
|
|
|
|
ceilometerclient = self.stub_ceilometerclient()
|
|
ceilometerclient.resources = self.mox.CreateMockAnything()
|
|
ceilometerclient.resources.list(q=[]).AndReturn(resources)
|
|
|
|
ceilometerclient.statistics = self.mox.CreateMockAnything()
|
|
ceilometerclient.statistics.list(meter_name="storage.objects",
|
|
period=IsA(int), q=IsA(list)).\
|
|
MultipleTimes().\
|
|
AndReturn(statistics)
|
|
|
|
self.mox.ReplayAll()
|
|
|
|
# getting all resources and with statistics, I have only
|
|
# 'storage.objects' defined in test data
|
|
res = self.client.get(reverse('horizon:admin:metering:samples') +
|
|
"?meter=storage.objects&stats_attr=avg&date_options=7")
|
|
|
|
self.assertEqual(res._headers['content-type'],
|
|
('Content-Type', 'application/json'))
|
|
expected_names = ['fake_resource_id',
|
|
'fake_resource_id2']
|
|
self._verify_series(res._container[0], 4.55, '2012-12-21T11:00:55',
|
|
expected_names)
|
|
|
|
|
|
class MeteringStatsTabTests(test.APITestCase):
|
|
|
|
@test.create_stubs({api.nova: ('flavor_list',),
|
|
})
|
|
def test_stats_hover_hints(self):
|
|
|
|
class Struct(object):
|
|
def __init__(self, d):
|
|
self.__dict__.update(d)
|
|
|
|
def _get_link(meter):
|
|
link = ('http://localhost:8777/v2/meters/%s?'
|
|
'q.field=resource_id&q.value=ignored')
|
|
return dict(href=link % meter, rel=meter)
|
|
|
|
flavors = ['m1.tiny', 'm1.massive', 'm1.secret']
|
|
resources = [
|
|
Struct(dict(resource_id=uuid.uuid4(),
|
|
project_id='fake_project_id',
|
|
user_id='fake_user_id',
|
|
timestamp='2013-10-22T12:42:37',
|
|
metadata=dict(ramdisk_id='fake_image_id'),
|
|
links=[_get_link('instance:%s' % f),
|
|
_get_link('instance'),
|
|
_get_link('cpu')])) for f in flavors
|
|
]
|
|
request = self.mox.CreateMock(http.HttpRequest)
|
|
api.nova.flavor_list(request, None).AndReturn(self.flavors.list())
|
|
|
|
ceilometerclient = self.stub_ceilometerclient()
|
|
|
|
meters = []
|
|
for r in resources:
|
|
for link in r.links:
|
|
meters.append(Struct(dict(resource_id=r.resource_id,
|
|
project_id=r.project_id,
|
|
user_id=r.user_id,
|
|
timestamp=r.timestamp,
|
|
name=link['rel'])))
|
|
ceilometerclient.meters = self.mox.CreateMockAnything()
|
|
ceilometerclient.meters.list(None).AndReturn(meters)
|
|
|
|
self.mox.ReplayAll()
|
|
|
|
tab = tabs.GlobalStatsTab(None)
|
|
context_data = tab.get_context_data(request)
|
|
|
|
self.assertTrue('nova_meters' in context_data)
|
|
meter_hints = {}
|
|
for d in context_data['nova_meters']:
|
|
meter_hints[d.name] = d.description
|
|
|
|
expected_meters = ['instance:%s' % f for f in flavors]
|
|
expected_meters.extend(['instance', 'cpu'])
|
|
for meter in expected_meters:
|
|
self.assertTrue(meter in meter_hints)
|
|
self.assertNotEqual(meter_hints[meter], '')
|