
We have a lot of import with #noqa that is there to ignore h302, because it's traditional to import and use a name directly, instead of a whole module. This hides other errors and gives people the impression that it's actually fine to import non-modules, you just have to slap #noqa on those lines. I went through the code and identified about a dozen names that are most commonly imported this way. I remove the #noqa tag from them, and added them to the list in import_exceptions. I also removed a few unused imports that were revealed in the process. Change-Id: I27afb8e2b1d4759ec974ded9464d8f010312ee78
65 lines
1.9 KiB
Python
65 lines
1.9 KiB
Python
# vim: tabstop=4 shiftwidth=4 softtabstop=4
|
|
|
|
# Copyright 2012 Nebula, Inc.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
from django.utils.translation import ugettext_lazy as _
|
|
|
|
from horizon import tables
|
|
|
|
from openstack_dashboard import api
|
|
from openstack_dashboard.dashboards.project.images_and_snapshots.images \
|
|
import tables as project_tables
|
|
|
|
|
|
class AdminCreateImage(project_tables.CreateImage):
|
|
url = "horizon:admin:images:create"
|
|
|
|
|
|
class AdminDeleteImage(project_tables.DeleteImage):
|
|
def allowed(self, request, image=None):
|
|
if image and image.protected:
|
|
return False
|
|
else:
|
|
return True
|
|
|
|
|
|
class AdminEditImage(project_tables.EditImage):
|
|
url = "horizon:admin:images:update"
|
|
|
|
def allowed(self, request, image=None):
|
|
return True
|
|
|
|
|
|
class UpdateRow(tables.Row):
|
|
ajax = True
|
|
|
|
def get_data(self, request, image_id):
|
|
image = api.glance.image_get(request, image_id)
|
|
return image
|
|
|
|
|
|
class AdminImagesTable(project_tables.ImagesTable):
|
|
name = tables.Column("name",
|
|
link="horizon:admin:images:detail",
|
|
verbose_name=_("Image Name"))
|
|
|
|
class Meta:
|
|
name = "images"
|
|
row_class = UpdateRow
|
|
status_columns = ["status"]
|
|
verbose_name = _("Images")
|
|
table_actions = (AdminCreateImage, AdminDeleteImage)
|
|
row_actions = (AdminEditImage, AdminDeleteImage)
|