028332da4a
We have a lot of import with #noqa that is there to ignore h302, because it's traditional to import and use a name directly, instead of a whole module. This hides other errors and gives people the impression that it's actually fine to import non-modules, you just have to slap #noqa on those lines. I went through the code and identified about a dozen names that are most commonly imported this way. I remove the #noqa tag from them, and added them to the list in import_exceptions. I also removed a few unused imports that were revealed in the process. Change-Id: I27afb8e2b1d4759ec974ded9464d8f010312ee78
75 lines
2.9 KiB
Python
75 lines
2.9 KiB
Python
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
from django.core.urlresolvers import reverse
|
|
from django import http
|
|
|
|
from mox import IsA # noqa
|
|
|
|
from openstack_dashboard import api
|
|
from openstack_dashboard.test import helpers as test
|
|
|
|
|
|
class FlavorExtrasTests(test.BaseAdminViewTests):
|
|
|
|
@test.create_stubs({api.nova: ('flavor_get_extras',
|
|
'flavor_get'), })
|
|
def test_list_extras_when_none_exists(self):
|
|
flavor = self.flavors.first()
|
|
extras = [api.nova.FlavorExtraSpec(flavor.id, 'k1', 'v1')]
|
|
|
|
# GET -- to determine correctness of output
|
|
api.nova.flavor_get(IsA(http.HttpRequest), flavor.id).AndReturn(flavor)
|
|
api.nova.flavor_get_extras(IsA(http.HttpRequest),
|
|
flavor.id).AndReturn(extras)
|
|
self.mox.ReplayAll()
|
|
url = reverse('horizon:admin:flavors:extras:index', args=[flavor.id])
|
|
resp = self.client.get(url)
|
|
self.assertEqual(resp.status_code, 200)
|
|
self.assertTemplateUsed(resp, "admin/flavors/extras/index.html")
|
|
|
|
@test.create_stubs({api.nova: ('flavor_extra_set', ), })
|
|
def test_extra_create_post(self):
|
|
flavor = self.flavors.first()
|
|
create_url = reverse('horizon:admin:flavors:extras:create',
|
|
args=[flavor.id])
|
|
index_url = reverse('horizon:admin:flavors:extras:index',
|
|
args=[flavor.id])
|
|
|
|
# GET to display the flavor_name
|
|
api.nova.flavor_extra_set(IsA(http.HttpRequest),
|
|
flavor.id,
|
|
{'k1': 'v1'})
|
|
self.mox.ReplayAll()
|
|
|
|
data = {'flavor_id': flavor.id,
|
|
'key': 'k1',
|
|
'value': 'v1'}
|
|
resp = self.client.post(create_url, data)
|
|
self.assertNoFormErrors(resp)
|
|
self.assertMessageCount(success=1)
|
|
self.assertRedirectsNoFollow(resp, index_url)
|
|
|
|
@test.create_stubs({api.nova: ('flavor_get', ), })
|
|
def test_extra_create_get(self):
|
|
flavor = self.flavors.first()
|
|
create_url = reverse('horizon:admin:flavors:extras:create',
|
|
args=[flavor.id])
|
|
|
|
api.nova.flavor_get(IsA(http.HttpRequest), flavor.id).AndReturn(flavor)
|
|
self.mox.ReplayAll()
|
|
|
|
resp = self.client.get(create_url)
|
|
self.assertEqual(resp.status_code, 200)
|
|
self.assertTemplateUsed(resp,
|
|
'admin/flavors/extras/create.html')
|