From 423734b5ecb521b5574655d88d39184540f34b2d Mon Sep 17 00:00:00 2001 From: Gayathri Devi Kathiri Date: Mon, 20 Apr 2020 10:13:49 +0000 Subject: [PATCH] Fix "Update Metadata" tab on Horizon "Update Metadata" button is visible by all roles on "Volumes" and "Snaphsots". "policy_rules" is defined in "UpdateMetadata" class to fix it. Change-Id: Ibbdd4e4874c7cea97c91948003a68ebf43b8c934 closes-bug: #1873007 --- openstack_dashboard/dashboards/project/snapshots/tables.py | 2 +- openstack_dashboard/dashboards/project/volumes/tables.py | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/openstack_dashboard/dashboards/project/snapshots/tables.py b/openstack_dashboard/dashboards/project/snapshots/tables.py index 7c73b3d2d5..5db1b52b68 100644 --- a/openstack_dashboard/dashboards/project/snapshots/tables.py +++ b/openstack_dashboard/dashboards/project/snapshots/tables.py @@ -164,7 +164,7 @@ class CreateBackup(policy.PolicyTargetMixin, tables.LinkAction): class UpdateMetadata(tables.LinkAction): name = "update_metadata" verbose_name = _("Update Metadata") - + policy_rules = (("volume", "volume:update_snapshot_metadata"),) ajax = False attrs = {"ng-controller": "MetadataModalHelperController as modal"} diff --git a/openstack_dashboard/dashboards/project/volumes/tables.py b/openstack_dashboard/dashboards/project/volumes/tables.py index f0e5297f14..ecb8e4ce20 100644 --- a/openstack_dashboard/dashboards/project/volumes/tables.py +++ b/openstack_dashboard/dashboards/project/volumes/tables.py @@ -529,6 +529,7 @@ class VolumesFilterAction(tables.FilterAction): class UpdateMetadata(tables.LinkAction): name = "update_metadata" verbose_name = _("Update Metadata") + policy_rules = (("volume", "volume:update_volume_metadata"),) ajax = False attrs = {"ng-controller": "MetadataModalHelperController as modal"}