openstack/horizon
Code Issues Proposed changes

Revert "Add required mark on Create and Update image form"

Browse Source 
This reverts commit 55878ae4b2c85f26350a8ddfae18930eaeea58d9.

Minimum Disk and Minimum RAM are not required in the Glance API [1].


[1]https://docs.openstack.org/api-ref/image/v2/index.html?expanded=create-image-detail#request

Change-Id: I79212d0b5552fce3dffb5c5527b65e48e1325f52
This commit is contained in:
Ivan Kolodyazhny 2020-08-19 10:31:04 +00:00
parent 55878ae4b2
commit d5368c97a4
2 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
openstack_dashboard/static/app/core/images/steps/create-image/create-image.html
View File

@ -201,7 +201,7 @@
<div class="form-group required" <div class="form-group required"
ng-class="{'has-error':imageForm.min_disk.$invalid && imageForm.min_disk.$dirty}"> ng-class="{'has-error':imageForm.min_disk.$invalid && imageForm.min_disk.$dirty}">
<label class="control-label" for="imageForm-min_disk"> <label class="control-label" for="imageForm-min_disk">
<translate>Minimum Disk (GB)</translate><span class="hz-icon-required fa fa-asterisk"></span> <translate>Minimum Disk (GB)</translate>
</label> </label>
<input id="imageForm-min_disk" name="min_disk" <input id="imageForm-min_disk" name="min_disk"
type="number" class="form-control" type="number" class="form-control"
@ -216,7 +216,7 @@
<div class="form-group required" <div class="form-group required"
ng-class="{'has-error':imageForm.min_ram.$invalid && imageForm.min_ram.$dirty}"> ng-class="{'has-error':imageForm.min_ram.$invalid && imageForm.min_ram.$dirty}">
<label class="control-label required"> <label class="control-label required">
<translate>Minimum RAM (MB)</translate><span class="hz-icon-required fa fa-asterisk"></span> <translate>Minimum RAM (MB)</translate>
</label> </label>
<input id="imageForm-min_ram" name="min_ram" <input id="imageForm-min_ram" name="min_ram"
type="number" class="form-control" type="number" class="form-control"

8
openstack_dashboard/static/app/core/images/steps/edit-image/edit-image.html
View File

@ -88,9 +88,7 @@
<div class="col-xs-6 col-sm-3"> <div class="col-xs-6 col-sm-3">
<div class="form-group required" <div class="form-group required"
ng-class="{'has-error':imageForm.min_disk.$invalid && imageForm.min_disk.$dirty}"> ng-class="{'has-error':imageForm.min_disk.$invalid && imageForm.min_disk.$dirty}">
<label class="control-label" for="imageForm-min_disk"> <label class="control-label" for="imageForm-min_disk" translate>Minimum Disk (GB)</label>
<translate>Minimum Disk (GB)</translate><span class="hz-icon-required fa fa-asterisk"></span>
</label>
<input id="imageForm-min_disk" name="min_disk" <input id="imageForm-min_disk" name="min_disk"
type="number" class="form-control" type="number" class="form-control"
ng-required="true" ng-required="true"
@ -105,9 +103,7 @@
<div class="col-xs-6 col-sm-3"> <div class="col-xs-6 col-sm-3">
<div class="form-group required" <div class="form-group required"
ng-class="{'has-error':imageForm.min_ram.$invalid && imageForm.min_ram.$dirty}"> ng-class="{'has-error':imageForm.min_ram.$invalid && imageForm.min_ram.$dirty}">
<label class="control-label required"> <label class="control-label required" translate>Minimum RAM (MB)</label>
<translate>Minimum RAM (MB)</translate><span class="hz-icon-required fa fa-asterisk"></span>
</label>
<input id="imageForm-min_ram" name="min_ram" <input id="imageForm-min_ram" name="min_ram"
type="number" class="form-control" type="number" class="form-control"
ng-required="true" ng-required="true"