openstack/horizon
Code Issues Proposed changes

Make "availability zone" field optional for host aggregates

Browse Source 
Nova allows an admin to create/update a host aggregate without specifying
the "availability zone" but on the Horizon dashboard it is still required.

This patch makes the availability zone field optional.

Change-Id: I44a8b9ff469a203a7e1e1ae3a91e2f49bb94de86
Closes-bug: #1386076
This commit is contained in:
nikunj2512 2014-10-30 12:23:20 +05:30 committed by Chris Friesen
parent 1d4efb3535
commit 5c5037d3c6
3 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
openstack_dashboard/dashboards/admin/aggregates/forms.py
View File

@ -28,6 +28,7 @@ class UpdateAggregateForm(forms.SelfHandlingForm):
name = forms.CharField(label=_("Name"),
max_length=255)
availability_zone = forms.CharField(label=_("Availability Zone"),
required=False,
max_length=255)
def __init__(self, request, *args, **kwargs):

4
openstack_dashboard/dashboards/admin/aggregates/tests.py
View File

@ -113,7 +113,7 @@ class CreateAggregateWorkflowTests(BaseAggregateWorkflowTests):
workflow_data = self._get_create_workflow_data(aggregate)
workflow_data['name'] = ''
workflow_data['availability_zone'] = ''
self._test_generic_create_aggregate(workflow_data, aggregate, 2,
self._test_generic_create_aggregate(workflow_data, aggregate, 1,
u'This field is required')
@test.create_stubs({api.nova: ('host_list',
@ -238,7 +238,7 @@ class AggregatesViewTests(test.BaseAdminViewTests):
aggregate = self.aggregates.first()
form_data = {'id': aggregate.id}
self._test_generic_update_aggregate(form_data, aggregate, 2,
self._test_generic_update_aggregate(form_data, aggregate, 1,
u'This field is required')

3
openstack_dashboard/dashboards/admin/aggregates/workflows.py
View File

@ -25,6 +25,7 @@ class SetAggregateInfoAction(workflows.Action):
max_length=255)
availability_zone = forms.CharField(label=_("Availability Zone"),
required=False,
max_length=255)
class Meta:
@ -186,7 +187,7 @@ class CreateAggregateWorkflow(workflows.Workflow):
api.nova.aggregate_create(
request,
name=context['name'],
availability_zone=context['availability_zone'])
availability_zone=context['availability_zone'] or None)
except Exception:
exceptions.handle(request, _('Unable to create host aggregate.'))
return False