From cd3a97107da799e6461a31ecf0dd9b2d8c0e1fa4 Mon Sep 17 00:00:00 2001 From: Akihiro Motoki Date: Thu, 3 Sep 2020 11:45:02 +0900 Subject: [PATCH] pep8: Cap isort version to <5 isort 5.0.0 is not API compatible with isort 4.0.0, and our current pep8 job result has a lot of warnings: module 'isort' has no attribute 'SortImports'. A newer version of pylint has a version cap for isort, but updating pylint version needs extra works. Using isort 4.x looks like an easy workaround for us. Change-Id: I0c6c9c60901cc6be012780e8e1399dab69b50a47 --- test-requirements.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/test-requirements.txt b/test-requirements.txt index 737b13de38..d96b9b8571 100644 --- a/test-requirements.txt +++ b/test-requirements.txt @@ -13,6 +13,7 @@ astroid==2.1.0 # LGPLv2.1 bandit!=1.6.0,>=1.4.0 # Apache-2.0 coverage!=4.4,>=4.0 # Apache-2.0 flake8-import-order==0.12 # LGPLv3 +isort<5 # MIT nodeenv>=0.9.4 # BSD pytest>=5.3.5 # MIT pytest-django>=3.8.0 # BSD (3 clause)