openstack/horizon
Code Issues Proposed changes

get inappropriate information while failed to create host aggregates

Browse Source 
while creating a host aggregate named "test" with a host which belongs to
another host aggregate. I get error "Unable to create host aggregate
'Create Host Aggregate'." and "Error adding Hosts to the aggregate."
The name should be 'test' not 'Create Host Aggregate'. And the result is
that aggregate 'test' has been created successfully, so the return
information about creating aggregate should be successful.

Change-Id: I3acf9c659fc0cf7fbdac75bfa0864d8b92478cd2
Close-Bug: #1672914
This commit is contained in:
hanwei 2017-03-14 22:35:53 -04:00
parent 4187837434
commit 09a9f97407
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
openstack_dashboard/dashboards/admin/aggregates/workflows.py
View File

@ -181,6 +181,9 @@ class CreateAggregateWorkflow(workflows.Workflow):
success_url = constants.AGGREGATES_INDEX_URL
default_steps = (SetAggregateInfoStep, AddHostsToAggregateStep)
def format_status_message(self, message):
return message % self.context['name']
def handle(self, request, context):
try:
self.object = \
@ -199,7 +202,9 @@ class CreateAggregateWorkflow(workflows.Workflow):
except Exception:
exceptions.handle(
request, _('Error adding Hosts to the aggregate.'))
return False
# Host aggregate itself has been created successfully,
# so we return True here
return True
return True