cinder/idempotent-glance-metadata-aa78e09736cf57d9.yaml at fbf4899764b4ada68e42b39cec80a94c95cef03a - cinder - OpenDev: Free Software Needs Free Tools

openstack/cinder

Mark Goddard fbf4899764 Make volume Glance metadata bulk update idempotent

The cinder.db.sqlalchemy.api.volume_glance_metadata_bulk_create function
has the following in its docstring:

    This API does not support changing the value of a key once it has
    been created.

However, it actually fails if a specified key exists and has the same
value. This can cause problems if volume creation is retried following a
failure, since the metadata may have already been created.

This change modifies the function to ignore keys that exist and have the
expected value, as per the docstring.

Related-Bug: #1823445

Change-Id: Ibc3f7b995c43bc281b6978bfcba4d1a50db41fa3

2024-10-03 08:23:50 +00:00

7 lines

186 B

YAML

Raw Blame History

 ---
 fixes:
   - |
     `Bug 1823445 <https://bugs.launchpad.net/cinder/+bug/1823445>`_: Fix
     an issue with bulk updates of volume Glance metadata when keys exist
     but are unchanged.