3eb9b422f4
This adds usage of the flake8-import-order extension to our flake8 checks to enforce consistency on our import ordering to follow the overall OpenStack code guidelines. Since we have now dropped Python 2, this also cleans up a few cases for things that were third party libs but became part of the standard library such as mock, which is now a standard part of unittest. Some questions, in order of importance: Q: Are you insane? A: Potentially. Q: Why should we touch all of these files? A: This adds consistency to our imports. The extension makes sure that all imports follow our published guidelines of having imports ordered by standard lib, third party, and local. This will be a one time churn, then we can ensure consistency over time. Q: Why bother. this doesn't really matter? A: I agree - but... We have the issue that we have less people actively involved and less time to perform thorough code reviews. This will make it objective and automated to catch these kinds of issues. But part of this, even though it maybe seems a little annoying, is for making it easier for contributors. Right now, we may or may not notice if something is following the guidelines or not. And we may or may not comment in a review to ask for a contributor to make adjustments to follow the guidelines. But then further along into the review process, someone decides to be thorough, and after the contributor feels like they've had to deal with other change requests and things are in really good shape, they get a -1 on something mostly meaningless as far as the functionality of their code. It can be a frustrating and disheartening thing. I believe this actually helps avoid that by making it an objective thing that they find out right away up front - either the code is following the guidelines and everything is happy, or it's not and running local jobs or the pep8 CI job will let them know right away and they can fix it. No guessing on whether or not someone is going to take a stand on following the guidelines or not. This will also make it easier on the code reviewers. The more we can automate, the more time we can spend in code reviews making sure the logic of the change is correct and less time looking at trivial coding and style things. Q: Should we use our hacking extensions for this? A: Hacking has had to keep back linter requirements for a long time now. Current versions of the linters actually don't work with the way we've been hooking into them for our hacking checks. We will likely need to do away with those at some point so we can move on to the current linter releases. This will help ensure we have something in place when that time comes to make sure some checks are automated. Q: Didn't you spend more time on this than the benefit we'll get from it? A: Yeah, probably. Change-Id: Ic13ba238a4a45c6219f4de131cfe0366219d722f Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
90 lines
3.6 KiB
Python
90 lines
3.6 KiB
Python
# Copyright (c) 2013 Red Hat, Inc.
|
|
# All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
"""Tests for GlusterFS backup driver."""
|
|
import os
|
|
from unittest import mock
|
|
|
|
from os_brick.remotefs import remotefs as remotefs_brick
|
|
|
|
from cinder.backup.drivers import glusterfs
|
|
from cinder import context
|
|
from cinder import exception
|
|
from cinder import test
|
|
from cinder import utils
|
|
|
|
FAKE_BACKUP_MOUNT_POINT_BASE = '/fake/mount-point-base'
|
|
FAKE_HOST = 'fake_host'
|
|
FAKE_VOL_NAME = 'backup_vol'
|
|
FAKE_BACKUP_SHARE = '%s:%s' % (FAKE_HOST, FAKE_VOL_NAME)
|
|
FAKE_BACKUP_PATH = os.path.join(FAKE_BACKUP_MOUNT_POINT_BASE,
|
|
'e51e43e3c63fd5770e90e58e2eafc709')
|
|
|
|
|
|
class BackupGlusterfsShareTestCase(test.TestCase):
|
|
|
|
def setUp(self):
|
|
super(BackupGlusterfsShareTestCase, self).setUp()
|
|
self.ctxt = context.get_admin_context()
|
|
|
|
def test_check_configuration(self):
|
|
self.override_config('glusterfs_backup_share', FAKE_BACKUP_SHARE)
|
|
self.mock_object(glusterfs.GlusterfsBackupDriver,
|
|
'_init_backup_repo_path',
|
|
return_value=FAKE_BACKUP_PATH)
|
|
|
|
driver = glusterfs.GlusterfsBackupDriver(self.ctxt)
|
|
driver.check_for_setup_error()
|
|
|
|
def test_check_configuration_no_backup_share(self):
|
|
self.override_config('glusterfs_backup_share', None)
|
|
self.mock_object(glusterfs.GlusterfsBackupDriver,
|
|
'_init_backup_repo_path',
|
|
return_value=FAKE_BACKUP_PATH)
|
|
|
|
driver = glusterfs.GlusterfsBackupDriver(self.ctxt)
|
|
self.assertRaises(exception.InvalidConfigurationValue,
|
|
driver.check_for_setup_error)
|
|
|
|
def test_init_backup_repo_path(self):
|
|
self.override_config('glusterfs_backup_share', FAKE_BACKUP_SHARE)
|
|
self.override_config('glusterfs_backup_mount_point',
|
|
FAKE_BACKUP_MOUNT_POINT_BASE)
|
|
mock_remotefsclient = mock.Mock()
|
|
mock_remotefsclient.get_mount_point = mock.Mock(
|
|
return_value=FAKE_BACKUP_PATH)
|
|
self.mock_object(glusterfs.GlusterfsBackupDriver,
|
|
'check_for_setup_error')
|
|
self.mock_object(remotefs_brick, 'RemoteFsClient',
|
|
return_value=mock_remotefsclient)
|
|
self.mock_object(os, 'getegid',
|
|
return_value=333333)
|
|
self.mock_object(utils, 'get_file_gid',
|
|
return_value=333333)
|
|
self.mock_object(utils, 'get_file_mode',
|
|
return_value=00000)
|
|
self.mock_object(utils, 'get_root_helper')
|
|
|
|
with mock.patch.object(glusterfs.GlusterfsBackupDriver,
|
|
'_init_backup_repo_path'):
|
|
driver = glusterfs.GlusterfsBackupDriver(self.ctxt)
|
|
self.mock_object(driver, '_execute')
|
|
path = driver._init_backup_repo_path()
|
|
|
|
self.assertEqual(FAKE_BACKUP_PATH, path)
|
|
utils.get_root_helper.called_once()
|
|
mock_remotefsclient.mount.assert_called_once_with(FAKE_BACKUP_SHARE)
|
|
mock_remotefsclient.get_mount_point.assert_called_once_with(
|
|
FAKE_BACKUP_SHARE)
|