e8c24577b8
Add image signature verification support when creating from image. Change-Id: I37b7a795da18e3ddb18e9f293a9c795e207e7b7e Partial-Implements: bp cinder-support-image-signing
2069 lines
87 KiB
Python
2069 lines
87 KiB
Python
# Copyright 2013 Canonical Ltd.
|
|
# All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
""" Tests for create_volume TaskFlow """
|
|
|
|
import six
|
|
import sys
|
|
import uuid
|
|
|
|
import ddt
|
|
import mock
|
|
|
|
from castellan.common import exception as castellan_exc
|
|
from castellan.tests.unit.key_manager import mock_key_manager
|
|
from oslo_utils import imageutils
|
|
|
|
from cinder import context
|
|
from cinder import exception
|
|
from cinder.message import message_field
|
|
from cinder import test
|
|
from cinder.tests.unit.backup import fake_backup
|
|
from cinder.tests.unit.consistencygroup import fake_consistencygroup
|
|
from cinder.tests.unit import fake_constants as fakes
|
|
from cinder.tests.unit import fake_snapshot
|
|
from cinder.tests.unit import fake_volume
|
|
from cinder.tests.unit.image import fake as fake_image
|
|
from cinder.tests.unit import utils
|
|
from cinder.tests.unit.volume.flows import fake_volume_api
|
|
from cinder.volume.flows.api import create_volume
|
|
from cinder.volume.flows.manager import create_volume as create_volume_manager
|
|
|
|
|
|
@ddt.ddt
|
|
class CreateVolumeFlowTestCase(test.TestCase):
|
|
|
|
def time_inc(self):
|
|
self.counter += 1
|
|
return self.counter
|
|
|
|
def setUp(self):
|
|
super(CreateVolumeFlowTestCase, self).setUp()
|
|
self.ctxt = context.get_admin_context()
|
|
|
|
# Ensure that time.time() always returns more than the last time it was
|
|
# called to avoid div by zero errors.
|
|
self.counter = float(0)
|
|
self.get_extra_specs = self.patch(
|
|
'cinder.volume.volume_types.get_volume_type_extra_specs',
|
|
return_value={})
|
|
|
|
@mock.patch('cinder.objects.Volume.get_by_id')
|
|
@mock.patch('cinder.volume.utils.extract_host')
|
|
@mock.patch('time.time')
|
|
@mock.patch('cinder.objects.Snapshot.get_by_id')
|
|
def test_cast_create_volume_from_resource(self, mock_snapshot_get,
|
|
mock_time, mock_extract_host,
|
|
volume_get_by_id):
|
|
mock_time.side_effect = self.time_inc
|
|
volume = fake_volume.fake_volume_obj(self.ctxt,
|
|
host='host@backend#pool')
|
|
volume_get_by_id.return_value = volume
|
|
|
|
spec = {'volume_id': volume.id,
|
|
'volume': volume,
|
|
'source_volid': volume.id,
|
|
'snapshot_id': None,
|
|
'image_id': 4,
|
|
'consistencygroup_id': None,
|
|
'cgsnapshot_id': None,
|
|
'group_id': None,
|
|
'backup_id': None, }
|
|
|
|
# Fake objects assert specs
|
|
task = create_volume.VolumeCastTask(
|
|
fake_volume_api.FakeSchedulerRpcAPI(spec, self),
|
|
fake_volume_api.FakeVolumeAPI(spec, self),
|
|
fake_volume_api.FakeDb())
|
|
|
|
task._cast_create_volume(self.ctxt, spec, {})
|
|
mock_extract_host.assert_not_called()
|
|
|
|
snapshot = fake_snapshot.fake_snapshot_obj(self.ctxt,
|
|
volume=volume)
|
|
mock_snapshot_get.return_value = snapshot
|
|
|
|
spec = {'volume_id': volume.id,
|
|
'volume': volume,
|
|
'source_volid': None,
|
|
'snapshot_id': snapshot.id,
|
|
'image_id': 4,
|
|
'consistencygroup_id': None,
|
|
'cgsnapshot_id': None,
|
|
'group_id': None,
|
|
'backup_id': None, }
|
|
|
|
# Fake objects assert specs
|
|
task = create_volume.VolumeCastTask(
|
|
fake_volume_api.FakeSchedulerRpcAPI(spec, self),
|
|
fake_volume_api.FakeVolumeAPI(spec, self),
|
|
fake_volume_api.FakeDb())
|
|
|
|
task._cast_create_volume(self.ctxt, spec, {})
|
|
mock_snapshot_get.assert_called_once_with(self.ctxt, snapshot.id)
|
|
mock_extract_host.assert_not_called()
|
|
|
|
@mock.patch('cinder.objects.Volume.get_by_id')
|
|
@mock.patch('cinder.volume.utils.extract_host')
|
|
@mock.patch('time.time')
|
|
@mock.patch('cinder.objects.ConsistencyGroup.get_by_id')
|
|
def test_cast_create_volume(self, consistencygroup_get_by_id, mock_time,
|
|
mock_extract_host, volume_get_by_id):
|
|
mock_time.side_effect = self.time_inc
|
|
volume = fake_volume.fake_volume_obj(self.ctxt)
|
|
volume_get_by_id.return_value = volume
|
|
props = {}
|
|
cg_obj = (fake_consistencygroup.
|
|
fake_consistencyobject_obj(self.ctxt, consistencygroup_id=1,
|
|
host='host@backend#pool'))
|
|
consistencygroup_get_by_id.return_value = cg_obj
|
|
spec = {'volume_id': None,
|
|
'volume': None,
|
|
'source_volid': None,
|
|
'snapshot_id': None,
|
|
'image_id': None,
|
|
'consistencygroup_id': None,
|
|
'cgsnapshot_id': None,
|
|
'group_id': None,
|
|
'backup_id': None, }
|
|
|
|
# Fake objects assert specs
|
|
task = create_volume.VolumeCastTask(
|
|
fake_volume_api.FakeSchedulerRpcAPI(spec, self),
|
|
fake_volume_api.FakeVolumeAPI(spec, self),
|
|
fake_volume_api.FakeDb())
|
|
|
|
task._cast_create_volume(self.ctxt, spec, props)
|
|
|
|
spec = {'volume_id': volume.id,
|
|
'volume': volume,
|
|
'source_volid': 2,
|
|
'snapshot_id': 3,
|
|
'image_id': 4,
|
|
'consistencygroup_id': 5,
|
|
'cgsnapshot_id': None,
|
|
'group_id': None,
|
|
'backup_id': None, }
|
|
|
|
# Fake objects assert specs
|
|
task = create_volume.VolumeCastTask(
|
|
fake_volume_api.FakeSchedulerRpcAPI(spec, self),
|
|
fake_volume_api.FakeVolumeAPI(spec, self),
|
|
fake_volume_api.FakeDb())
|
|
|
|
task._cast_create_volume(self.ctxt, spec, props)
|
|
consistencygroup_get_by_id.assert_called_once_with(self.ctxt, 5)
|
|
mock_extract_host.assert_called_once_with('host@backend#pool')
|
|
|
|
@ddt.data(('enabled', {'replication_enabled': '<is> True'}),
|
|
('disabled', {'replication_enabled': '<is> False'}),
|
|
('disabled', {}))
|
|
@ddt.unpack
|
|
@mock.patch('cinder.volume.flows.api.create_volume.'
|
|
'ExtractVolumeRequestTask.'
|
|
'_get_encryption_key_id', mock.Mock())
|
|
@mock.patch('cinder.volume.volume_types.get_volume_type_qos_specs')
|
|
def test_extract_volume_request_replication_status(self,
|
|
replication_status,
|
|
extra_specs,
|
|
fake_get_qos):
|
|
self.get_extra_specs.return_value = extra_specs
|
|
fake_image_service = fake_image.FakeImageService()
|
|
fake_key_manager = mock_key_manager.MockKeyManager()
|
|
|
|
task = create_volume.ExtractVolumeRequestTask(fake_image_service,
|
|
{'nova'})
|
|
|
|
result = task.execute(self.ctxt,
|
|
size=1,
|
|
snapshot=None,
|
|
image_id=None,
|
|
source_volume=None,
|
|
availability_zone='nova',
|
|
volume_type={'id': fakes.VOLUME_TYPE_ID,
|
|
'size': 1},
|
|
metadata=None,
|
|
key_manager=fake_key_manager,
|
|
consistencygroup=None,
|
|
cgsnapshot=None,
|
|
group=None,
|
|
group_snapshot=None,
|
|
backup=None)
|
|
self.assertEqual(replication_status, result['replication_status'],
|
|
extra_specs)
|
|
|
|
@mock.patch('cinder.volume.volume_types.is_encrypted')
|
|
@mock.patch('cinder.volume.flows.api.create_volume.'
|
|
'ExtractVolumeRequestTask.'
|
|
'_get_volume_type_id')
|
|
@mock.patch('cinder.volume.flows.api.create_volume.'
|
|
'ExtractVolumeRequestTask.'
|
|
'_get_encryption_key_id')
|
|
@mock.patch('cinder.volume.volume_types.get_volume_type_qos_specs')
|
|
def test_extract_volume_request_from_image_encrypted(
|
|
self,
|
|
fake_get_qos,
|
|
fake_get_encryption_key,
|
|
fake_get_volume_type_id,
|
|
fake_is_encrypted):
|
|
|
|
fake_image_service = fake_image.FakeImageService()
|
|
image_id = 1
|
|
image_meta = {}
|
|
image_meta['id'] = image_id
|
|
image_meta['status'] = 'active'
|
|
image_meta['size'] = 1
|
|
fake_image_service.create(self.ctxt, image_meta)
|
|
fake_key_manager = mock_key_manager.MockKeyManager()
|
|
|
|
task = create_volume.ExtractVolumeRequestTask(
|
|
fake_image_service,
|
|
{'nova'})
|
|
|
|
fake_is_encrypted.return_value = True
|
|
fake_get_volume_type_id.return_value = fakes.VOLUME_TYPE_ID
|
|
task.execute(self.ctxt,
|
|
size=1,
|
|
snapshot=None,
|
|
image_id=image_id,
|
|
source_volume=None,
|
|
availability_zone='nova',
|
|
volume_type=None,
|
|
metadata=None,
|
|
key_manager=fake_key_manager,
|
|
consistencygroup=None,
|
|
cgsnapshot=None,
|
|
group=None,
|
|
group_snapshot=None,
|
|
backup=None)
|
|
fake_get_encryption_key.assert_called_once_with(
|
|
fake_key_manager, self.ctxt, fakes.VOLUME_TYPE_ID,
|
|
None, None, image_meta)
|
|
|
|
@mock.patch('cinder.volume.volume_types.is_encrypted')
|
|
@mock.patch('cinder.volume.volume_types.get_volume_type_qos_specs')
|
|
@mock.patch('cinder.volume.flows.api.create_volume.'
|
|
'ExtractVolumeRequestTask.'
|
|
'_get_volume_type_id')
|
|
def test_extract_volume_request_from_image(
|
|
self,
|
|
fake_get_type_id,
|
|
fake_get_qos,
|
|
fake_is_encrypted):
|
|
|
|
fake_image_service = fake_image.FakeImageService()
|
|
image_id = 2
|
|
image_meta = {}
|
|
image_meta['id'] = image_id
|
|
image_meta['status'] = 'active'
|
|
image_meta['size'] = 1
|
|
fake_image_service.create(self.ctxt, image_meta)
|
|
fake_key_manager = mock_key_manager.MockKeyManager()
|
|
volume_type = {'name': 'type1'}
|
|
|
|
task = create_volume.ExtractVolumeRequestTask(
|
|
fake_image_service,
|
|
{'nova'})
|
|
|
|
fake_is_encrypted.return_value = False
|
|
fake_get_type_id.return_value = 1
|
|
fake_get_qos.return_value = {'qos_specs': None}
|
|
result = task.execute(self.ctxt,
|
|
size=1,
|
|
snapshot=None,
|
|
image_id=image_id,
|
|
source_volume=None,
|
|
availability_zone='nova',
|
|
volume_type=volume_type,
|
|
metadata=None,
|
|
key_manager=fake_key_manager,
|
|
consistencygroup=None,
|
|
cgsnapshot=None,
|
|
group=None,
|
|
group_snapshot=None,
|
|
backup=None)
|
|
expected_result = {'size': 1,
|
|
'snapshot_id': None,
|
|
'source_volid': None,
|
|
'availability_zones': ['nova'],
|
|
'volume_type': volume_type,
|
|
'volume_type_id': 1,
|
|
'encryption_key_id': None,
|
|
'qos_specs': None,
|
|
'consistencygroup_id': None,
|
|
'cgsnapshot_id': None,
|
|
'group_id': None,
|
|
'refresh_az': False,
|
|
'replication_status': 'disabled',
|
|
'backup_id': None}
|
|
self.assertEqual(expected_result, result)
|
|
|
|
@mock.patch('cinder.volume.volume_types.is_encrypted')
|
|
@mock.patch('cinder.volume.volume_types.get_volume_type_qos_specs')
|
|
@mock.patch('cinder.volume.flows.api.create_volume.'
|
|
'ExtractVolumeRequestTask.'
|
|
'_get_volume_type_id')
|
|
def test_extract_availability_zones_without_fallback(
|
|
self,
|
|
fake_get_type_id,
|
|
fake_get_qos,
|
|
fake_is_encrypted):
|
|
fake_image_service = fake_image.FakeImageService()
|
|
image_id = 3
|
|
image_meta = {}
|
|
image_meta['id'] = image_id
|
|
image_meta['status'] = 'active'
|
|
image_meta['size'] = 1
|
|
fake_image_service.create(self.ctxt, image_meta)
|
|
fake_key_manager = mock_key_manager.MockKeyManager()
|
|
volume_type = {'name': 'type1'}
|
|
|
|
task = create_volume.ExtractVolumeRequestTask(
|
|
fake_image_service,
|
|
{'nova'})
|
|
|
|
fake_is_encrypted.return_value = False
|
|
fake_get_type_id.return_value = 1
|
|
fake_get_qos.return_value = {'qos_specs': None}
|
|
self.assertRaises(exception.InvalidAvailabilityZone,
|
|
task.execute,
|
|
self.ctxt,
|
|
size=1,
|
|
snapshot=None,
|
|
image_id=image_id,
|
|
source_volume=None,
|
|
availability_zone='notnova',
|
|
volume_type=volume_type,
|
|
metadata=None,
|
|
key_manager=fake_key_manager,
|
|
consistencygroup=None,
|
|
cgsnapshot=None,
|
|
group=None,
|
|
group_snapshot=None,
|
|
backup=None)
|
|
|
|
@mock.patch('cinder.volume.volume_types.is_encrypted')
|
|
@mock.patch('cinder.volume.volume_types.get_volume_type_qos_specs')
|
|
@mock.patch('cinder.volume.flows.api.create_volume.'
|
|
'ExtractVolumeRequestTask.'
|
|
'_get_volume_type_id')
|
|
def test_extract_availability_zones_with_azs_not_matched(
|
|
self,
|
|
fake_get_type_id,
|
|
fake_get_qos,
|
|
fake_is_encrypted):
|
|
fake_image_service = fake_image.FakeImageService()
|
|
image_id = six.text_type(uuid.uuid4())
|
|
image_meta = {}
|
|
image_meta['id'] = image_id
|
|
image_meta['status'] = 'active'
|
|
image_meta['size'] = 1
|
|
fake_image_service.create(self.ctxt, image_meta)
|
|
fake_key_manager = mock_key_manager.MockKeyManager()
|
|
volume_type = {'name': 'type1',
|
|
'extra_specs':
|
|
{'RESKEY:availability_zones': 'nova3'}}
|
|
|
|
task = create_volume.ExtractVolumeRequestTask(
|
|
fake_image_service, {'nova1', 'nova2'})
|
|
|
|
fake_is_encrypted.return_value = False
|
|
fake_get_type_id.return_value = 1
|
|
fake_get_qos.return_value = {'qos_specs': None}
|
|
self.assertRaises(exception.InvalidTypeAvailabilityZones,
|
|
task.execute,
|
|
self.ctxt,
|
|
size=1,
|
|
snapshot=None,
|
|
image_id=image_id,
|
|
source_volume=None,
|
|
availability_zone='notnova',
|
|
volume_type=volume_type,
|
|
metadata=None,
|
|
key_manager=fake_key_manager,
|
|
consistencygroup=None,
|
|
cgsnapshot=None,
|
|
group=None,
|
|
group_snapshot=None,
|
|
backup=None)
|
|
|
|
@ddt.data({'type_azs': 'nova3',
|
|
'self_azs': ['nova3'],
|
|
'expected': ['nova3']},
|
|
{'type_azs': 'nova3, nova2',
|
|
'self_azs': ['nova3'],
|
|
'expected': ['nova3']},
|
|
{'type_azs': 'nova3,,,',
|
|
'self_azs': ['nova3'],
|
|
'expected': ['nova3']},
|
|
{'type_azs': 'nova3',
|
|
'self_azs': ['nova2'],
|
|
'expected': exception.InvalidTypeAvailabilityZones},
|
|
{'type_azs': ',,',
|
|
'self_azs': ['nova2'],
|
|
'expected': exception.InvalidTypeAvailabilityZones}
|
|
)
|
|
@ddt.unpack
|
|
def test__extract_availability_zones_az_not_specified(self, type_azs,
|
|
self_azs, expected):
|
|
fake_image_service = fake_image.FakeImageService()
|
|
image_id = six.text_type(uuid.uuid4())
|
|
image_meta = {}
|
|
image_meta['id'] = image_id
|
|
image_meta['status'] = 'active'
|
|
image_meta['size'] = 1
|
|
fake_image_service.create(self.ctxt, image_meta)
|
|
volume_type = {'name': 'type1',
|
|
'extra_specs':
|
|
{'RESKEY:availability_zones': type_azs}}
|
|
|
|
task = create_volume.ExtractVolumeRequestTask(
|
|
fake_image_service,
|
|
{'nova'})
|
|
task.availability_zones = self_azs
|
|
if isinstance(expected, list):
|
|
result = task._extract_availability_zones(
|
|
None, {}, {}, {}, volume_type=volume_type)
|
|
self.assertEqual(expected, result[0])
|
|
else:
|
|
self.assertRaises(
|
|
expected, task._extract_availability_zones,
|
|
None, {}, {}, {}, volume_type=volume_type)
|
|
|
|
def test__extract_availability_zones_az_not_in_type_azs(self):
|
|
self.override_config('allow_availability_zone_fallback', False)
|
|
fake_image_service = fake_image.FakeImageService()
|
|
image_id = six.text_type(uuid.uuid4())
|
|
image_meta = {}
|
|
image_meta['id'] = image_id
|
|
image_meta['status'] = 'active'
|
|
image_meta['size'] = 1
|
|
fake_image_service.create(self.ctxt, image_meta)
|
|
volume_type = {'name': 'type1',
|
|
'extra_specs':
|
|
{'RESKEY:availability_zones': 'nova1, nova2'}}
|
|
|
|
task = create_volume.ExtractVolumeRequestTask(
|
|
fake_image_service,
|
|
{'nova'})
|
|
task.availability_zones = ['nova1']
|
|
|
|
self.assertRaises(exception.InvalidAvailabilityZone,
|
|
task._extract_availability_zones,
|
|
'nova2', {}, {}, {}, volume_type=volume_type)
|
|
|
|
@mock.patch('cinder.volume.volume_types.is_encrypted')
|
|
@mock.patch('cinder.volume.volume_types.get_volume_type_qos_specs')
|
|
@mock.patch('cinder.volume.flows.api.create_volume.'
|
|
'ExtractVolumeRequestTask.'
|
|
'_get_volume_type_id')
|
|
def test_extract_availability_zones_with_fallback(
|
|
self,
|
|
fake_get_type_id,
|
|
fake_get_qos,
|
|
fake_is_encrypted):
|
|
|
|
self.override_config('allow_availability_zone_fallback', True)
|
|
|
|
fake_image_service = fake_image.FakeImageService()
|
|
image_id = 4
|
|
image_meta = {}
|
|
image_meta['id'] = image_id
|
|
image_meta['status'] = 'active'
|
|
image_meta['size'] = 1
|
|
fake_image_service.create(self.ctxt, image_meta)
|
|
fake_key_manager = mock_key_manager.MockKeyManager()
|
|
volume_type = {'name': 'type1'}
|
|
|
|
task = create_volume.ExtractVolumeRequestTask(
|
|
fake_image_service,
|
|
{'nova'})
|
|
|
|
fake_is_encrypted.return_value = False
|
|
fake_get_type_id.return_value = 1
|
|
fake_get_qos.return_value = {'qos_specs': None}
|
|
result = task.execute(self.ctxt,
|
|
size=1,
|
|
snapshot=None,
|
|
image_id=image_id,
|
|
source_volume=None,
|
|
availability_zone='does_not_exist',
|
|
volume_type=volume_type,
|
|
metadata=None,
|
|
key_manager=fake_key_manager,
|
|
consistencygroup=None,
|
|
cgsnapshot=None,
|
|
group=None,
|
|
group_snapshot=None,
|
|
backup=None)
|
|
expected_result = {'size': 1,
|
|
'snapshot_id': None,
|
|
'source_volid': None,
|
|
'availability_zones': ['nova'],
|
|
'volume_type': volume_type,
|
|
'volume_type_id': 1,
|
|
'encryption_key_id': None,
|
|
'qos_specs': None,
|
|
'consistencygroup_id': None,
|
|
'cgsnapshot_id': None,
|
|
'group_id': None,
|
|
'refresh_az': True,
|
|
'replication_status': 'disabled',
|
|
'backup_id': None}
|
|
self.assertEqual(expected_result, result)
|
|
|
|
@mock.patch('cinder.volume.volume_types.is_encrypted',
|
|
return_value=True)
|
|
@mock.patch('cinder.volume.volume_types.get_volume_type_encryption',
|
|
return_value=mock.Mock(cipher='my-cipher-2000'))
|
|
@mock.patch('cinder.volume.volume_types.get_volume_type_qos_specs',
|
|
return_value={'qos_specs': None})
|
|
@mock.patch('cinder.volume.flows.api.create_volume.'
|
|
'ExtractVolumeRequestTask._get_volume_type_id',
|
|
return_value=1)
|
|
def test_get_encryption_key_id_castellan_error(
|
|
self,
|
|
mock_get_type_id,
|
|
mock_get_qos,
|
|
mock_get_volume_type_encryption,
|
|
mock_is_encrypted):
|
|
|
|
fake_image_service = fake_image.FakeImageService()
|
|
image_id = 99
|
|
image_meta = {'id': image_id,
|
|
'status': 'active',
|
|
'size': 1}
|
|
fake_image_service.create(self.ctxt, image_meta)
|
|
fake_key_manager = mock_key_manager.MockKeyManager()
|
|
volume_type = {'name': 'type1'}
|
|
|
|
with mock.patch.object(fake_key_manager, 'create_key',
|
|
side_effect=castellan_exc.KeyManagerError):
|
|
with mock.patch.object(fake_key_manager, 'get',
|
|
return_value=fakes.ENCRYPTION_KEY_ID):
|
|
|
|
task = create_volume.ExtractVolumeRequestTask(
|
|
fake_image_service,
|
|
{'nova'})
|
|
|
|
self.assertRaises(exception.Invalid,
|
|
task.execute,
|
|
self.ctxt,
|
|
size=1,
|
|
snapshot=None,
|
|
image_id=image_id,
|
|
source_volume=None,
|
|
availability_zone='nova',
|
|
volume_type=volume_type,
|
|
metadata=None,
|
|
key_manager=fake_key_manager,
|
|
consistencygroup=None,
|
|
cgsnapshot=None,
|
|
group=None,
|
|
group_snapshot=None,
|
|
backup=None)
|
|
|
|
mock_is_encrypted.assert_called_with(self.ctxt, 1)
|
|
mock_get_volume_type_encryption.assert_called_once_with(self.ctxt, 1)
|
|
|
|
@mock.patch('cinder.volume.volume_types.is_encrypted')
|
|
@mock.patch('cinder.volume.volume_types.get_volume_type_qos_specs')
|
|
@mock.patch('cinder.volume.flows.api.create_volume.'
|
|
'ExtractVolumeRequestTask.'
|
|
'_get_volume_type_id')
|
|
def test_extract_volume_request_task_with_large_volume_size(
|
|
self,
|
|
fake_get_type_id,
|
|
fake_get_qos,
|
|
fake_is_encrypted):
|
|
fake_image_service = fake_image.FakeImageService()
|
|
image_id = 11
|
|
image_meta = {}
|
|
image_meta['id'] = image_id
|
|
image_meta['status'] = 'active'
|
|
image_meta['size'] = 1
|
|
fake_image_service.create(self.ctxt, image_meta)
|
|
fake_key_manager = mock_key_manager.MockKeyManager()
|
|
volume_type = {'name': 'type1'}
|
|
|
|
task = create_volume.ExtractVolumeRequestTask(
|
|
fake_image_service,
|
|
{'nova'})
|
|
|
|
fake_is_encrypted.return_value = False
|
|
fake_get_type_id.return_value = 1
|
|
fake_get_qos.return_value = {'qos_specs': None}
|
|
result = task.execute(self.ctxt,
|
|
size=(sys.maxsize + 1),
|
|
snapshot=None,
|
|
image_id=image_id,
|
|
source_volume=None,
|
|
availability_zone=None,
|
|
volume_type=volume_type,
|
|
metadata=None,
|
|
key_manager=fake_key_manager,
|
|
consistencygroup=None,
|
|
cgsnapshot=None,
|
|
group=None,
|
|
group_snapshot=None,
|
|
backup=None)
|
|
expected_result = {'size': (sys.maxsize + 1),
|
|
'snapshot_id': None,
|
|
'source_volid': None,
|
|
'availability_zones': ['nova'],
|
|
'volume_type': volume_type,
|
|
'volume_type_id': 1,
|
|
'encryption_key_id': None,
|
|
'qos_specs': None,
|
|
'replication_status': 'disabled',
|
|
'consistencygroup_id': None,
|
|
'cgsnapshot_id': None,
|
|
'refresh_az': False,
|
|
'group_id': None,
|
|
'backup_id': None}
|
|
self.assertEqual(expected_result, result)
|
|
|
|
@mock.patch('cinder.volume.volume_types.is_encrypted')
|
|
@mock.patch('cinder.volume.volume_types.get_volume_type_qos_specs')
|
|
@mock.patch('cinder.volume.flows.api.create_volume.'
|
|
'ExtractVolumeRequestTask.'
|
|
'_get_volume_type_id')
|
|
def test_extract_volume_request_from_image_with_qos_specs(
|
|
self,
|
|
fake_get_type_id,
|
|
fake_get_qos,
|
|
fake_is_encrypted):
|
|
|
|
fake_image_service = fake_image.FakeImageService()
|
|
image_id = 5
|
|
image_meta = {}
|
|
image_meta['id'] = image_id
|
|
image_meta['status'] = 'active'
|
|
image_meta['size'] = 1
|
|
fake_image_service.create(self.ctxt, image_meta)
|
|
fake_key_manager = mock_key_manager.MockKeyManager()
|
|
volume_type = {'name': 'type1'}
|
|
|
|
task = create_volume.ExtractVolumeRequestTask(
|
|
fake_image_service,
|
|
{'nova'})
|
|
|
|
fake_is_encrypted.return_value = False
|
|
fake_get_type_id.return_value = 1
|
|
fake_qos_spec = {'specs': {'fake_key': 'fake'}}
|
|
fake_get_qos.return_value = {'qos_specs': fake_qos_spec}
|
|
result = task.execute(self.ctxt,
|
|
size=1,
|
|
snapshot=None,
|
|
image_id=image_id,
|
|
source_volume=None,
|
|
availability_zone='nova',
|
|
volume_type=volume_type,
|
|
metadata=None,
|
|
key_manager=fake_key_manager,
|
|
consistencygroup=None,
|
|
cgsnapshot=None,
|
|
group=None,
|
|
group_snapshot=None,
|
|
backup=None)
|
|
expected_result = {'size': 1,
|
|
'snapshot_id': None,
|
|
'source_volid': None,
|
|
'availability_zones': ['nova'],
|
|
'volume_type': volume_type,
|
|
'volume_type_id': 1,
|
|
'encryption_key_id': None,
|
|
'qos_specs': {'fake_key': 'fake'},
|
|
'consistencygroup_id': None,
|
|
'cgsnapshot_id': None,
|
|
'group_id': None,
|
|
'refresh_az': False,
|
|
'replication_status': 'disabled',
|
|
'backup_id': None}
|
|
self.assertEqual(expected_result, result)
|
|
|
|
@mock.patch('cinder.volume.volume_types.is_encrypted')
|
|
@mock.patch('cinder.volume.volume_types.get_volume_type_qos_specs')
|
|
@mock.patch('cinder.volume.volume_types.get_default_volume_type')
|
|
@mock.patch('cinder.volume.volume_types.get_volume_type_by_name')
|
|
@mock.patch('cinder.volume.flows.api.create_volume.'
|
|
'ExtractVolumeRequestTask.'
|
|
'_get_volume_type_id')
|
|
def test_extract_image_volume_type_from_image(
|
|
self,
|
|
fake_get_type_id,
|
|
fake_get_vol_type,
|
|
fake_get_def_vol_type,
|
|
fake_get_qos,
|
|
fake_is_encrypted):
|
|
|
|
image_volume_type = {'name': 'type_from_image'}
|
|
fake_image_service = fake_image.FakeImageService()
|
|
image_id = 6
|
|
image_meta = {}
|
|
image_meta['id'] = image_id
|
|
image_meta['status'] = 'active'
|
|
image_meta['size'] = 1
|
|
image_meta['properties'] = {}
|
|
image_meta['properties']['cinder_img_volume_type'] = image_volume_type
|
|
fake_image_service.create(self.ctxt, image_meta)
|
|
fake_key_manager = mock_key_manager.MockKeyManager()
|
|
|
|
task = create_volume.ExtractVolumeRequestTask(
|
|
fake_image_service,
|
|
{'nova'})
|
|
|
|
fake_is_encrypted.return_value = False
|
|
fake_get_type_id.return_value = 1
|
|
fake_get_vol_type.return_value = image_volume_type
|
|
fake_get_def_vol_type.return_value = 'fake_vol_type'
|
|
fake_get_qos.return_value = {'qos_specs': None}
|
|
result = task.execute(self.ctxt,
|
|
size=1,
|
|
snapshot=None,
|
|
image_id=image_id,
|
|
source_volume=None,
|
|
availability_zone='nova',
|
|
volume_type=None,
|
|
metadata=None,
|
|
key_manager=fake_key_manager,
|
|
consistencygroup=None,
|
|
cgsnapshot=None,
|
|
group=None,
|
|
group_snapshot=None,
|
|
backup=None)
|
|
expected_result = {'size': 1,
|
|
'snapshot_id': None,
|
|
'source_volid': None,
|
|
'availability_zones': ['nova'],
|
|
'volume_type': image_volume_type,
|
|
'volume_type_id': 1,
|
|
'encryption_key_id': None,
|
|
'qos_specs': None,
|
|
'consistencygroup_id': None,
|
|
'cgsnapshot_id': None,
|
|
'group_id': None,
|
|
'refresh_az': False,
|
|
'replication_status': 'disabled',
|
|
'backup_id': None}
|
|
self.assertEqual(expected_result, result)
|
|
|
|
@mock.patch('cinder.db.volume_type_get_by_name')
|
|
@mock.patch('cinder.volume.volume_types.is_encrypted')
|
|
@mock.patch('cinder.volume.volume_types.get_volume_type_qos_specs')
|
|
@mock.patch('cinder.volume.volume_types.get_default_volume_type')
|
|
@mock.patch('cinder.volume.flows.api.create_volume.'
|
|
'ExtractVolumeRequestTask.'
|
|
'_get_volume_type_id')
|
|
def test_extract_image_volume_type_from_image_invalid_type(
|
|
self,
|
|
fake_get_type_id,
|
|
fake_get_def_vol_type,
|
|
fake_get_qos,
|
|
fake_is_encrypted,
|
|
fake_db_get_vol_type):
|
|
|
|
image_volume_type = 'invalid'
|
|
fake_image_service = fake_image.FakeImageService()
|
|
image_id = 7
|
|
image_meta = {}
|
|
image_meta['id'] = image_id
|
|
image_meta['status'] = 'active'
|
|
image_meta['size'] = 1
|
|
image_meta['properties'] = {}
|
|
image_meta['properties']['cinder_img_volume_type'] = image_volume_type
|
|
fake_image_service.create(self.ctxt, image_meta)
|
|
fake_key_manager = mock_key_manager.MockKeyManager()
|
|
|
|
task = create_volume.ExtractVolumeRequestTask(
|
|
fake_image_service,
|
|
{'nova'})
|
|
|
|
fake_is_encrypted.return_value = False
|
|
fake_get_type_id.return_value = 1
|
|
fake_get_def_vol_type.return_value = {'name': 'fake_vol_type'}
|
|
fake_db_get_vol_type.side_effect = (
|
|
exception.VolumeTypeNotFoundByName(volume_type_name='invalid'))
|
|
fake_get_qos.return_value = {'qos_specs': None}
|
|
result = task.execute(self.ctxt,
|
|
size=1,
|
|
snapshot=None,
|
|
image_id=image_id,
|
|
source_volume=None,
|
|
availability_zone='nova',
|
|
volume_type=None,
|
|
metadata=None,
|
|
key_manager=fake_key_manager,
|
|
consistencygroup=None,
|
|
cgsnapshot=None,
|
|
group=None,
|
|
group_snapshot=None,
|
|
backup=None)
|
|
expected_result = {'size': 1,
|
|
'snapshot_id': None,
|
|
'source_volid': None,
|
|
'availability_zones': ['nova'],
|
|
'volume_type': {'name': 'fake_vol_type'},
|
|
'volume_type_id': 1,
|
|
'encryption_key_id': None,
|
|
'qos_specs': None,
|
|
'consistencygroup_id': None,
|
|
'cgsnapshot_id': None,
|
|
'group_id': None,
|
|
'refresh_az': False,
|
|
'replication_status': 'disabled',
|
|
'backup_id': None}
|
|
self.assertEqual(expected_result, result)
|
|
|
|
@mock.patch('cinder.db.volume_type_get_by_name')
|
|
@mock.patch('cinder.volume.volume_types.is_encrypted')
|
|
@mock.patch('cinder.volume.volume_types.get_volume_type_qos_specs')
|
|
@mock.patch('cinder.volume.volume_types.get_default_volume_type')
|
|
@mock.patch('cinder.volume.flows.api.create_volume.'
|
|
'ExtractVolumeRequestTask.'
|
|
'_get_volume_type_id')
|
|
@ddt.data((8, None), (9, {'cinder_img_volume_type': None}))
|
|
@ddt.unpack
|
|
def test_extract_image_volume_type_from_image_properties_error(
|
|
self,
|
|
image_id,
|
|
fake_img_properties,
|
|
fake_get_type_id,
|
|
fake_get_def_vol_type,
|
|
fake_get_qos,
|
|
fake_is_encrypted,
|
|
fake_db_get_vol_type):
|
|
|
|
fake_image_service = fake_image.FakeImageService()
|
|
image_meta = {}
|
|
image_meta['id'] = image_id
|
|
image_meta['status'] = 'active'
|
|
image_meta['size'] = 1
|
|
image_meta['properties'] = fake_img_properties
|
|
fake_image_service.create(self.ctxt, image_meta)
|
|
fake_key_manager = mock_key_manager.MockKeyManager()
|
|
|
|
task = create_volume.ExtractVolumeRequestTask(
|
|
fake_image_service,
|
|
{'nova'})
|
|
|
|
fake_is_encrypted.return_value = False
|
|
fake_get_type_id.return_value = 1
|
|
fake_get_def_vol_type.return_value = {'name': 'fake_vol_type'}
|
|
fake_get_qos.return_value = {'qos_specs': None}
|
|
result = task.execute(self.ctxt,
|
|
size=1,
|
|
snapshot=None,
|
|
image_id=image_id,
|
|
source_volume=None,
|
|
availability_zone='nova',
|
|
volume_type=None,
|
|
metadata=None,
|
|
key_manager=fake_key_manager,
|
|
consistencygroup=None,
|
|
cgsnapshot=None,
|
|
group=None,
|
|
group_snapshot=None,
|
|
backup=None)
|
|
expected_result = {'size': 1,
|
|
'snapshot_id': None,
|
|
'source_volid': None,
|
|
'availability_zones': ['nova'],
|
|
'volume_type': {'name': 'fake_vol_type'},
|
|
'volume_type_id': 1,
|
|
'encryption_key_id': None,
|
|
'qos_specs': None,
|
|
'consistencygroup_id': None,
|
|
'cgsnapshot_id': None,
|
|
'group_id': None,
|
|
'refresh_az': False,
|
|
'replication_status': 'disabled',
|
|
'backup_id': None}
|
|
self.assertEqual(expected_result, result)
|
|
|
|
@mock.patch('cinder.db.volume_type_get_by_name')
|
|
@mock.patch('cinder.volume.volume_types.is_encrypted')
|
|
@mock.patch('cinder.volume.volume_types.get_volume_type_qos_specs')
|
|
@mock.patch('cinder.volume.volume_types.get_default_volume_type')
|
|
@mock.patch('cinder.volume.flows.api.create_volume.'
|
|
'ExtractVolumeRequestTask.'
|
|
'_get_volume_type_id')
|
|
def test_extract_image_volume_type_from_image_invalid_input(
|
|
self,
|
|
fake_get_type_id,
|
|
fake_get_def_vol_type,
|
|
fake_get_qos,
|
|
fake_is_encrypted,
|
|
fake_db_get_vol_type):
|
|
|
|
fake_image_service = fake_image.FakeImageService()
|
|
image_id = 10
|
|
image_meta = {}
|
|
image_meta['id'] = image_id
|
|
image_meta['status'] = 'inactive'
|
|
fake_image_service.create(self.ctxt, image_meta)
|
|
fake_key_manager = mock_key_manager.MockKeyManager()
|
|
|
|
task = create_volume.ExtractVolumeRequestTask(
|
|
fake_image_service,
|
|
{'nova'})
|
|
|
|
fake_is_encrypted.return_value = False
|
|
fake_get_type_id.return_value = 1
|
|
fake_get_def_vol_type.return_value = 'fake_vol_type'
|
|
fake_get_qos.return_value = {'qos_specs': None}
|
|
|
|
self.assertRaises(exception.InvalidInput,
|
|
task.execute,
|
|
self.ctxt,
|
|
size=1,
|
|
snapshot=None,
|
|
image_id=image_id,
|
|
source_volume=None,
|
|
availability_zone='nova',
|
|
volume_type=None,
|
|
metadata=None,
|
|
key_manager=fake_key_manager,
|
|
consistencygroup=None,
|
|
cgsnapshot=None,
|
|
group=None,
|
|
group_snapshot=None,
|
|
backup=None)
|
|
|
|
|
|
@ddt.ddt
|
|
class CreateVolumeFlowManagerTestCase(test.TestCase):
|
|
|
|
def setUp(self):
|
|
super(CreateVolumeFlowManagerTestCase, self).setUp()
|
|
self.ctxt = context.get_admin_context()
|
|
|
|
@mock.patch('cinder.volume.flows.manager.create_volume.'
|
|
'CreateVolumeFromSpecTask.'
|
|
'_cleanup_cg_in_volume')
|
|
@mock.patch('cinder.volume.flows.manager.create_volume.'
|
|
'CreateVolumeFromSpecTask.'
|
|
'_handle_bootable_volume_glance_meta')
|
|
@mock.patch('cinder.objects.Volume.get_by_id')
|
|
@mock.patch('cinder.objects.Snapshot.get_by_id')
|
|
def test_create_from_snapshot(self, snapshot_get_by_id, volume_get_by_id,
|
|
handle_bootable, cleanup_cg):
|
|
fake_db = mock.MagicMock()
|
|
fake_driver = mock.MagicMock()
|
|
fake_volume_manager = mock.MagicMock()
|
|
fake_manager = create_volume_manager.CreateVolumeFromSpecTask(
|
|
fake_volume_manager, fake_db, fake_driver)
|
|
volume_db = {'bootable': True}
|
|
volume_obj = fake_volume.fake_volume_obj(self.ctxt, **volume_db)
|
|
snapshot_obj = fake_snapshot.fake_snapshot_obj(self.ctxt)
|
|
snapshot_get_by_id.return_value = snapshot_obj
|
|
volume_get_by_id.return_value = volume_obj
|
|
|
|
fake_manager._create_from_snapshot(self.ctxt, volume_obj,
|
|
snapshot_obj.id)
|
|
fake_driver.create_volume_from_snapshot.assert_called_once_with(
|
|
volume_obj, snapshot_obj)
|
|
handle_bootable.assert_called_once_with(self.ctxt, volume_obj,
|
|
snapshot_id=snapshot_obj.id)
|
|
cleanup_cg.assert_called_once_with(volume_obj)
|
|
|
|
@mock.patch('cinder.volume.flows.manager.create_volume.'
|
|
'CreateVolumeFromSpecTask.'
|
|
'_cleanup_cg_in_volume')
|
|
@mock.patch('cinder.objects.Snapshot.get_by_id')
|
|
def test_create_from_snapshot_update_failure(self, snapshot_get_by_id,
|
|
mock_cleanup_cg):
|
|
fake_db = mock.MagicMock()
|
|
fake_driver = mock.MagicMock()
|
|
fake_volume_manager = mock.MagicMock()
|
|
fake_manager = create_volume_manager.CreateVolumeFromSpecTask(
|
|
fake_volume_manager, fake_db, fake_driver)
|
|
volume_obj = fake_volume.fake_volume_obj(self.ctxt)
|
|
snapshot_obj = fake_snapshot.fake_snapshot_obj(self.ctxt)
|
|
snapshot_get_by_id.return_value = snapshot_obj
|
|
fake_db.volume_get.side_effect = exception.CinderException
|
|
|
|
self.assertRaises(exception.MetadataUpdateFailure,
|
|
fake_manager._create_from_snapshot, self.ctxt,
|
|
volume_obj, snapshot_obj.id)
|
|
fake_driver.create_volume_from_snapshot.assert_called_once_with(
|
|
volume_obj, snapshot_obj)
|
|
mock_cleanup_cg.assert_called_once_with(volume_obj)
|
|
|
|
@mock.patch('cinder.volume.flows.manager.create_volume.'
|
|
'CreateVolumeFromSpecTask.'
|
|
'_cleanup_cg_in_volume')
|
|
@mock.patch('cinder.volume.flows.manager.create_volume.'
|
|
'CreateVolumeFromSpecTask.'
|
|
'_prepare_image_cache_entry')
|
|
@mock.patch('cinder.volume.flows.manager.create_volume.'
|
|
'CreateVolumeFromSpecTask.'
|
|
'_handle_bootable_volume_glance_meta')
|
|
@mock.patch('cinder.image.image_utils.TemporaryImages.fetch')
|
|
@mock.patch('cinder.image.image_utils.qemu_img_info')
|
|
@mock.patch('cinder.image.image_utils.check_virtual_size')
|
|
def test_create_encrypted_volume_from_image(self,
|
|
mock_check_size,
|
|
mock_qemu_img,
|
|
mock_fetch_img,
|
|
mock_handle_bootable,
|
|
mock_prepare_image_cache,
|
|
mock_cleanup_cg):
|
|
fake_db = mock.MagicMock()
|
|
fake_driver = mock.MagicMock()
|
|
fake_volume_manager = mock.MagicMock()
|
|
fake_cache = mock.MagicMock()
|
|
fake_manager = create_volume_manager.CreateVolumeFromSpecTask(
|
|
fake_volume_manager, fake_db, fake_driver, fake_cache)
|
|
volume = fake_volume.fake_volume_obj(
|
|
self.ctxt,
|
|
encryption_key_id=fakes.ENCRYPTION_KEY_ID,
|
|
host='host@backend#pool')
|
|
|
|
fake_image_service = fake_image.FakeImageService()
|
|
image_meta = {}
|
|
image_id = fakes.IMAGE_ID
|
|
image_meta['id'] = image_id
|
|
image_meta['status'] = 'active'
|
|
image_meta['size'] = 1
|
|
image_location = 'abc'
|
|
|
|
fake_db.volume_update.return_value = volume
|
|
fake_manager._create_from_image(self.ctxt, volume,
|
|
image_location, image_id,
|
|
image_meta, fake_image_service)
|
|
|
|
fake_driver.create_volume.assert_called_once_with(volume)
|
|
fake_driver.copy_image_to_encrypted_volume.assert_called_once_with(
|
|
self.ctxt, volume, fake_image_service, image_id)
|
|
mock_prepare_image_cache.assert_not_called()
|
|
mock_handle_bootable.assert_called_once_with(self.ctxt, volume,
|
|
image_id=image_id,
|
|
image_meta=image_meta)
|
|
mock_cleanup_cg.assert_called_once_with(volume)
|
|
|
|
@mock.patch('cinder.volume.flows.manager.create_volume.'
|
|
'CreateVolumeFromSpecTask.'
|
|
'_cleanup_cg_in_volume')
|
|
@mock.patch('cinder.volume.flows.manager.create_volume.'
|
|
'CreateVolumeFromSpecTask.'
|
|
'_handle_bootable_volume_glance_meta')
|
|
@mock.patch('cinder.image.image_utils.TemporaryImages.fetch')
|
|
@mock.patch('cinder.image.image_utils.qemu_img_info')
|
|
@mock.patch('cinder.image.image_utils.check_virtual_size')
|
|
def test_create_encrypted_volume_from_enc_image(self,
|
|
mock_check_size,
|
|
mock_qemu_img,
|
|
mock_fetch_img,
|
|
mock_handle_bootable,
|
|
mock_cleanup_cg):
|
|
fake_db = mock.MagicMock()
|
|
fake_driver = mock.MagicMock()
|
|
fake_volume_manager = mock.MagicMock()
|
|
fake_manager = create_volume_manager.CreateVolumeFromSpecTask(
|
|
fake_volume_manager, fake_db, fake_driver)
|
|
volume = fake_volume.fake_volume_obj(
|
|
self.ctxt,
|
|
encryption_key_id=fakes.ENCRYPTION_KEY_ID,
|
|
host='host@backend#pool')
|
|
|
|
fake_image_service = fake_image.FakeImageService()
|
|
image_meta = {}
|
|
image_id = fakes.IMAGE_ID
|
|
image_meta['id'] = image_id
|
|
image_meta['status'] = 'active'
|
|
image_meta['size'] = 1
|
|
image_meta['cinder_encryption_key_id'] = \
|
|
'00000000-0000-0000-0000-000000000000'
|
|
image_location = 'abc'
|
|
|
|
fake_db.volume_update.return_value = volume
|
|
fake_manager._create_from_image(self.ctxt, volume,
|
|
image_location, image_id,
|
|
image_meta, fake_image_service)
|
|
|
|
fake_driver.create_volume.assert_called_once_with(volume)
|
|
fake_driver.copy_image_to_encrypted_volume.assert_not_called()
|
|
fake_driver.copy_image_to_volume.assert_called_once_with(
|
|
self.ctxt, volume, fake_image_service, image_id)
|
|
mock_handle_bootable.assert_called_once_with(self.ctxt, volume,
|
|
image_id=image_id,
|
|
image_meta=image_meta)
|
|
mock_cleanup_cg.assert_called_once_with(volume)
|
|
|
|
@ddt.data(True, False)
|
|
def test__copy_image_to_volume(self, is_encrypted):
|
|
fake_db = mock.MagicMock()
|
|
fake_driver = mock.MagicMock()
|
|
fake_volume_manager = mock.MagicMock()
|
|
fake_manager = create_volume_manager.CreateVolumeFromSpecTask(
|
|
fake_volume_manager, fake_db, fake_driver)
|
|
key = fakes.ENCRYPTION_KEY_ID if is_encrypted else None
|
|
volume = fake_volume.fake_volume_obj(
|
|
self.ctxt,
|
|
encryption_key_id=key)
|
|
|
|
fake_image_service = fake_image.FakeImageService()
|
|
image_id = fakes.IMAGE_ID
|
|
image_meta = {'id': image_id}
|
|
image_location = 'abc'
|
|
|
|
fake_manager._copy_image_to_volume(self.ctxt, volume, image_meta,
|
|
image_location, fake_image_service)
|
|
if is_encrypted:
|
|
fake_driver.copy_image_to_encrypted_volume.assert_called_once_with(
|
|
self.ctxt, volume, fake_image_service, image_id)
|
|
else:
|
|
fake_driver.copy_image_to_volume.assert_called_once_with(
|
|
self.ctxt, volume, fake_image_service, image_id)
|
|
|
|
@ddt.data({'driver_error': True},
|
|
{'driver_error': False})
|
|
@mock.patch('cinder.backup.api.API.get_available_backup_service_host')
|
|
@mock.patch('cinder.backup.rpcapi.BackupAPI.restore_backup')
|
|
@mock.patch('oslo_service.loopingcall.'
|
|
'FixedIntervalWithTimeoutLoopingCall')
|
|
@mock.patch('cinder.volume.flows.manager.create_volume.'
|
|
'CreateVolumeFromSpecTask.'
|
|
'_create_raw_volume')
|
|
@mock.patch('cinder.db.volume_update')
|
|
@mock.patch('cinder.db.backup_update')
|
|
@mock.patch('cinder.objects.Volume.get_by_id')
|
|
@mock.patch('cinder.objects.Backup.get_by_id')
|
|
@ddt.unpack
|
|
def test_create_from_backup(self,
|
|
backup_get_by_id,
|
|
volume_get_by_id,
|
|
mock_backup_update,
|
|
mock_volume_update,
|
|
mock_create_volume,
|
|
mock_fixed_looping_call,
|
|
mock_restore_backup,
|
|
mock_get_backup_host,
|
|
driver_error):
|
|
fake_db = mock.MagicMock()
|
|
fake_driver = mock.MagicMock()
|
|
fake_volume_manager = mock.MagicMock()
|
|
backup_host = 'host@backend#pool'
|
|
fake_manager = create_volume_manager.CreateVolumeFromSpecTask(
|
|
fake_volume_manager, fake_db, fake_driver)
|
|
|
|
volume_obj = fake_volume.fake_volume_obj(self.ctxt)
|
|
backup_obj = fake_backup.fake_backup_obj(self.ctxt,
|
|
**{'status': 'available',
|
|
'host': backup_host})
|
|
backup_get_by_id.return_value = backup_obj
|
|
volume_get_by_id.return_value = volume_obj
|
|
|
|
mock_create_volume.return_value = {}
|
|
mock_get_backup_host.return_value = backup_host
|
|
mock_fixed_looping_call.return_value = mock.MagicMock()
|
|
|
|
if driver_error:
|
|
fake_driver.create_volume_from_backup.side_effect = [
|
|
NotImplementedError]
|
|
fake_manager._create_from_backup(self.ctxt, volume_obj,
|
|
backup_obj.id)
|
|
fake_driver.create_volume_from_backup.assert_called_once_with(
|
|
volume_obj, backup_obj)
|
|
if driver_error:
|
|
mock_create_volume.assert_called_once_with(volume_obj)
|
|
mock_get_backup_host.assert_called_once_with(
|
|
backup_obj.host, backup_obj.availability_zone)
|
|
mock_restore_backup.assert_called_once_with(self.ctxt,
|
|
backup_host,
|
|
backup_obj,
|
|
volume_obj['id'])
|
|
else:
|
|
fake_driver.create_volume_from_backup.assert_called_once_with(
|
|
volume_obj, backup_obj)
|
|
|
|
|
|
class CreateVolumeFlowManagerGlanceCinderBackendCase(test.TestCase):
|
|
|
|
def setUp(self):
|
|
super(CreateVolumeFlowManagerGlanceCinderBackendCase, self).setUp()
|
|
self.ctxt = context.get_admin_context()
|
|
|
|
@mock.patch('cinder.volume.flows.manager.create_volume.'
|
|
'CreateVolumeFromSpecTask.'
|
|
'_cleanup_cg_in_volume')
|
|
@mock.patch('cinder.image.image_utils.TemporaryImages.fetch')
|
|
@mock.patch('cinder.volume.flows.manager.create_volume.'
|
|
'CreateVolumeFromSpecTask.'
|
|
'_handle_bootable_volume_glance_meta')
|
|
@mock.patch('cinder.image.image_utils.qemu_img_info')
|
|
def test_create_from_image_volume(self, mock_qemu_info, handle_bootable,
|
|
mock_fetch_img, mock_cleanup_cg,
|
|
format='raw', owner=None,
|
|
location=True):
|
|
self.flags(allowed_direct_url_schemes=['cinder'])
|
|
mock_fetch_img.return_value = mock.MagicMock(
|
|
spec=utils.get_file_spec())
|
|
fake_db = mock.MagicMock()
|
|
fake_driver = mock.MagicMock()
|
|
fake_manager = create_volume_manager.CreateVolumeFromSpecTask(
|
|
mock.MagicMock(), fake_db, fake_driver)
|
|
fake_image_service = fake_image.FakeImageService()
|
|
|
|
volume = fake_volume.fake_volume_obj(self.ctxt,
|
|
host='host@backend#pool')
|
|
image_volume = fake_volume.fake_volume_obj(self.ctxt,
|
|
volume_metadata={})
|
|
image_id = fakes.IMAGE_ID
|
|
image_info = imageutils.QemuImgInfo()
|
|
image_info.virtual_size = '1073741824'
|
|
mock_qemu_info.return_value = image_info
|
|
|
|
url = 'cinder://%s' % image_volume['id']
|
|
image_location = None
|
|
if location:
|
|
image_location = (url, [{'url': url, 'metadata': {}}])
|
|
image_meta = {'id': image_id,
|
|
'container_format': 'bare',
|
|
'disk_format': format,
|
|
'size': 1024,
|
|
'owner': owner or self.ctxt.project_id,
|
|
'virtual_size': None,
|
|
'cinder_encryption_key_id': None}
|
|
|
|
fake_driver.clone_image.return_value = (None, False)
|
|
fake_db.volume_get_all_by_host.return_value = [image_volume]
|
|
|
|
fake_manager._create_from_image(self.ctxt,
|
|
volume,
|
|
image_location,
|
|
image_id,
|
|
image_meta,
|
|
fake_image_service)
|
|
if format is 'raw' and not owner and location:
|
|
fake_driver.create_cloned_volume.assert_called_once_with(
|
|
volume, image_volume)
|
|
handle_bootable.assert_called_once_with(self.ctxt, volume,
|
|
image_id=image_id,
|
|
image_meta=image_meta)
|
|
else:
|
|
self.assertFalse(fake_driver.create_cloned_volume.called)
|
|
mock_cleanup_cg.assert_called_once_with(volume)
|
|
|
|
@mock.patch('cinder.volume.flows.manager.create_volume.'
|
|
'CreateVolumeFromSpecTask.'
|
|
'_cleanup_cg_in_volume')
|
|
@mock.patch('cinder.image.image_utils.TemporaryImages.fetch')
|
|
@mock.patch('cinder.volume.flows.manager.create_volume.'
|
|
'CreateVolumeFromSpecTask.'
|
|
'_handle_bootable_volume_glance_meta')
|
|
@mock.patch('cinder.image.image_utils.qemu_img_info')
|
|
def test_create_from_image_volume_ignore_size(self, mock_qemu_info,
|
|
handle_bootable,
|
|
mock_fetch_img,
|
|
mock_cleanup_cg,
|
|
format='raw',
|
|
owner=None,
|
|
location=True):
|
|
self.flags(allowed_direct_url_schemes=['cinder'])
|
|
self.override_config('allowed_direct_url_schemes', 'cinder')
|
|
mock_fetch_img.return_value = mock.MagicMock(
|
|
spec=utils.get_file_spec())
|
|
fake_db = mock.MagicMock()
|
|
fake_driver = mock.MagicMock()
|
|
fake_manager = create_volume_manager.CreateVolumeFromSpecTask(
|
|
mock.MagicMock(), fake_db, fake_driver)
|
|
fake_image_service = fake_image.FakeImageService()
|
|
|
|
volume = fake_volume.fake_volume_obj(self.ctxt,
|
|
host='host@backend#pool')
|
|
image_volume = fake_volume.fake_volume_obj(self.ctxt,
|
|
volume_metadata={})
|
|
image_id = fakes.IMAGE_ID
|
|
image_info = imageutils.QemuImgInfo()
|
|
# Making huge image. If cinder will try to convert it, it
|
|
# will fail because of free space being too low.
|
|
image_info.virtual_size = '1073741824000000000000'
|
|
mock_qemu_info.return_value = image_info
|
|
url = 'cinder://%s' % image_volume['id']
|
|
image_location = None
|
|
if location:
|
|
image_location = (url, [{'url': url, 'metadata': {}}])
|
|
image_meta = {'id': image_id,
|
|
'container_format': 'bare',
|
|
'disk_format': format,
|
|
'size': 1024,
|
|
'owner': owner or self.ctxt.project_id,
|
|
'virtual_size': None,
|
|
'cinder_encryption_key_id': None}
|
|
|
|
fake_driver.clone_image.return_value = (None, False)
|
|
fake_db.volume_get_all_by_host.return_value = [image_volume]
|
|
fake_manager._create_from_image(self.ctxt,
|
|
volume,
|
|
image_location,
|
|
image_id,
|
|
image_meta,
|
|
fake_image_service)
|
|
if format is 'raw' and not owner and location:
|
|
fake_driver.create_cloned_volume.assert_called_once_with(
|
|
volume, image_volume)
|
|
handle_bootable.assert_called_once_with(self.ctxt, volume,
|
|
image_id=image_id,
|
|
image_meta=image_meta)
|
|
else:
|
|
self.assertFalse(fake_driver.create_cloned_volume.called)
|
|
mock_cleanup_cg.assert_called_once_with(volume)
|
|
|
|
def test_create_from_image_volume_in_qcow2_format(self):
|
|
self.test_create_from_image_volume(format='qcow2')
|
|
|
|
def test_create_from_image_volume_of_other_owner(self):
|
|
self.test_create_from_image_volume(owner='fake-owner')
|
|
|
|
def test_create_from_image_volume_without_location(self):
|
|
self.test_create_from_image_volume(location=False)
|
|
|
|
|
|
@ddt.ddt
|
|
@mock.patch('cinder.image.image_utils.TemporaryImages.fetch')
|
|
@mock.patch('cinder.volume.flows.manager.create_volume.'
|
|
'CreateVolumeFromSpecTask.'
|
|
'_handle_bootable_volume_glance_meta')
|
|
@mock.patch('cinder.volume.flows.manager.create_volume.'
|
|
'CreateVolumeFromSpecTask.'
|
|
'_create_from_source_volume')
|
|
@mock.patch('cinder.volume.flows.manager.create_volume.'
|
|
'CreateVolumeFromSpecTask.'
|
|
'_create_from_image_download')
|
|
@mock.patch('cinder.context.get_internal_tenant_context')
|
|
class CreateVolumeFlowManagerImageCacheTestCase(test.TestCase):
|
|
|
|
def setUp(self):
|
|
super(CreateVolumeFlowManagerImageCacheTestCase, self).setUp()
|
|
self.ctxt = context.get_admin_context()
|
|
self.mock_db = mock.MagicMock()
|
|
self.mock_driver = mock.MagicMock()
|
|
self.mock_cache = mock.MagicMock()
|
|
self.mock_image_service = mock.MagicMock()
|
|
self.mock_volume_manager = mock.MagicMock()
|
|
|
|
self.internal_context = self.ctxt
|
|
self.internal_context.user_id = 'abc123'
|
|
self.internal_context.project_id = 'def456'
|
|
|
|
@mock.patch('cinder.image.image_utils.check_available_space')
|
|
def test_create_from_image_clone_image_and_skip_cache(
|
|
self, mock_check_space, mock_get_internal_context,
|
|
mock_create_from_img_dl, mock_create_from_src,
|
|
mock_handle_bootable, mock_fetch_img):
|
|
self.mock_driver.clone_image.return_value = (None, True)
|
|
volume = fake_volume.fake_volume_obj(self.ctxt,
|
|
host='host@backend#pool')
|
|
|
|
image_location = 'someImageLocationStr'
|
|
image_id = fakes.IMAGE_ID
|
|
image_meta = {'virtual_size': '1073741824', 'size': 1073741824}
|
|
|
|
manager = create_volume_manager.CreateVolumeFromSpecTask(
|
|
self.mock_volume_manager,
|
|
self.mock_db,
|
|
self.mock_driver,
|
|
image_volume_cache=self.mock_cache
|
|
)
|
|
|
|
manager._create_from_image(self.ctxt,
|
|
volume,
|
|
image_location,
|
|
image_id,
|
|
image_meta,
|
|
self.mock_image_service)
|
|
|
|
# Make sure check_available_space is not called because the driver
|
|
# will clone things for us.
|
|
self.assertFalse(mock_check_space.called)
|
|
|
|
# Make sure clone_image is always called even if the cache is enabled
|
|
self.assertTrue(self.mock_driver.clone_image.called)
|
|
|
|
# Create from source shouldn't happen if clone_image succeeds
|
|
self.assertFalse(mock_create_from_src.called)
|
|
|
|
# The image download should not happen if clone_image succeeds
|
|
self.assertFalse(mock_create_from_img_dl.called)
|
|
|
|
mock_handle_bootable.assert_called_once_with(
|
|
self.ctxt,
|
|
volume,
|
|
image_id=image_id,
|
|
image_meta=image_meta
|
|
)
|
|
|
|
@mock.patch('cinder.image.image_utils.qemu_img_info')
|
|
@mock.patch('cinder.image.image_utils.check_available_space')
|
|
@mock.patch('cinder.image.image_utils.verify_glance_image_signature')
|
|
def test_create_from_image_cannot_use_cache(
|
|
self, mock_verify, mock_qemu_info, mock_check_space,
|
|
mock_get_internal_context,
|
|
mock_create_from_img_dl, mock_create_from_src,
|
|
mock_handle_bootable, mock_fetch_img):
|
|
mock_get_internal_context.return_value = None
|
|
self.mock_driver.clone_image.return_value = (None, False)
|
|
self.flags(verify_glance_signatures='disabled')
|
|
volume = fake_volume.fake_volume_obj(self.ctxt,
|
|
host='host@backend#pool')
|
|
image_info = imageutils.QemuImgInfo()
|
|
image_info.virtual_size = '1073741824'
|
|
mock_qemu_info.return_value = image_info
|
|
|
|
image_location = 'someImageLocationStr'
|
|
image_id = fakes.IMAGE_ID
|
|
image_meta = {'id': image_id,
|
|
'virtual_size': '1073741824',
|
|
'size': 1073741824}
|
|
|
|
manager = create_volume_manager.CreateVolumeFromSpecTask(
|
|
self.mock_volume_manager,
|
|
self.mock_db,
|
|
self.mock_driver,
|
|
image_volume_cache=self.mock_cache
|
|
)
|
|
|
|
manager._create_from_image(self.ctxt,
|
|
volume,
|
|
image_location,
|
|
image_id,
|
|
image_meta,
|
|
self.mock_image_service)
|
|
|
|
# Make sure check_available_space is always called
|
|
self.assertTrue(mock_check_space.called)
|
|
|
|
# Make sure clone_image is always called
|
|
self.assertTrue(self.mock_driver.clone_image.called)
|
|
|
|
# Create from source shouldn't happen if cache cannot be used.
|
|
self.assertFalse(mock_create_from_src.called)
|
|
|
|
# The image download should happen if clone fails and we can't use the
|
|
# image-volume cache.
|
|
mock_create_from_img_dl.assert_called_once_with(
|
|
self.ctxt,
|
|
volume,
|
|
image_location,
|
|
image_meta,
|
|
self.mock_image_service
|
|
)
|
|
|
|
# This should not attempt to use a minimal size volume
|
|
self.assertFalse(self.mock_db.volume_update.called)
|
|
|
|
# Make sure we didn't try and create a cache entry
|
|
self.assertFalse(self.mock_cache.ensure_space.called)
|
|
self.assertFalse(self.mock_cache.create_cache_entry.called)
|
|
|
|
mock_handle_bootable.assert_called_once_with(
|
|
self.ctxt,
|
|
volume,
|
|
image_id=image_id,
|
|
image_meta=image_meta
|
|
)
|
|
|
|
@ddt.data(
|
|
NotImplementedError('Driver does not support clone'),
|
|
exception.CinderException('Error during cloning'))
|
|
def test_create_from_image_clone_failure(
|
|
self, effect, mock_get_internal_context,
|
|
mock_create_from_img_dl, mock_create_from_src,
|
|
mock_handle_bootable, mock_fetch_img):
|
|
mock_get_internal_context.return_value = None
|
|
volume = fake_volume.fake_volume_obj(self.ctxt)
|
|
mock_create_from_src.side_effect = effect
|
|
|
|
image_id = fakes.IMAGE_ID
|
|
image_meta = {'virtual_size': '1073741824'}
|
|
|
|
manager = create_volume_manager.CreateVolumeFromSpecTask(
|
|
self.mock_volume_manager,
|
|
self.mock_db,
|
|
self.mock_driver,
|
|
image_volume_cache=self.mock_cache
|
|
)
|
|
|
|
model, result = manager._create_from_image_cache(self.ctxt,
|
|
None,
|
|
volume,
|
|
image_id,
|
|
image_meta)
|
|
|
|
self.assertIsNone(model)
|
|
self.assertFalse(result)
|
|
|
|
@mock.patch('cinder.volume.flows.manager.create_volume.'
|
|
'CreateVolumeFromSpecTask.'
|
|
'_cleanup_cg_in_volume')
|
|
@mock.patch('cinder.image.image_utils.check_available_space')
|
|
@mock.patch('cinder.image.image_utils.qemu_img_info')
|
|
@mock.patch('cinder.db.volume_update')
|
|
@mock.patch('cinder.image.image_utils.verify_glance_image_signature')
|
|
def test_create_from_image_extend_failure(
|
|
self, mock_verify, mock_volume_update, mock_qemu_info,
|
|
mock_check_size,
|
|
mock_get_internal_context, mock_create_from_img_dl,
|
|
mock_create_from_src, mock_handle_bootable, mock_fetch_img,
|
|
mock_cleanup_cg):
|
|
self.mock_driver.clone_image.return_value = (None, False)
|
|
self.mock_cache.get_entry.return_value = None
|
|
self.mock_driver.extend_volume.side_effect = (
|
|
exception.CinderException('Error during extending'))
|
|
self.flags(verify_glance_signatures='disabled')
|
|
|
|
volume_size = 2
|
|
volume = fake_volume.fake_volume_obj(self.ctxt,
|
|
host='host@backend#pool',
|
|
size=volume_size)
|
|
|
|
image_info = imageutils.QemuImgInfo()
|
|
image_info.virtual_size = '1073741824'
|
|
mock_qemu_info.return_value = image_info
|
|
|
|
image_location = 'someImageLocationStr'
|
|
image_id = fakes.IMAGE_ID
|
|
image_meta = {'virtual_size': '1073741824', 'size': '1073741824'}
|
|
|
|
manager = create_volume_manager.CreateVolumeFromSpecTask(
|
|
self.mock_volume_manager,
|
|
self.mock_db,
|
|
self.mock_driver,
|
|
image_volume_cache=self.mock_cache
|
|
)
|
|
|
|
self.assertRaises(exception.CinderException,
|
|
manager._create_from_image,
|
|
self.ctxt,
|
|
volume,
|
|
image_location,
|
|
image_id,
|
|
image_meta,
|
|
self.mock_image_service)
|
|
|
|
self.assertTrue(mock_cleanup_cg.called)
|
|
mock_volume_update.assert_any_call(self.ctxt, volume.id, {'size': 1})
|
|
self.assertEqual(volume_size, volume.size)
|
|
|
|
@mock.patch('cinder.image.image_utils.check_available_space')
|
|
def test_create_from_image_bigger_size(
|
|
self, mock_check_space, mock_get_internal_context,
|
|
mock_create_from_img_dl, mock_create_from_src,
|
|
mock_handle_bootable, mock_fetch_img):
|
|
volume = fake_volume.fake_volume_obj(self.ctxt)
|
|
|
|
image_location = 'someImageLocationStr'
|
|
image_id = fakes.IMAGE_ID
|
|
image_meta = {'virtual_size': '2147483648', 'size': 2147483648}
|
|
|
|
manager = create_volume_manager.CreateVolumeFromSpecTask(
|
|
self.mock_volume_manager,
|
|
self.mock_db,
|
|
self.mock_driver,
|
|
image_volume_cache=self.mock_cache
|
|
)
|
|
|
|
self.assertRaises(
|
|
exception.ImageUnacceptable,
|
|
manager._create_from_image,
|
|
self.ctxt,
|
|
volume,
|
|
image_location,
|
|
image_id,
|
|
image_meta,
|
|
self.mock_image_service)
|
|
|
|
def test_create_from_image_cache_hit(
|
|
self, mock_get_internal_context, mock_create_from_img_dl,
|
|
mock_create_from_src, mock_handle_bootable, mock_fetch_img):
|
|
self.mock_driver.clone_image.return_value = (None, False)
|
|
image_volume_id = '70a599e0-31e7-49b7-b260-868f441e862b'
|
|
self.mock_cache.get_entry.return_value = {
|
|
'volume_id': image_volume_id
|
|
}
|
|
|
|
volume = fake_volume.fake_volume_obj(self.ctxt,
|
|
host='host@backend#pool')
|
|
|
|
image_location = 'someImageLocationStr'
|
|
image_id = fakes.IMAGE_ID
|
|
image_meta = {'virtual_size': None, 'size': 1024}
|
|
|
|
manager = create_volume_manager.CreateVolumeFromSpecTask(
|
|
self.mock_volume_manager,
|
|
self.mock_db,
|
|
self.mock_driver,
|
|
image_volume_cache=self.mock_cache
|
|
)
|
|
|
|
manager._create_from_image(self.ctxt,
|
|
volume,
|
|
image_location,
|
|
image_id,
|
|
image_meta,
|
|
self.mock_image_service)
|
|
|
|
# Make sure clone_image is always called even if the cache is enabled
|
|
self.assertTrue(self.mock_driver.clone_image.called)
|
|
|
|
# For a cache hit it should only clone from the image-volume
|
|
mock_create_from_src.assert_called_once_with(self.ctxt,
|
|
volume,
|
|
image_volume_id)
|
|
|
|
# The image download should not happen when we get a cache hit
|
|
self.assertFalse(mock_create_from_img_dl.called)
|
|
|
|
mock_handle_bootable.assert_called_once_with(
|
|
self.ctxt,
|
|
volume,
|
|
image_id=image_id,
|
|
image_meta=image_meta
|
|
)
|
|
|
|
@mock.patch('cinder.db.volume_update')
|
|
@mock.patch('cinder.objects.Volume.get_by_id')
|
|
@mock.patch('cinder.image.image_utils.qemu_img_info')
|
|
@mock.patch('cinder.image.image_utils.check_available_space')
|
|
@mock.patch('cinder.image.image_utils.verify_glance_image_signature')
|
|
def test_create_from_image_cache_miss(
|
|
self, mocl_verify, mock_check_size, mock_qemu_info,
|
|
mock_volume_get, mock_volume_update, mock_get_internal_context,
|
|
mock_create_from_img_dl, mock_create_from_src,
|
|
mock_handle_bootable, mock_fetch_img):
|
|
mock_get_internal_context.return_value = self.ctxt
|
|
mock_fetch_img.return_value = mock.MagicMock(
|
|
spec=utils.get_file_spec())
|
|
self.flags(verify_glance_signatures='disabled')
|
|
image_info = imageutils.QemuImgInfo()
|
|
image_info.virtual_size = '2147483648'
|
|
mock_qemu_info.return_value = image_info
|
|
self.mock_driver.clone_image.return_value = (None, False)
|
|
self.mock_cache.get_entry.return_value = None
|
|
|
|
volume = fake_volume.fake_volume_obj(self.ctxt, size=10,
|
|
host='foo@bar#pool')
|
|
mock_volume_get.return_value = volume
|
|
|
|
image_location = 'someImageLocationStr'
|
|
image_id = fakes.IMAGE_ID
|
|
image_meta = {'id': image_id,
|
|
'size': 2000000}
|
|
|
|
manager = create_volume_manager.CreateVolumeFromSpecTask(
|
|
self.mock_volume_manager,
|
|
self.mock_db,
|
|
self.mock_driver,
|
|
image_volume_cache=self.mock_cache
|
|
)
|
|
|
|
with mock.patch('os.path.exists', return_value=True):
|
|
manager._create_from_image(self.ctxt,
|
|
volume,
|
|
image_location,
|
|
image_id,
|
|
image_meta,
|
|
self.mock_image_service)
|
|
|
|
# Make sure clone_image is always called
|
|
self.assertTrue(self.mock_driver.clone_image.called)
|
|
|
|
# The image download should happen if clone fails and
|
|
# we get a cache miss
|
|
mock_create_from_img_dl.assert_called_once_with(
|
|
self.ctxt,
|
|
mock.ANY,
|
|
image_location,
|
|
image_meta,
|
|
self.mock_image_service
|
|
)
|
|
|
|
# The volume size should be reduced to virtual_size and then put back
|
|
mock_volume_update.assert_any_call(self.ctxt, volume.id, {'size': 2})
|
|
mock_volume_update.assert_any_call(self.ctxt, volume.id, {'size': 10})
|
|
|
|
# Make sure created a new cache entry
|
|
(self.mock_volume_manager.
|
|
_create_image_cache_volume_entry.assert_called_once_with(
|
|
self.ctxt, volume, image_id, image_meta))
|
|
|
|
mock_handle_bootable.assert_called_once_with(
|
|
self.ctxt,
|
|
volume,
|
|
image_id=image_id,
|
|
image_meta=image_meta
|
|
)
|
|
|
|
@mock.patch('cinder.db.volume_update')
|
|
@mock.patch('cinder.objects.Volume.get_by_id')
|
|
@mock.patch('cinder.image.image_utils.qemu_img_info')
|
|
@mock.patch('cinder.image.image_utils.check_available_space')
|
|
@mock.patch('cinder.image.image_utils.verify_glance_image_signature')
|
|
def test_create_from_image_cache_miss_error_downloading(
|
|
self, mock_verify, mock_check_size, mock_qemu_info,
|
|
mock_volume_get, mock_volume_update, mock_get_internal_context,
|
|
mock_create_from_img_dl, mock_create_from_src,
|
|
mock_handle_bootable, mock_fetch_img):
|
|
mock_fetch_img.return_value = mock.MagicMock()
|
|
image_info = imageutils.QemuImgInfo()
|
|
image_info.virtual_size = '2147483648'
|
|
mock_qemu_info.return_value = image_info
|
|
self.mock_driver.clone_image.return_value = (None, False)
|
|
self.mock_cache.get_entry.return_value = None
|
|
self.flags(verify_glance_signatures='disabled')
|
|
|
|
volume = fake_volume.fake_volume_obj(self.ctxt, size=10,
|
|
host='foo@bar#pool')
|
|
mock_volume_get.return_value = volume
|
|
|
|
mock_create_from_img_dl.side_effect = exception.CinderException()
|
|
|
|
image_location = 'someImageLocationStr'
|
|
image_id = fakes.IMAGE_ID
|
|
image_meta = mock.MagicMock()
|
|
|
|
manager = create_volume_manager.CreateVolumeFromSpecTask(
|
|
self.mock_volume_manager,
|
|
self.mock_db,
|
|
self.mock_driver,
|
|
image_volume_cache=self.mock_cache
|
|
)
|
|
|
|
with mock.patch('os.path.exists', return_value=True):
|
|
self.assertRaises(
|
|
exception.CinderException,
|
|
manager._create_from_image,
|
|
self.ctxt,
|
|
volume,
|
|
image_location,
|
|
image_id,
|
|
image_meta,
|
|
self.mock_image_service
|
|
)
|
|
|
|
# Make sure clone_image is always called
|
|
self.assertTrue(self.mock_driver.clone_image.called)
|
|
|
|
# The image download should happen if clone fails and
|
|
# we get a cache miss
|
|
mock_create_from_img_dl.assert_called_once_with(
|
|
self.ctxt,
|
|
mock.ANY,
|
|
image_location,
|
|
image_meta,
|
|
self.mock_image_service
|
|
)
|
|
|
|
# The volume size should be reduced to virtual_size and then put back,
|
|
# especially if there is an exception while creating the volume.
|
|
self.assertEqual(2, mock_volume_update.call_count)
|
|
mock_volume_update.assert_any_call(self.ctxt, volume.id, {'size': 2})
|
|
mock_volume_update.assert_any_call(self.ctxt, volume.id, {'size': 10})
|
|
|
|
# Make sure we didn't try and create a cache entry
|
|
self.assertFalse(self.mock_cache.ensure_space.called)
|
|
self.assertFalse(self.mock_cache.create_cache_entry.called)
|
|
|
|
@mock.patch('cinder.image.image_utils.qemu_img_info')
|
|
@mock.patch('cinder.image.image_utils.check_available_space')
|
|
@mock.patch('cinder.image.image_utils.verify_glance_image_signature')
|
|
def test_create_from_image_no_internal_context(
|
|
self, mock_verify, mock_chk_space, mock_qemu_info,
|
|
mock_get_internal_context,
|
|
mock_create_from_img_dl, mock_create_from_src,
|
|
mock_handle_bootable, mock_fetch_img):
|
|
self.mock_driver.clone_image.return_value = (None, False)
|
|
mock_get_internal_context.return_value = None
|
|
self.flags(verify_glance_signatures='disabled')
|
|
volume = fake_volume.fake_volume_obj(self.ctxt,
|
|
host='host@backend#pool')
|
|
image_info = imageutils.QemuImgInfo()
|
|
image_info.virtual_size = '1073741824'
|
|
mock_qemu_info.return_value = image_info
|
|
|
|
image_location = 'someImageLocationStr'
|
|
image_id = fakes.IMAGE_ID
|
|
image_meta = {'virtual_size': '1073741824', 'size': 1073741824}
|
|
|
|
manager = create_volume_manager.CreateVolumeFromSpecTask(
|
|
self.mock_volume_manager,
|
|
self.mock_db,
|
|
self.mock_driver,
|
|
image_volume_cache=self.mock_cache
|
|
)
|
|
|
|
manager._create_from_image(self.ctxt,
|
|
volume,
|
|
image_location,
|
|
image_id,
|
|
image_meta,
|
|
self.mock_image_service)
|
|
|
|
# Make sure check_available_space is always called
|
|
self.assertTrue(mock_chk_space.called)
|
|
|
|
# Make sure clone_image is always called
|
|
self.assertTrue(self.mock_driver.clone_image.called)
|
|
|
|
# Create from source shouldn't happen if cache cannot be used.
|
|
self.assertFalse(mock_create_from_src.called)
|
|
|
|
# The image download should happen if clone fails and we can't use the
|
|
# image-volume cache due to not having an internal context available.
|
|
mock_create_from_img_dl.assert_called_once_with(
|
|
self.ctxt,
|
|
volume,
|
|
image_location,
|
|
image_meta,
|
|
self.mock_image_service
|
|
)
|
|
|
|
# This should not attempt to use a minimal size volume
|
|
self.assertFalse(self.mock_db.volume_update.called)
|
|
|
|
# Make sure we didn't try and create a cache entry
|
|
self.assertFalse(self.mock_cache.ensure_space.called)
|
|
self.assertFalse(self.mock_cache.create_cache_entry.called)
|
|
|
|
mock_handle_bootable.assert_called_once_with(
|
|
self.ctxt,
|
|
volume,
|
|
image_id=image_id,
|
|
image_meta=image_meta
|
|
)
|
|
|
|
@mock.patch('cinder.volume.flows.manager.create_volume.'
|
|
'CreateVolumeFromSpecTask.'
|
|
'_cleanup_cg_in_volume')
|
|
@mock.patch('cinder.image.image_utils.check_available_space')
|
|
@mock.patch('cinder.image.image_utils.qemu_img_info')
|
|
@mock.patch('cinder.image.image_utils.verify_glance_image_signature')
|
|
def test_create_from_image_cache_miss_error_size_invalid(
|
|
self, mock_verify, mock_qemu_info, mock_check_space,
|
|
mock_get_internal_context,
|
|
mock_create_from_img_dl, mock_create_from_src,
|
|
mock_handle_bootable, mock_fetch_img, mock_cleanup_cg):
|
|
mock_fetch_img.return_value = mock.MagicMock()
|
|
image_info = imageutils.QemuImgInfo()
|
|
image_info.virtual_size = '2147483648'
|
|
mock_qemu_info.return_value = image_info
|
|
self.mock_driver.clone_image.return_value = (None, False)
|
|
self.mock_cache.get_entry.return_value = None
|
|
self.flags(verify_glance_signatures='disabled')
|
|
|
|
volume = fake_volume.fake_volume_obj(self.ctxt, size=1,
|
|
host='foo@bar#pool')
|
|
image_volume = fake_volume.fake_db_volume(size=2)
|
|
self.mock_db.volume_create.return_value = image_volume
|
|
|
|
image_location = 'someImageLocationStr'
|
|
image_id = fakes.IMAGE_ID
|
|
image_meta = mock.MagicMock()
|
|
|
|
manager = create_volume_manager.CreateVolumeFromSpecTask(
|
|
self.mock_volume_manager,
|
|
self.mock_db,
|
|
self.mock_driver,
|
|
image_volume_cache=self.mock_cache
|
|
)
|
|
|
|
with mock.patch('os.path.exists', return_value=True):
|
|
self.assertRaises(
|
|
exception.ImageUnacceptable,
|
|
manager._create_from_image,
|
|
self.ctxt,
|
|
volume,
|
|
image_location,
|
|
image_id,
|
|
image_meta,
|
|
self.mock_image_service
|
|
)
|
|
|
|
self.assertTrue(mock_cleanup_cg.called)
|
|
# The volume size should NOT be changed when in this case
|
|
self.assertFalse(self.mock_db.volume_update.called)
|
|
|
|
# Make sure we didn't try and create a cache entry
|
|
self.assertFalse(self.mock_cache.ensure_space.called)
|
|
self.assertFalse(self.mock_cache.create_cache_entry.called)
|
|
|
|
@mock.patch('cinder.image.image_utils.check_available_space')
|
|
@mock.patch('cinder.image.image_utils.qemu_img_info')
|
|
@mock.patch('cinder.message.api.API.create')
|
|
def test_create_from_image_insufficient_space(
|
|
self, mock_message_create, mock_qemu_info, mock_check_space,
|
|
mock_get_internal_context,
|
|
mock_create_from_img_dl, mock_create_from_src,
|
|
mock_handle_bootable, mock_fetch_img):
|
|
image_info = imageutils.QemuImgInfo()
|
|
image_info.virtual_size = '2147483648'
|
|
mock_qemu_info.return_value = image_info
|
|
self.mock_driver.clone_image.return_value = (None, False)
|
|
self.mock_cache.get_entry.return_value = None
|
|
|
|
volume = fake_volume.fake_volume_obj(self.ctxt, size=1,
|
|
host='foo@bar#pool')
|
|
image_volume = fake_volume.fake_db_volume(size=2)
|
|
self.mock_db.volume_create.return_value = image_volume
|
|
|
|
image_location = 'someImageLocationStr'
|
|
image_id = fakes.IMAGE_ID
|
|
image_meta = mock.MagicMock()
|
|
mock_check_space.side_effect = exception.ImageTooBig(
|
|
image_id=image_id, reason="fake")
|
|
|
|
manager = create_volume_manager.CreateVolumeFromSpecTask(
|
|
self.mock_volume_manager,
|
|
self.mock_db,
|
|
self.mock_driver,
|
|
image_volume_cache=self.mock_cache
|
|
)
|
|
|
|
self.assertRaises(
|
|
exception.ImageTooBig,
|
|
manager._create_from_image,
|
|
self.ctxt,
|
|
volume,
|
|
image_location,
|
|
image_id,
|
|
image_meta,
|
|
self.mock_image_service
|
|
)
|
|
|
|
mock_message_create.assert_called_once_with(
|
|
self.ctxt, message_field.Action.COPY_IMAGE_TO_VOLUME,
|
|
resource_uuid=volume.id,
|
|
detail=message_field.Detail.NOT_ENOUGH_SPACE_FOR_IMAGE,
|
|
exception=mock.ANY)
|
|
|
|
# The volume size should NOT be changed when in this case
|
|
self.assertFalse(self.mock_db.volume_update.called)
|
|
|
|
# Make sure we didn't try and create a cache entry
|
|
self.assertFalse(self.mock_cache.ensure_space.called)
|
|
self.assertFalse(self.mock_cache.create_cache_entry.called)
|
|
|
|
@mock.patch('cinder.image.image_utils.check_available_space')
|
|
@mock.patch('cinder.image.image_utils.qemu_img_info')
|
|
@mock.patch('cinder.message.api.API.create')
|
|
@mock.patch('cinder.image.image_utils.verify_glance_image_signature')
|
|
def test_create_from_image_cache_insufficient_size(
|
|
self, mock_verify, mock_message_create, mock_qemu_info,
|
|
mock_check_space,
|
|
mock_get_internal_context,
|
|
mock_create_from_img_dl, mock_create_from_src,
|
|
mock_handle_bootable, mock_fetch_img):
|
|
image_info = imageutils.QemuImgInfo()
|
|
image_info.virtual_size = '1073741824'
|
|
mock_qemu_info.return_value = image_info
|
|
self.mock_driver.clone_image.return_value = (None, False)
|
|
self.mock_cache.get_entry.return_value = None
|
|
volume = fake_volume.fake_volume_obj(self.ctxt, size=1,
|
|
host='foo@bar#pool')
|
|
image_volume = fake_volume.fake_db_volume(size=2)
|
|
self.mock_db.volume_create.return_value = image_volume
|
|
image_id = fakes.IMAGE_ID
|
|
mock_create_from_img_dl.side_effect = exception.ImageTooBig(
|
|
image_id=image_id, reason="fake")
|
|
self.flags(verify_glance_signatures='disabled')
|
|
|
|
image_location = 'someImageLocationStr'
|
|
image_meta = mock.MagicMock()
|
|
|
|
manager = create_volume_manager.CreateVolumeFromSpecTask(
|
|
self.mock_volume_manager,
|
|
self.mock_db,
|
|
self.mock_driver,
|
|
image_volume_cache=self.mock_cache
|
|
)
|
|
|
|
self.assertRaises(
|
|
exception.ImageTooBig,
|
|
manager._create_from_image_cache_or_download,
|
|
self.ctxt,
|
|
volume,
|
|
image_location,
|
|
image_id,
|
|
image_meta,
|
|
self.mock_image_service
|
|
)
|
|
|
|
mock_message_create.assert_called_once_with(
|
|
self.ctxt, message_field.Action.COPY_IMAGE_TO_VOLUME,
|
|
resource_uuid=volume.id,
|
|
detail=message_field.Detail.NOT_ENOUGH_SPACE_FOR_IMAGE,
|
|
exception=mock.ANY)
|
|
|
|
# The volume size should NOT be changed when in this case
|
|
self.assertFalse(self.mock_db.volume_update.called)
|
|
|
|
# Make sure we didn't try and create a cache entry
|
|
self.assertFalse(self.mock_cache.ensure_space.called)
|
|
self.assertFalse(self.mock_cache.create_cache_entry.called)
|
|
|
|
@ddt.data(None, {'volume_id': fakes.VOLUME_ID})
|
|
@mock.patch('cinder.volume.flows.manager.create_volume.'
|
|
'CreateVolumeFromSpecTask.'
|
|
'_create_from_image_cache_or_download')
|
|
def test_prepare_image_cache_entry(
|
|
self,
|
|
mock_cache_entry,
|
|
mock_create_from_image_cache_or_download,
|
|
mock_get_internal_context,
|
|
mock_create_from_img_dl, mock_create_from_src,
|
|
mock_handle_bootable, mock_fetch_img):
|
|
self.mock_cache.get_entry.return_value = mock_cache_entry
|
|
volume = fake_volume.fake_volume_obj(self.ctxt,
|
|
id=fakes.VOLUME_ID,
|
|
host='host@backend#pool')
|
|
image_location = 'someImageLocationStr'
|
|
image_id = fakes.IMAGE_ID
|
|
image_meta = {'virtual_size': '1073741824', 'size': 1073741824}
|
|
|
|
manager = create_volume_manager.CreateVolumeFromSpecTask(
|
|
self.mock_volume_manager,
|
|
self.mock_db,
|
|
self.mock_driver,
|
|
image_volume_cache=self.mock_cache
|
|
)
|
|
model_update, cloned = manager._prepare_image_cache_entry(
|
|
self.ctxt,
|
|
volume,
|
|
image_location,
|
|
image_id,
|
|
image_meta,
|
|
self.mock_image_service)
|
|
|
|
if mock_cache_entry:
|
|
# Entry is in cache, so basically don't do anything.
|
|
self.assertFalse(cloned)
|
|
self.assertIsNone(model_update)
|
|
mock_create_from_image_cache_or_download.assert_not_called()
|
|
else:
|
|
# Entry is not in cache, so do the work that will add it.
|
|
self.assertTrue(cloned)
|
|
self.assertEqual(
|
|
mock_create_from_image_cache_or_download.return_value,
|
|
model_update)
|
|
mock_create_from_image_cache_or_download.assert_called_once_with(
|
|
self.ctxt,
|
|
volume,
|
|
image_location,
|
|
image_id,
|
|
image_meta,
|
|
self.mock_image_service,
|
|
update_cache=True)
|